Fixing transactional anomalies found in PolicyManagerImpl

components/policy-mgt/org.wso2.carbon.policy.mgt.core/src/main/java/org/wso2/carbon/policy/mgt/core/mgt/impl/MonitoringManagerImpl.java

@@ -106,17 +106,17 @@ public class MonitoringManagerImpl implements MonitoringManager {
                     PolicyManagementDAOFactory.closeConnection();
                 }
 
-                PolicyManagementDAOFactory.beginTransaction();
                 //This was added because update query below that did not return the update table primary key.
 
                 if (!complianceFeatures.isEmpty()) {
-
+                    PolicyManagementDAOFactory.beginTransaction();
                     monitoringDAO.setDeviceAsNoneCompliance(device.getId(), policy.getId());
                     if (log.isDebugEnabled()) {
                         log.debug("Compliance status primary key " + complianceData.getId());
                     }
 //                    complianceData.setId(cmf.getId());
                     monitoringDAO.addNoneComplianceFeatures(complianceData.getId(), device.getId(), complianceFeatures);
+                    PolicyManagementDAOFactory.commitTransaction();
                     complianceDecisionPoint.validateDevicePolicyCompliance(deviceIdentifier, complianceData);
                     List<ProfileFeature> profileFeatures = policy.getProfile().getProfileFeaturesList();
                     for (ComplianceFeature compFeature : complianceFeatures) {
@@ -127,11 +127,12 @@ public class MonitoringManagerImpl implements MonitoringManager {
                         }
                     }
                 } else {
+                    PolicyManagementDAOFactory.beginTransaction();
                     monitoringDAO.setDeviceAsCompliance(device.getId(), policy.getId());
                     //complianceData.setId(cmf.getId());
                     monitoringDAO.deleteNoneComplianceData(complianceData.getId());
-                }
                     PolicyManagementDAOFactory.commitTransaction();
+                }
             } else {
                 if (log.isDebugEnabled()) {
                     log.debug("There is no policy applied to this device, hence compliance monitoring was not called.");

components/policy-mgt/org.wso2.carbon.policy.mgt.core/src/main/java/org/wso2/carbon/policy/mgt/core/mgt/impl/PolicyManagerImpl.java

@@ -765,12 +765,11 @@ public class PolicyManagerImpl implements PolicyManager {
     public Policy getAppliedPolicyToDevice(DeviceIdentifier deviceIdentifier) throws PolicyManagementException {
         Policy policy;
         try {
-            PolicyManagementDAOFactory.openConnection();
             DeviceManagementProviderService service = new DeviceManagementProviderServiceImpl();
             Device device = service.getDevice(deviceIdentifier);
             //int policyId = policyDAO.getAppliedPolicyId(device.getId());
+            PolicyManagementDAOFactory.openConnection();
             policy = policyDAO.getAppliedPolicy(device.getId());
-
         } catch (DeviceManagementException e) {
             throw new PolicyManagementException("Error occurred while getting device id.", e);
         } catch (PolicyManagerDAOException e) {