Add validation for user deletion (#244)

## Purpose
* Fixes https://roadmap.entgra.net/issues/10337

## Description
* Add validation to check whether the user has enrolled devices

Co-authored-by: prathabanKavin <kavinprathaban025@gmail.com>
Reviewed-on: community/device-mgt-core#244
Co-authored-by: Kavin Prathaban <kavin@entgra.io>
Co-committed-by: Kavin Prathaban <kavin@entgra.io>

components/device-mgt/io.entgra.device.mgt.core.device.mgt.api/src/main/java/io/entgra/device/mgt/core/device/mgt/api/jaxrs/service/impl/UserManagementServiceImpl.java

@@ -19,6 +19,7 @@ package io.entgra.device.mgt.core.device.mgt.api.jaxrs.service.impl;
 
 import com.google.gson.JsonArray;
 import com.google.gson.JsonObject;
+import io.entgra.device.mgt.core.device.mgt.common.Device;
 import org.apache.commons.lang.StringUtils;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
@@ -320,32 +321,42 @@ public class UserManagementServiceImpl implements UserManagementService {
     @Consumes(MediaType.WILDCARD)
     @Override
     public Response removeUser(@QueryParam("username") String username, @QueryParam("domain") String domain) {
+        boolean nameWithDomain = false;
         if (domain != null && !domain.isEmpty()) {
             username = domain + '/' + username;
+            nameWithDomain = true;
         }
         try {
+            int deviceCount;
             UserStoreManager userStoreManager = DeviceMgtAPIUtils.getUserStoreManager();
             if (!userStoreManager.isExistingUser(username)) {
                 if (log.isDebugEnabled()) {
-                    log.debug("User by username: " + username + " does not exist for removal.");
+                    log.debug("User by user: " + username + " does not exist for removal.");
                 }
-                String msg = "User by username: " + username + " does not exist for removal.";
+                String msg = "User by user: " + username + " does not exist for removal.";
                 return Response.status(Response.Status.NOT_FOUND).entity(msg).build();
             }
-            // Un-enroll all devices for the user
             DeviceManagementProviderService deviceManagementService = DeviceMgtAPIUtils.getDeviceManagementService();
-            deviceManagementService.setStatus(username, EnrolmentInfo.Status.REMOVED);
+            if (nameWithDomain) {
-
+                deviceCount = deviceManagementService.getDeviceCount(username.split("/")[1]);
-            userStoreManager.deleteUser(username);
+            } else {
-            if (log.isDebugEnabled()) {
+                deviceCount = deviceManagementService.getDeviceCount(username);
-                log.debug("User '" + username + "' was successfully removed.");
+            }
+            if (deviceCount == 0) {
+                userStoreManager.deleteUser(username);
+                if (log.isDebugEnabled()) {
+                    log.debug("User '" + username + "' was successfully removed.");
+                }
+                return Response.status(Response.Status.OK).build();
+            } else {
+                String msg = "There are enrolled devices for user: " + username + ". Please remove them before deleting the user.";
+                log.error(msg);
+                return Response.status(400).entity(msg).build();
             }
-            return Response.status(Response.Status.OK).build();
         } catch (DeviceManagementException | UserStoreException e) {
-            String msg = "Exception in trying to remove user by username: " + username;
+            String msg = "Exception in trying to remove user by user: " + username;
             log.error(msg, e);
-            return Response.serverError().entity(
+            return Response.status(400).entity(msg).build();
-                    new ErrorResponse.ErrorResponseBuilder().setMessage(msg).build()).build();
         }
     }
 

components/device-mgt/io.entgra.device.mgt.core.device.mgt.api/src/test/java/io/entgra/device/mgt/core/device/mgt/api/jaxrs/service/impl/UserManagementServiceImplTest.java

@@ -18,6 +18,7 @@
 
 package io.entgra.device.mgt.core.device.mgt.api.jaxrs.service.impl;
 
+import io.entgra.device.mgt.core.device.mgt.common.Device;
 import org.mockito.Mockito;
 import org.mockito.invocation.InvocationOnMock;
 import org.mockito.stubbing.Answer;
@@ -272,7 +273,7 @@ public class UserManagementServiceImplTest {
                 .toReturn(this.userStoreManager);
         PowerMockito.stub(PowerMockito.method(DeviceMgtAPIUtils.class, "getDeviceManagementService"))
                 .toReturn(this.deviceManagementProviderService);
-        Mockito.doReturn(true).when(deviceManagementProviderService).setStatus(Mockito.anyString(), Mockito.any());
+        Mockito.doReturn(0).when(deviceManagementProviderService).getDeviceCount(TEST_USERNAME);
         Mockito.doNothing().when(userStoreManager).deleteUser(Mockito.anyString());
         Response response = userManagementService.removeUser(TEST_USERNAME, null);
         Assert.assertEquals(response.getStatus(), Response.Status.OK.getStatusCode(),
@@ -337,7 +338,7 @@ public class UserManagementServiceImplTest {
         Assert.assertEquals(response.getStatus(), Response.Status.INTERNAL_SERVER_ERROR.getStatusCode(),
                 "Response returned successful for a user updating request with problematic inputs");
         response = userManagementService.removeUser(TEST3_USERNAME, null);
-        Assert.assertEquals(response.getStatus(), Response.Status.INTERNAL_SERVER_ERROR.getStatusCode(),
+        Assert.assertEquals(response.getStatus(), Response.Status.BAD_REQUEST.getStatusCode(),
                 "Response returned successful for a user removal request with problematic inputs");
         response = userManagementService.getRolesOfUser(TEST3_USERNAME, null);
         Assert.assertEquals(response.getStatus(), Response.Status.INTERNAL_SERVER_ERROR.getStatusCode(),