Merge branch 'master' of https://github.com/wso2/carbon-device-mgt

components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/operation/mgt/OperationManagerImpl.java

@@ -129,10 +129,15 @@ public class OperationManagerImpl implements OperationManager {
         int enrolmentId;
         List<Operation> operations = new ArrayList<>();
         try {
-            OperationManagementDAOFactory.openConnection();
-
+            try {
+                DeviceManagementDAOFactory.openConnection();
                 int tenantId = CarbonContext.getThreadLocalCarbonContext().getTenantId();
                 enrolmentId = deviceDAO.getEnrolmentByStatus(deviceId, EnrolmentInfo.Status.ACTIVE, tenantId);
+            } finally {
+                DeviceManagementDAOFactory.closeConnection();
+            }
+
+            OperationManagementDAOFactory.openConnection();
 
             if (enrolmentId < 0) {
                 throw new OperationManagementException("Device not found for given device " +
@@ -170,11 +175,17 @@ public class OperationManagerImpl implements OperationManager {
         List<Operation> operations = new ArrayList<>();
         List<org.wso2.carbon.device.mgt.core.dto.operation.mgt.Operation> dtoOperationList = new ArrayList<>();
         try {
-            OperationManagementDAOFactory.openConnection();
 
+            try {
+                DeviceManagementDAOFactory.openConnection();
                 int tenantId = CarbonContext.getThreadLocalCarbonContext().getTenantId();
                 enrolmentId = deviceDAO.getEnrolmentByStatus(deviceId, EnrolmentInfo.Status.ACTIVE, tenantId);
 
+            } finally {
+                DeviceManagementDAOFactory.closeConnection();
+            }
+            
+            OperationManagementDAOFactory.openConnection();
             if (enrolmentId < 0) {
                 throw new OperationManagementException("Device not found for the given device Identifier:" +
                         deviceId.getId() + " and given type:" + deviceId.getType());
@@ -223,10 +234,15 @@ public class OperationManagerImpl implements OperationManager {
         Operation operation = null;
         int enrolmentId;
         try {
-            OperationManagementDAOFactory.openConnection();
-
+            try {
+                DeviceManagementDAOFactory.openConnection();
                 int tenantId = CarbonContext.getThreadLocalCarbonContext().getTenantId();
                 enrolmentId = deviceDAO.getEnrolmentByStatus(deviceId, EnrolmentInfo.Status.ACTIVE, tenantId);
+            } finally {
+                DeviceManagementDAOFactory.closeConnection();
+            }
+
+            OperationManagementDAOFactory.openConnection();
 
             if (enrolmentId < 0) {
                 throw new OperationManagementException("Device not found for given device " +
@@ -274,11 +290,19 @@ public class OperationManagerImpl implements OperationManager {
         if (log.isDebugEnabled()) {
             log.debug("operation Id:" + operationId + " status:" + operation.getStatus());
         }
+        int enrolmentId;
         try {
-            OperationManagementDAOFactory.beginTransaction();
-
+            try {
+                DeviceManagementDAOFactory.openConnection();
                 int tenantId = CarbonContext.getThreadLocalCarbonContext().getTenantId();
-            int enrolmentId = deviceDAO.getEnrolmentByStatus(deviceId, EnrolmentInfo.Status.ACTIVE, tenantId);
+                enrolmentId = deviceDAO.getEnrolmentByStatus(deviceId, EnrolmentInfo.Status.ACTIVE, tenantId);
+            } catch (SQLException e) {
+                throw new OperationManagementException("Error occurred while opening a connection to the data source", e);
+            } finally {
+                DeviceManagementDAOFactory.closeConnection();
+            }
+
+            OperationManagementDAOFactory.beginTransaction();
 
             if (operation.getStatus() != null) {
                 operationDAO.updateOperationStatus(enrolmentId, operationId,
@@ -337,10 +361,16 @@ public class OperationManagerImpl implements OperationManager {
                     deviceId.getId());
         }
         try {
-            OperationManagementDAOFactory.openConnection();
-
+            try {
+                DeviceManagementDAOFactory.openConnection();
                 int tenantId = CarbonContext.getThreadLocalCarbonContext().getTenantId();
                 enrolmentId = deviceDAO.getEnrolmentByStatus(deviceId, EnrolmentInfo.Status.ACTIVE, tenantId);
+            } finally {
+                DeviceManagementDAOFactory.closeConnection();
+            }
+
+            OperationManagementDAOFactory.openConnection();
+
             if (enrolmentId < 0) {
                 throw new OperationManagementException("Device not found for given device identifier:" +
                         deviceId.getId() + " type:" + deviceId.getType());
@@ -393,11 +423,16 @@ public class OperationManagerImpl implements OperationManager {
         List<Operation> operations = new ArrayList<>();
         List<org.wso2.carbon.device.mgt.core.dto.operation.mgt.Operation> dtoOperationList =
                 new ArrayList<>();
+        int enrolmentId;
         try {
-            OperationManagementDAOFactory.openConnection();
-
+            try {
+                DeviceManagementDAOFactory.openConnection();
                 int tenantId = CarbonContext.getThreadLocalCarbonContext().getTenantId();
-            int enrolmentId = deviceDAO.getEnrolmentByStatus(deviceId, EnrolmentInfo.Status.ACTIVE, tenantId);
+                enrolmentId = deviceDAO.getEnrolmentByStatus(deviceId, EnrolmentInfo.Status.ACTIVE, tenantId);
+            } finally {
+                DeviceManagementDAOFactory.closeConnection();
+            }
+            OperationManagementDAOFactory.openConnection();
 
             if (enrolmentId < 0) {
                 throw new OperationManagementException("Device not found for device id:" + deviceId.getId() + " " +