Merge pull request #945 from pasindujw/master

Fixes validation errors in user create and group create.

components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/service/impl/GroupManagementServiceImpl.java

@@ -110,7 +110,7 @@ public class GroupManagementServiceImpl implements GroupManagementService {
             log.error(msg, e);
             return Response.status(Response.Status.INTERNAL_SERVER_ERROR).entity(msg).build();
         } catch (GroupAlreadyExistException e) {
-            String msg = "Group already exists with name '" + group.getName() + "'.";
+            String msg = "Group already exists with name " + group.getName() + ".";
             log.warn(msg);
             return Response.status(Response.Status.CONFLICT).entity(msg).build();
         }

components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/conf/config.json

@@ -46,7 +46,7 @@
   },
   "groupValidationConfig": {
     "groupNameJSRegEx": "^[\\S]{3,30}$",
-    "groupNameRegExViolationErrorMsg": "Provided group name is invalid.",
+    "groupNameRegExViolationErrorMsg": "Group name should be in minimum 3 characters long and should not include any whitespaces.",
     "groupNameHelpMsg": "Should be in minimum 3 characters long and should not include any whitespaces."
   },
   "roleValidationConfig": {

components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.user.create/public/js/bottomJs.js

@@ -256,6 +256,9 @@ $(document).ready(function () {
         } else if (!emailIsValid(emailAddress)) {
             $(errorMsg).text("Provided email is invalid.");
             $(errorMsgWrapper).removeClass("hidden");
+        } else if (!roles) {
+            $(errorMsg).text("Role is a required field. It cannot be empty.");
+            $(errorMsgWrapper).removeClass("hidden");
         } else {
             var addUserFormData = {};
 

components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.users/users.js

@@ -42,7 +42,5 @@ function onRequest(context) {
     if (userModule.isAuthorized("/permission/admin/device-mgt/users/view")) {
         page.canView = true;
     }
-
-
     return page;
 }