Merge pull request 'Fix issues with retrieving visible roles' (#191) from prathabanKavin/device-mgt-core:visiblefix into master

Reviewed-on: community/device-mgt-core#191

components/device-mgt/io.entgra.device.mgt.core.device.mgt.api/src/main/java/io/entgra/device/mgt/core/device/mgt/api/jaxrs/service/impl/RoleManagementServiceImpl.java

@@ -126,14 +126,14 @@ public class RoleManagementServiceImpl implements RoleManagementService {
         List<String> visibleRoles;
         RoleList visibleRoleList = new RoleList();
         try {
-            String metaValue = "{\"isUserAbleToViewAllRoles\":false}";
+            boolean decision = false;
             if(DeviceMgtAPIUtils.getMetadataManagementService().retrieveMetadata(metaKey) != null){
                 metadata = DeviceMgtAPIUtils.getMetadataManagementService().retrieveMetadata(metaKey);
-                metaValue = metadata.getMetaValue();
+                String metaValue = metadata.getMetaValue();
-            }
                 JSONParser parser = new JSONParser();
                 JSONObject jsonObject = (JSONObject) parser.parse(metaValue);
-            boolean decision = (boolean) jsonObject.get(Constants.IS_USER_ABLE_TO_VIEW_ALL_ROLES);
+                decision = (boolean) jsonObject.get(Constants.IS_USER_ABLE_TO_VIEW_ALL_ROLES);
+            }
             if (decision) {
                 if (userStore == null || "".equals(userStore)){
                     userStore = PRIMARY_USER_STORE;