Code formatting and refactoring for Permission Update Listeners of device types.

fix
Menaka Jayawardena 7 years ago
parent 3be4aaabc7
commit a7f270bae8

@ -32,9 +32,13 @@ import javax.servlet.ServletContextListener;
public class VirtualFireAlarmPermissionUpdateListener implements ServletContextListener { public class VirtualFireAlarmPermissionUpdateListener implements ServletContextListener {
private static Log log = LogFactory.getLog(VirtualFireAlarmPermissionUpdateListener.class); private static Log log = LogFactory.getLog(VirtualFireAlarmPermissionUpdateListener.class);
private static PrivilegedCarbonContext threadLocalCarbonContext;
private static RealmService realmService;
@Override @Override
public void contextInitialized(ServletContextEvent servletContextEvent) { public void contextInitialized(ServletContextEvent servletContextEvent) {
threadLocalCarbonContext = PrivilegedCarbonContext.getThreadLocalCarbonContext();
realmService = (RealmService) threadLocalCarbonContext.getOSGiService(RealmService.class, null);
UserStoreManager userStoreManager = getUserStoreManager(); UserStoreManager userStoreManager = getUserStoreManager();
try { try {
if (userStoreManager != null) { if (userStoreManager != null) {
@ -57,44 +61,34 @@ public class VirtualFireAlarmPermissionUpdateListener implements ServletContextL
} }
public static UserStoreManager getUserStoreManager() { private UserStoreManager getUserStoreManager() {
RealmService realmService;
UserStoreManager userStoreManager; UserStoreManager userStoreManager;
try { try {
PrivilegedCarbonContext ctx = PrivilegedCarbonContext.getThreadLocalCarbonContext();
realmService = (RealmService) ctx.getOSGiService(RealmService.class, null);
if (realmService == null) { if (realmService == null) {
String msg = "Realm service has not initialized."; String msg = "Realm service has not initialized.";
log.error(msg);
throw new IllegalStateException(msg); throw new IllegalStateException(msg);
} }
int tenantId = ctx.getTenantId(); int tenantId = threadLocalCarbonContext.getTenantId();
userStoreManager = realmService.getTenantUserRealm(tenantId).getUserStoreManager(); userStoreManager = realmService.getTenantUserRealm(tenantId).getUserStoreManager();
realmService.getTenantUserRealm(tenantId).getAuthorizationManager(); realmService.getTenantUserRealm(tenantId).getAuthorizationManager();
} catch (UserStoreException e) { } catch (UserStoreException e) {
String msg = "Error occurred while retrieving current user store manager"; String msg = "Error occurred while retrieving current user store manager";
log.error(msg, e);
throw new IllegalStateException(msg); throw new IllegalStateException(msg);
} }
return userStoreManager; return userStoreManager;
} }
public static AuthorizationManager getAuthorizationManager() { private AuthorizationManager getAuthorizationManager() {
RealmService realmService;
AuthorizationManager authorizationManager; AuthorizationManager authorizationManager;
try { try {
PrivilegedCarbonContext ctx = PrivilegedCarbonContext.getThreadLocalCarbonContext();
realmService = (RealmService) ctx.getOSGiService(RealmService.class, null);
if (realmService == null) { if (realmService == null) {
String msg = "Realm service has not initialized."; String msg = "Realm service has not initialized.";
log.error(msg);
throw new IllegalStateException(msg); throw new IllegalStateException(msg);
} }
int tenantId = ctx.getTenantId(); int tenantId = threadLocalCarbonContext.getTenantId();
authorizationManager = realmService.getTenantUserRealm(tenantId).getAuthorizationManager(); authorizationManager = realmService.getTenantUserRealm(tenantId).getAuthorizationManager();
} catch (UserStoreException e) { } catch (UserStoreException e) {
String msg = "Error occurred while retrieving current user store manager"; String msg = "Error occurred while retrieving current user store manager";
log.error(msg, e);
throw new IllegalStateException(msg); throw new IllegalStateException(msg);
} }
return authorizationManager; return authorizationManager;
@ -103,9 +97,8 @@ public class VirtualFireAlarmPermissionUpdateListener implements ServletContextL
private Permission[] getPermissions() { private Permission[] getPermissions() {
Permission androidSense = new Permission(VirtualFireAlarmConstants.PERM_ENROLL_FIRE_ALARM, Permission androidSense = new Permission(VirtualFireAlarmConstants.PERM_ENROLL_FIRE_ALARM,
CarbonConstants.UI_PERMISSION_ACTION); CarbonConstants.UI_PERMISSION_ACTION);
Permission view = new Permission(VirtualFireAlarmConstants.PERM_OWNING_DEVICE_VIEW, CarbonConstants Permission view = new Permission(VirtualFireAlarmConstants.PERM_OWNING_DEVICE_VIEW,
.UI_PERMISSION_ACTION); CarbonConstants.UI_PERMISSION_ACTION);
return new Permission[]{androidSense, view}; return new Permission[]{androidSense, view};
} }
} }
Loading…
Cancel
Save