removed method and type from feature

revert-70aa11f8
ayyoob 9 years ago
parent ec7727e8bf
commit bee9a106cc

@ -64,6 +64,7 @@ public class AnnotationUtil {
private static final String PACKAGE_ORG_SPRINGFRAMEWORK = "org.springframework"; private static final String PACKAGE_ORG_SPRINGFRAMEWORK = "org.springframework";
private static final String STRING_ARR = "string_arr"; private static final String STRING_ARR = "string_arr";
private static final String STRING = "string"; private static final String STRING = "string";
private static final String METHOD = "method";
private Class<org.wso2.carbon.device.mgt.extensions.feature.mgt.annotations.Feature> private Class<org.wso2.carbon.device.mgt.extensions.feature.mgt.annotations.Feature>
featureAnnotationClazz; featureAnnotationClazz;
private ClassLoader classLoader; private ClassLoader classLoader;
@ -147,8 +148,7 @@ public class AnnotationUtil {
Map<String, Object> apiParams = new HashMap<>(); Map<String, Object> apiParams = new HashMap<>();
for (int i = 0; i < annotations.length; i++) { for (int i = 0; i < annotations.length; i++) {
Annotation currentAnnotation = annotations[i]; Annotation currentAnnotation = annotations[i];
String method = processHttpMethodAnnotation(feature, currentAnnotation); processHttpMethodAnnotation(apiParams, currentAnnotation);
apiParams.put("method", method);
if (currentAnnotation.annotationType().getName().equals(Path.class.getName())) { if (currentAnnotation.annotationType().getName().equals(Path.class.getName())) {
String uri = getPathAnnotationValue(currentMethod); String uri = getPathAnnotationValue(currentMethod);
apiParams.put("uri", uri); apiParams.put("uri", uri);
@ -200,25 +200,20 @@ public class AnnotationUtil {
/** /**
* Read Method annotations indicating HTTP Methods * Read Method annotations indicating HTTP Methods
* @param feature
* @param currentAnnotation
* @return
*/ */
private String processHttpMethodAnnotation(Feature feature, Annotation currentAnnotation) { private void processHttpMethodAnnotation(Map<String, Object> apiParams, Annotation currentAnnotation) {
//Extracting method with which feature is exposed //Extracting method with which feature is exposed
String method = null;
if (currentAnnotation.annotationType().getName().equals(GET.class.getName())) { if (currentAnnotation.annotationType().getName().equals(GET.class.getName())) {
method = HttpMethod.GET; apiParams.put(METHOD, HttpMethod.GET);
} else if (currentAnnotation.annotationType().getName().equals(POST.class.getName())) { } else if (currentAnnotation.annotationType().getName().equals(POST.class.getName())) {
method = HttpMethod.POST; apiParams.put(METHOD, HttpMethod.POST);
} else if (currentAnnotation.annotationType().getName().equals(OPTIONS.class.getName())) { } else if (currentAnnotation.annotationType().getName().equals(OPTIONS.class.getName())) {
method = HttpMethod.OPTIONS; apiParams.put(METHOD, HttpMethod.OPTIONS);
} else if (currentAnnotation.annotationType().getName().equals(DELETE.class.getName())) { } else if (currentAnnotation.annotationType().getName().equals(DELETE.class.getName())) {
method = HttpMethod.DELETE; apiParams.put(METHOD, HttpMethod.DELETE);
} else if (currentAnnotation.annotationType().getName().equals(PUT.class.getName())) { } else if (currentAnnotation.annotationType().getName().equals(PUT.class.getName())) {
method = HttpMethod.PUT; apiParams.put(METHOD, HttpMethod.PUT);
} }
return method;
} }
/** /**
@ -233,15 +228,15 @@ public class AnnotationUtil {
Annotation featureAnno = currentMethod.getAnnotation(featureAnnotationClazz); Annotation featureAnno = currentMethod.getAnnotation(featureAnnotationClazz);
for (int k = 0; k < featureAnnoMethods.length; k++) { for (int k = 0; k < featureAnnoMethods.length; k++) {
switch (featureAnnoMethods[k].getName()) { switch (featureAnnoMethods[k].getName()) {
case "name": case "name":
feature.setName(invokeMethod(featureAnnoMethods[k], featureAnno, STRING)); feature.setName(invokeMethod(featureAnnoMethods[k], featureAnno, STRING));
break; break;
case "code": case "code":
feature.setCode(invokeMethod(featureAnnoMethods[k], featureAnno, STRING)); feature.setCode(invokeMethod(featureAnnoMethods[k], featureAnno, STRING));
break; break;
case "description": case "description":
feature.setDescription(invokeMethod(featureAnnoMethods[k], featureAnno, STRING)); feature.setDescription(invokeMethod(featureAnnoMethods[k], featureAnno, STRING));
break; break;
} }
} }
return feature; return feature;

@ -40,14 +40,11 @@ var operationModule = function () {
privateMethods.getOperationsFromFeatures = function (deviceType, operationType) { privateMethods.getOperationsFromFeatures = function (deviceType, operationType) {
var url = devicemgtProps["httpsURL"] + constants.ADMIN_SERVICE_CONTEXT + "/features/" + deviceType; var url = devicemgtProps["httpsURL"] + constants.ADMIN_SERVICE_CONTEXT + "/features/" + deviceType;
var featuresList = serviceInvokers.XMLHttp.get(url, function (responsePayload) { var featuresList = serviceInvokers.XMLHttp.get(url, function (responsePayload) {
var features = responsePayload; var features = responsePayload;
var featureList = []; var featureList = [];
var feature; var feature;
for (var i = 0; i < features.length; i++) { for (var i = 0; i < features.length; i++) {
feature = {}; feature = {};
if (features[i].type != operationType) {
continue;
} else if (features[i].type == 'monitor') {
var analyticStreams = utility.getDeviceTypeConfig(deviceType)["analyticStreams"]; var analyticStreams = utility.getDeviceTypeConfig(deviceType)["analyticStreams"];
if (analyticStreams) { if (analyticStreams) {
for (var stream in analyticStreams) { for (var stream in analyticStreams) {
@ -57,23 +54,22 @@ var operationModule = function () {
} }
} }
} }
}
feature["operation"] = features[i].code; feature["operation"] = features[i].code;
feature["name"] = features[i].name; feature["name"] = features[i].name;
feature["method"] = features[i].method; feature["description"] = features[i].description;
feature["description"] = features[i].description; feature["deviceType"] = deviceType;
feature["deviceType"] = deviceType; feature["params"] = [];
feature["params"] = []; var metaData = features[i].metadataEntries;
var metaData = features[i].metadataEntries; if (metaData) {
if (metaData) { for (var j = 0; j < metaData.length; j++) {
for (var j = 0; j < metaData.length; j++) { feature["params"].push(metaData[j].value);
feature["params"].push(metaData[j].value); }
featureList.push(feature);
} }
featureList.push(feature);
} }
} return featureList;
return featureList; }, function (responsePayload) {
}, function (responsePayload) {
var response = {}; var response = {};
response["status"] = "error"; response["status"] = "error";
return response; return response;

Loading…
Cancel
Save