Android Services Refactor

components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/DeviceManager.java

@@ -21,6 +21,7 @@ import org.wso2.carbon.device.mgt.common.Device;
 import org.wso2.carbon.device.mgt.common.DeviceIdentifier;
 import org.wso2.carbon.device.mgt.common.DeviceManagementException;
 import org.wso2.carbon.device.mgt.common.OperationManager;
+import org.wso2.carbon.device.mgt.core.dao.DeviceManagementDAOException;
 
 import java.util.List;
 

components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/DeviceManagerImpl.java

@@ -58,8 +58,7 @@ public class DeviceManagerImpl implements DeviceManager {
             this.getDeviceDAO().addDevice(deviceDto);
 
         } catch (DeviceManagementDAOException e) {
-            throw new DeviceManagementException("Error occurred while enrolling the device '" + device.getId() + "'",
+            throw new DeviceManagementException("Error occurred while enrolling the device '" + device.getId() + "'", e);
-                    e);
         }
         return status;
     }

components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/config/DeviceConfigurationManager.java

@@ -71,8 +71,4 @@ public class DeviceConfigurationManager {
         return currentDeviceConfig;
     }
 
-    public DataSourceConfig getDataSourceConfig() {
-        return currentDeviceConfig.getDeviceMgtRepository().getDataSourceConfig();
-    }
-
 }

components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/service/DeviceManagementService.java

@@ -19,7 +19,6 @@ import org.wso2.carbon.device.mgt.common.Device;
 import org.wso2.carbon.device.mgt.common.DeviceIdentifier;
 import org.wso2.carbon.device.mgt.common.DeviceManagementException;
 import org.wso2.carbon.device.mgt.common.OperationManager;
-import org.wso2.carbon.device.mgt.common.spi.DeviceManagerService;
 import org.wso2.carbon.device.mgt.core.DeviceManager;
 import org.wso2.carbon.device.mgt.core.internal.DeviceManagementDataHolder;
 
@@ -27,60 +26,61 @@ import java.util.List;
 
 public class DeviceManagementService implements DeviceManager {
 
-	@Override
+    @Override
-	public boolean enrollDevice(Device device) throws DeviceManagementException {
+    public boolean enrollDevice(Device device) throws DeviceManagementException {
-		return DeviceManagementDataHolder.getInstance().getDeviceManager().enrollDevice(device);
+        return DeviceManagementDataHolder.getInstance().getDeviceManager().enrollDevice(device);
-	}
+    }
-
+
-	@Override
+    @Override
-	public boolean modifyEnrollment(Device device) throws DeviceManagementException {
+    public boolean modifyEnrollment(Device device) throws DeviceManagementException {
-		return DeviceManagementDataHolder.getInstance().getDeviceManager().modifyEnrollment(device);
+        return DeviceManagementDataHolder.getInstance().getDeviceManager().modifyEnrollment(device);
-	}
+    }
-
+
-	@Override
+    @Override
-	public boolean disenrollDevice(DeviceIdentifier deviceId) throws DeviceManagementException {
+    public boolean disenrollDevice(DeviceIdentifier deviceId) throws DeviceManagementException {
-		return DeviceManagementDataHolder.getInstance().getDeviceManager()
+        return DeviceManagementDataHolder.getInstance().getDeviceManager()
-		                                 .disenrollDevice(deviceId);
+                .disenrollDevice(deviceId);
-	}
+    }
-
+
-	@Override
+    @Override
-	public boolean isEnrolled(DeviceIdentifier deviceId) throws DeviceManagementException {
+    public boolean isEnrolled(DeviceIdentifier deviceId) throws DeviceManagementException {
-		return DeviceManagementDataHolder.getInstance().getDeviceManager().isEnrolled(deviceId);
+        return DeviceManagementDataHolder.getInstance().getDeviceManager().isEnrolled(deviceId);
-	}
+    }
-
+
-	@Override
+    @Override
-	public boolean isActive(DeviceIdentifier deviceId) throws DeviceManagementException {
+    public boolean isActive(DeviceIdentifier deviceId) throws DeviceManagementException {
-		return DeviceManagementDataHolder.getInstance().getDeviceManager().isActive(deviceId);
+        return DeviceManagementDataHolder.getInstance().getDeviceManager().isActive(deviceId);
-	}
+    }
-
+
-	@Override
+    @Override
-	public boolean setActive(DeviceIdentifier deviceId, boolean status)
+    public boolean setActive(DeviceIdentifier deviceId, boolean status) throws DeviceManagementException {
-			throws DeviceManagementException {
+        return DeviceManagementDataHolder.getInstance().getDeviceManager().setActive(deviceId, status);
-		return DeviceManagementDataHolder.getInstance().getDeviceManager()
+    }
-		                                 .setActive(deviceId, status);
+
-	}
+    @Override
-
+    public List<Device> getAllDevices(String type) throws DeviceManagementException {
-	@Override
+        return DeviceManagementDataHolder.getInstance().getDeviceManager().getAllDevices(type);
-	public List<Device> getAllDevices(String type) throws DeviceManagementException {
+    }
-		return DeviceManagementDataHolder.getInstance().getDeviceManager().getAllDevices(type);
+
-	}
+    @Override
-
+    public org.wso2.carbon.device.mgt.common.Device getDevice(DeviceIdentifier deviceId)
-	@Override
+            throws DeviceManagementException {
-	public Device getDevice(DeviceIdentifier deviceId) throws DeviceManagementException {
+
-		return DeviceManagementDataHolder.getInstance().getDeviceManager().getDevice(deviceId);
+        Device device = DeviceManagementDataHolder.getInstance().getDeviceManager().getDevice(deviceId);
-	}
+        return device;
-
+    }
-	@Override
+
-	public boolean updateDeviceInfo(Device device) throws DeviceManagementException {
+    @Override
-		return DeviceManagementDataHolder.getInstance().getDeviceManager().updateDeviceInfo(device);
+    public boolean updateDeviceInfo(Device device) throws DeviceManagementException {
-	}
+        return DeviceManagementDataHolder.getInstance().getDeviceManager().updateDeviceInfo(device);
-
+    }
-	@Override
+
-	public boolean setOwnership(DeviceIdentifier deviceId, String ownershipType)
+    @Override
-			throws DeviceManagementException {
+    public boolean setOwnership(DeviceIdentifier deviceId, String ownershipType)
-		return DeviceManagementDataHolder.getInstance().getDeviceManager()
+            throws DeviceManagementException {
-		                                 .setOwnership(deviceId, ownershipType);
+        return DeviceManagementDataHolder.getInstance().getDeviceManager()
-	}
+                .setOwnership(deviceId, ownershipType);
+    }
 
     @Override
     public OperationManager getOperationManager(String type) throws DeviceManagementException {

product/modules/agents/android/jax-rs/src/main/java/cdm/api/android/Device.java

@@ -15,6 +15,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
+//org.wso2.carbon....
 package cdm.api.android;
 
 import cdm.api.android.common.AndroidAgentException;
@@ -65,7 +66,6 @@ public class Device {
         } catch (DeviceManagementException e) {
             msg = "Error occurred while fetching the device list.";
             LOG.error(msg, e);
-            Response.status(HttpStatus.SC_INTERNAL_SERVER_ERROR);
             throw new AndroidAgentException(msg, e);
         }
     }
@@ -80,7 +80,6 @@ public class Device {
 
         try {
             dmService = AndroidAPIUtils.getDeviceManagementService();
-
         } catch (DeviceManagementServiceException deviceMgtServiceEx) {
             String errorMsg = "Device management service error";
             LOG.error(errorMsg, deviceMgtServiceEx);
@@ -94,7 +93,6 @@ public class Device {
                 Response.status(HttpStatus.SC_NOT_FOUND);
             }
             return device;
-
         } catch (DeviceManagementException deviceMgtEx) {
             msg = "Error occurred while fetching the device information.";
             LOG.error(msg, deviceMgtEx);

product/modules/agents/android/jax-rs/src/main/java/cdm/api/android/Enrollment.java

@@ -101,9 +101,9 @@ public class Enrollment {
             }
             return responseMsg;
         } catch (DeviceManagementException deviceMgtEx) {
-            String errormsg = "Error occurred while enrollment of the device.";
+            String errorMsg = "Error occurred while enrollment of the device.";
-            log.error(errormsg, deviceMgtEx);
+            log.error(errorMsg, deviceMgtEx);
-            throw new AndroidAgentException(errormsg, deviceMgtEx);
+            throw new AndroidAgentException(errorMsg, deviceMgtEx);
         }
     }
 

product/modules/p2-profile-gen/pom.xml

@@ -153,12 +153,19 @@
                                 <featureArtifactDef>
                                     org.wso2.carbon:org.wso2.carbon.identity.provider.server.feature:${carbon.platform.version}
                                 </featureArtifactDef>
-                                <featureArtifactDef>
+
-                                    org.wso2.carbon:org.wso2.carbon.governance.metadata.server.feature:${carbon.platform.version}
+                                <!-- Registry Features -->
-                                </featureArtifactDef>
+                                <featureArtifactDef>org.wso2.carbon:org.wso2.carbon.registry.extensions.feature:${carbon.platform.version}</featureArtifactDef>
-                                <featureArtifactDef>
+                                <featureArtifactDef>org.wso2.carbon:org.wso2.carbon.registry.ws.feature:${carbon.platform.version}</featureArtifactDef>
-                                    org.wso2.carbon:org.wso2.carbon.registry.extensions.server.feature:${carbon.platform.version}
+                                <featureArtifactDef>org.wso2.carbon:org.wso2.carbon.registry.ui.menu.governance.feature:${carbon.platform.version}</featureArtifactDef>
-                                </featureArtifactDef>
+
+                                <!--Governance Feature-->
+                                <!--featureArtifactDef>org.wso2.carbon:org.wso2.carbon.gadget.initializer.feature:${carbon.platform.version}</featureArtifactDef-->
+                                <!--featureArtifactDef>org.wso2.carbon:org.wso2.carbon.gadget.editor.feature:${carbon.platform.version}</featureArtifactDef>
+                                <featureArtifactDef>org.wso2.carbon:org.wso2.carbon.gadget.editor.ui.feature:${carbon.platform.version}</featureArtifactDef-->
+                                <featureArtifactDef>org.wso2.carbon:org.wso2.carbon.governance.metadata.feature:4.2.2</featureArtifactDef>
+                                <featureArtifactDef>org.wso2.carbon:org.wso2.carbon.governance.lifecycle.management.feature:4.2.1</featureArtifactDef>
+
                                 <featureArtifactDef>
                                     org.wso2.carbon:org.wso2.carbon.identity.core.server.feature:${carbon.platform.version}
                                 </featureArtifactDef>