Modify the subscribed devices and category APIs

components/application-mgt/org.wso2.carbon.device.application.mgt.common/src/main/java/org/wso2/carbon/device/application/mgt/common/services/SubscriptionManager.java

@@ -32,30 +32,28 @@ public interface SubscriptionManager {
             String action) throws ApplicationManagementException;
 
     /***
-     * This method used to get the app id ,device ids and pass them to DM service method
+     * This method used to get the app id ,device ids and pass them to DM service method.
-     * @param appUUID UUID of the application release
+     *
-     * @param offsetValue offset value for get paginated result
+     * @param appUUID UUID of the application release.
-     * @param limitValue limit value for get paginated result
+     * @param offsetValue offset value for get paginated request.
-     * @param status status of the devices
+     * @param limitValue limit value for get paginated request.
+     * @param status status of the devices.
      * @return deviceDetails - device details for given application release.
-     * @throws ApplicationManagementException throws {@link ApplicationManagementException} Exception
+     * @throws {@link ApplicationManagementException} Exception of the application management
-     * of the application management
      */
     PaginationResult getAppInstalledDevices(int offsetValue, int limitValue, String appUUID,
-                                            String status)
+                                            String status) throws ApplicationManagementException;
-            throws ApplicationManagementException;
 
     /***
-     * This method used to get category details
+     * This method used to get category details.
-     * @param appUUID UUID of the application release
+     *
-     * @param subType subscription type of the application
+     * @param appUUID UUID of the application release.
-     * @param offsetValue offset value for get paginated result
+     * @param subType subscription type of the application.
-     * @param limitValue limit value for get paginated result
+     * @param offsetValue offset value for get paginated request.
+     * @param limitValue limit value for get paginated request.
      * @return {@link PaginationResult} pagination result of the category details.
-     * @throws ApplicationManagementException throws {@link ApplicationManagementException} Exception
+     * @throws {@link ApplicationManagementException} Exception of the application management
-     * of the application management
      */
     PaginationResult getAppInstalledCategories(int offsetValue, int limitValue, String appUUID,
-                                               String subType)
+                                               String subType) throws ApplicationManagementException;
-            throws ApplicationManagementException;
 }

components/application-mgt/org.wso2.carbon.device.application.mgt.core/src/main/java/org/wso2/carbon/device/application/mgt/core/dao/SubscriptionDAO.java

@@ -86,42 +86,42 @@ public interface SubscriptionDAO {
             throws ApplicationManagementDAOException;
 
     /**
-     * this method is used to get the details of users
+     * This method is used to get the details of users
+     *
      * @param tenantId id of the current tenant
      * @param offsetValue offset value for get paginated result
      * @param limitValue limit value for get paginated result
      * @param appReleaseId id of the application release.
      * @return subscribedUsers - list of app subscribed users.
-     * @throws ApplicationManagementDAOException throws {@link ApplicationManagementDAOException} if
+     * @throws {@link ApplicationManagementDAOException} if connections establishment fails.
-     * connections establishment fails.
      */
     List<String> getAppSubscribedUsers(int offsetValue, int limitValue, int appReleaseId,
                                        int tenantId)
             throws ApplicationManagementDAOException;
 
     /**
-     * this method is used to get the details of roles
+     * This method is used to get the details of roles
+     *
      * @param tenantId id of the current tenant
-     * @param offsetValue offset value for get paginated result
+     * @param offsetValue offset value for get paginated request.
-     * @param limitValue limit value for get paginated result
+     * @param limitValue limit value for get paginated request.
      * @param appReleaseId id of the application release.
      * @return subscribedRoles - list of app subscribed roles.
-     * @throws ApplicationManagementDAOException throws {@link ApplicationManagementDAOException} if
+     * @throws {@link ApplicationManagementDAOException} if connections establishment fails.
-     * connections establishment fails.
      */
     List<String> getAppSubscribedRoles(int offsetValue, int limitValue, int appReleaseId,
                                        int tenantId)
             throws ApplicationManagementDAOException;
 
     /**
-     * this method is used to get the details of subscribed groups
+     * This method is used to get the details of subscribed groups
+     *
      * @param tenantId id of the current tenant
-     * @param offsetValue offset value for get paginated result
+     * @param offsetValue offset value for get paginated request.
-     * @param limitValue limit value for get paginated result
+     * @param limitValue limit value for get paginated request.
      * @param appReleaseId id of the application release.
      * @return subscribedGroups - list of app subscribed groups.
-     * @throws ApplicationManagementDAOException throws {@link ApplicationManagementDAOException} if
+     * @throws {@link ApplicationManagementDAOException} if connections establishment fails.
-     * connections establishment fails.
      */
     List<String> getAppSubscribedGroups(int offsetValue, int limitValue, int appReleaseId,
                                         int tenantId)

components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/DeviceDAO.java

@@ -552,18 +552,17 @@ public interface DeviceDAO {
                                       String toDate) throws DeviceManagementDAOException;
 
     /**
-     * this method is used to get the details of subscribed devices.
+     * This method is used to get the details of subscribed devices.
+     *
      * @param deviceIds device ids of the subscribed devices.
      * @param tenantId Id of the current tenant.
-     * @param offsetValue offset value for get paginated result.
+     * @param offsetValue offset value for get paginated request.
-     * @param limitValue limit value for get paginated result.
+     * @param limitValue limit value for get paginated request.
      * @param status status of the devices.
      * @return devices - subscribed device details list
-     * @throws DeviceManagementDAOException throws {@link DeviceManagementDAOException} if connections
+     * @throws {@link DeviceManagementDAOException} if connections establishment fails.
-     * establishment fails.
      */
     List<Device> getSubscribedDevices(int offsetValue, int limitValue, List<Integer> deviceIds,
                                       int tenantId, String status)
             throws DeviceManagementDAOException;
-
 }

components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/service/DeviceManagementProviderService.java

@@ -771,13 +771,13 @@ public interface DeviceManagementProviderService {
 
     /**
      * This method retrieves a list of subscribed devices.
-     * @param devicesIds devices ids of the subscribed devices
+     *
-     * @param offsetValue offset value for get paginated result
+     * @param devicesIds devices ids of the subscribed devices.
-     * @param limitValue limit value for get paginated result
+     * @param offsetValue offset value for get paginated request.
-     * @param status status of the devices
+     * @param limitValue limit value for get paginated request.
+     * @param status status of the devices.
      * @return {@link PaginationResult}
-     * @throws DeviceManagementException throws {@link DeviceManagementException} if any service
+     * @throws {@link DeviceManagementException} if any service level or DAO level error occurs.
-     * level or DAO level error occurs
      */
     PaginationResult getAppSubscribedDevices(int offsetValue, int limitValue,
                                              List<Integer> devicesIds, String status)