Merge branch 'master' of https://github.com/wso2/carbon-device-mgt

components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/modules/business-controllers/user.js

@@ -42,7 +42,7 @@ var userModule = function () {
     privateMethods.getCarbonUser = function () {
         var carbon = require("carbon");
         var carbonUser = session.get(constants["USER_SESSION_KEY"]);
-        var utility = require("/modules/utility.js")["utility"];
+        var utility = require("/app/modules/utility.js")["utility"];
         if (!carbonUser) {
             log.error("User object was not found in the session");
             throw constants["ERRORS"]["USER_NOT_FOUND"];
@@ -174,7 +174,11 @@ var userModule = function () {
             utility.startTenantFlow(carbonUser);
             var url = devicemgtProps["httpsURL"] + devicemgtProps["backendRestEndpoints"]["deviceMgt"] + "/users/" +
                 encodeURIComponent(username) + "/roles";
-            return privateMethods.callBackend(url, constants["HTTP_GET"]);
+            var response = privateMethods.callBackend(url, constants["HTTP_GET"]);
+            if (response.status == "success") {
+                response.content = parse(response.content).roles;
+            }
+            return response;
         } catch (e) {
             throw e;
         } finally {
@@ -265,7 +269,7 @@ var userModule = function () {
     /**
      * Get Platforms.
      */
-    //TODO Move this piece of logic out of user.js to somewhere else appropriate.
+        //TODO Move this piece of logic out of user.js to somewhere else appropriate.
     publicMethods.getPlatforms = function () {
         var carbonUser = session.get(constants["USER_SESSION_KEY"]);
         var utility = require("/app/modules/utility.js")["utility"];

components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.user.create/create.hbs

@@ -56,9 +56,9 @@
                             </label>
                             <div class="wr-input-control">
                                 <select id="userStore" class="form-control select">
-                                    <option>PRIMARY</option>
+                                    <option value="PRIMARY">PRIMARY</option>
                                     {{#each userStores}}
-                                        <option>{{this}}</option>
+                                        <option value="{{this}}">{{this}}</option>
                                     {{/each}}
                                 </select>
                             </div>
@@ -113,15 +113,17 @@
             <div id="user-created-msg" class="container col-centered wr-content hidden">
                 <div class="wr-form">
                     <p class="page-sub-title">User was added successfully.</p>
-                    <br>
+                    <p>
-                    An invitation mail will be sent to this user to initiate device enrollment.
+                        An invitation mail will be sent to this user to initiate device enrollment.
-                    Below QR code can also be used to enroll a device.
+                        Below QR code can also be used to enroll a device.
-
+                    </p>
                     <div class="panel panel-default">
+                        <div id="qr-code-modal" class="hidden" data-enrollment-url="{{enrollmentURL}}"></div>
                         <div class="panel-body">
                             <div class="qr-code col-lg-5 col-md-6 col-centered"></div>
                         </div>
                     </div>
+
                     <br>Please click <b>"Add Another User"</b>, if you wish to add another user or click
                     <b>"View User List"</b> to complete the process and go back to the user list.
                     <hr/>

components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.user.create/create.js

@@ -39,6 +39,7 @@ function onRequest() {
     page["firstnameRegExViolationErrorMsg"] = devicemgtProps["userValidationConfig"]["firstnameRegExViolationErrorMsg"];
     page["lastnameJSRegEx"] = devicemgtProps["userValidationConfig"]["lastnameJSRegEx"];
     page["lastnameRegExViolationErrorMsg"] = devicemgtProps["userValidationConfig"]["lastnameRegExViolationErrorMsg"];
+    page["enrollmentURL"] = devicemgtProps["generalConfig"]["host"] + devicemgtProps["enrollmentDir"];
 
     return page;
 }

components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.user.create/public/js/bottomJs.js

@@ -161,6 +161,18 @@ function emailIsValid(email) {
     return regExp.test(email);
 }
 
+/*
+ * QR-code generation function.
+ */
+function generateQRCode(qrCodeClass) {
+    var enrollmentURL = $("#qr-code-modal").data("enrollment-url");
+    $(qrCodeClass).qrcode({
+        text: enrollmentURL,
+        width: 200,
+        height: 200
+    });
+}
+
 $("#userStore").change(
     function () {
         var str = "";

components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.user.edit/edit.hbs

@@ -15,7 +15,7 @@
   specific language governing permissions and limitations
   under the License.
 }}
-{{unit "cdmf.unit.ui.title" pageTitle="User Management"}}
+{{unit "cdmf.unit.ui.title" pageTitle="User Management | Edit User"}}
 
 {{#zone "breadcrumbs"}}
     <li>
@@ -51,6 +51,15 @@
                             <div id="user-create-error-msg" class="alert alert-danger hidden" role="alert">
                                 <i class="icon fw fw-error"></i><span></span>
                             </div>
+                            <label class="wr-input-label" title="Select the domain of the user store from the drop-down given below. The domain of the default user store is PRIMARY">
+                                User Store Domain
+                                <span class="wr-help-tip glyphicon glyphicon-question-sign"></span>
+                            </label>
+                            <div class="wr-input-control">
+                                <select id="userStore" class="form-control select" disabled>
+                                    <option value="{{userStore}}" selected>{{userStore}}</option>
+                                </select>
+                            </div>
                             <label class="wr-input-label">
                                 User Name <br>
                             </label>
@@ -59,8 +68,6 @@
                                        data-errormsg="{{usernameRegExViolationErrorMsg}}" class="form-control"
                                        value="{{editUser.username}}" disabled/>
                             </div>
-
-
                             <label class="wr-input-label">First Name *</label>
                             <div id="firstNameField" class="form-group wr-input-control">
                                 <input type="text" id="firstname" data-regex="{{firstnameJSRegEx}}"
@@ -95,12 +102,9 @@
                                 <span class="wr-help-tip glyphicon glyphicon-question-sign"></span>
                             </label>
                             <div class="wr-input-control">
-                                <select id="roles" class="form-control select2" multiple="multiple" selectedVals="
+                                <select id="roles" class="form-control select2" multiple="multiple"
-                                 {{#each usersRoles}}
+                                        selectedVals="{{#each rolesByUsername}} {{this}}, {{/each}}">
-                                    {{this}},
+                                    {{#each rolesByUserStore}}
-                                    {{/each}}
-                                ">
-                                    {{#each userRoles}}
                                         <option>{{this}}</option>
                                     {{/each}}
                                 </select>

components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.user.edit/edit.js

@@ -16,14 +16,16 @@
  * under the License.
  */
 
-function onRequest(context) {
+function onRequest() {
+    var devicemgtProps = require("/app/modules/conf-reader/main.js")["conf"];
     var userModule = require("/app/modules/business-controllers/user.js")["userModule"];
+
     var userName = request.getParameter("username");
     var user = userModule.getUser(userName)["content"];
-    var devicemgtProps = require("/app/modules/conf-reader/main.js")["conf"];
+    
     if (user) {
         var title;
-        if (user.firstname || user.lastname) {
+        if (user.firstname && user.lastname) {
             title = user.firstname + " " + user.lastname;
         } else {
             title = user.username;
@@ -34,6 +36,8 @@ function onRequest(context) {
         if (userName.indexOf("/") > -1) {
             userStore = userName.substr(0, userName.indexOf('/'));
         }
+        page["userStore"] = userStore;
+
         var response = userModule.getUser(userName);
 
         if (response["status"] == "success") {
@@ -41,28 +45,27 @@ function onRequest(context) {
         }
 
         response = userModule.getRolesByUsername(userName);
+        var rolesByUsername;
         if (response["status"] == "success") {
-            page["usersRoles"] = response["content"];
+            rolesByUsername = response["content"];
         }
+
         response = userModule.getRolesByUserStore(userStore);
+        var rolesByUserStore;
         if (response["status"] == "success") {
-            var roleVals = response["content"];
+            rolesByUserStore = response["content"];
-            var filteredRoles = [];
-            var prefix  = "Application";
-            for (i = 0; i < roleVals.length; i++) {
-                if(roleVals[i].indexOf(prefix) < 0){
-                    filteredRoles.push(roleVals[i]);
-                }
-            }
-            page["userRoles"] = filteredRoles;
         }
 
+        page["rolesByUsername"] = rolesByUsername;
+        page["rolesByUserStore"] = rolesByUserStore;
     }
-    page["usernameJSRegEx"] = devicemgtProps.userValidationConfig.usernameJSRegEx;
+
-    page["usernameRegExViolationErrorMsg"] = devicemgtProps.userValidationConfig.usernameRegExViolationErrorMsg;
+    page["usernameJSRegEx"] = devicemgtProps["userValidationConfig"]["usernameJSRegEx"];
-    page["firstnameJSRegEx"] = devicemgtProps.userValidationConfig.firstnameJSRegEx;
+    page["usernameRegExViolationErrorMsg"] = devicemgtProps["userValidationConfig"]["usernameRegExViolationErrorMsg"];
-    page["firstnameRegExViolationErrorMsg"] = devicemgtProps.userValidationConfig.firstnameRegExViolationErrorMsg;
+    page["firstnameJSRegEx"] = devicemgtProps["userValidationConfig"]["firstnameJSRegEx"];
-    page["lastnameJSRegEx"] = devicemgtProps.userValidationConfig.lastnameJSRegEx;
+    page["firstnameRegExViolationErrorMsg"] = devicemgtProps["userValidationConfig"]["firstnameRegExViolationErrorMsg"];
-    page["lastnameRegExViolationErrorMsg"] = devicemgtProps.userValidationConfig.lastnameRegExViolationErrorMsg;
+    page["lastnameJSRegEx"] = devicemgtProps["userValidationConfig"]["lastnameJSRegEx"];
+    page["lastnameRegExViolationErrorMsg"] = devicemgtProps["userValidationConfig"]["lastnameRegExViolationErrorMsg"];
+
     return page;
 }

components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.user.edit/edit.json

@@ -1,5 +1,5 @@
 {
     "version": "1.0.0",
-  "uri": "/user/edit",
+    "uri": "/user/edit",
     "layout": "cdmf.layout.default"
 }

components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.user.edit/public/js/bottomJs.js

@@ -32,6 +32,8 @@ function inputIsValid(regExp, inputString) {
 var validateInline = {};
 var clearInline = {};
 
+var deviceMgtBasePath = "/api/device-mgt/v1.0";
+
 var enableInlineError = function (inputField, errorMsg, errorSign) {
     var fieldIdentifier = "#" + inputField;
     var errorMsgIdentifier = "#" + inputField + " ." + errorMsg;
@@ -180,7 +182,8 @@ $(document).ready(function () {
         var usernameInput = $("input#username");
         var firstnameInput = $("input#firstname");
         var lastnameInput = $("input#lastname");
-        var charLimit = parseInt($("input#username").attr("limit"));
+        // var charLimit = parseInt($("input#username").attr("limit"));
+        var domain = $("#userStore").val();
         var username = usernameInput.val().trim();
         var firstname = firstnameInput.val();
         var lastname = lastnameInput.val();
@@ -215,7 +218,7 @@ $(document).ready(function () {
         } else {
             var addUserFormData = {};
 
-            addUserFormData.username = username;
+            addUserFormData.username = domain + "/" + username;
             addUserFormData.firstname = firstname;
             addUserFormData.lastname = lastname;
             addUserFormData.emailAddress = emailAddress;
@@ -225,14 +228,13 @@ $(document).ready(function () {
             }
             addUserFormData.roles = roles;
 
-            var addUserAPI = "/devicemgt_admin/users?username=" + username;
+            var addUserAPI = deviceMgtBasePath + "/users/" + username;
 
             invokerUtil.put(
                 addUserAPI,
                 addUserFormData,
-                function (data) {
+                function (data, textStatus, jqXHR) {
-                    data = JSON.parse(data);
+                    if (jqXHR.status == 201) {
-                    if (data["statusCode"] == 201) {
                         // Clearing user input fields.
                         $("input#username").val("");
                         $("input#firstname").val("");
@@ -243,13 +245,14 @@ $(document).ready(function () {
                         $("#user-create-form").addClass("hidden");
                         $("#user-created-msg").removeClass("hidden");
                     }
-                }, function (data) {
+                }, function (jqXHR) {
-                        if (data["statusCode"] == 409) {
+                    var payload = JSON.parse(jqXHR.responseText);
+                    if (jqXHR.status == 409) {
                         $(errorMsg).text("User : " + username + " doesn't exists. You cannot proceed.");
-                        } else if (data["statusCode"] == 500) {
+                    } else if (jqXHR.status == 500) {
-                        $(errorMsg).text("An unexpected error occurred @ backend server. Please try again later.");
+                        $(errorMsg).text("An unexpected error occurred at backend server. Please try again later.");
                     } else {
-                        $(errorMsg).text(data.errorMessage);
+                        $(errorMsg).text(payload.message);
                     }
                     $(errorMsgWrapper).removeClass("hidden");
                 }

components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.users/public/js/listing.js

@@ -16,6 +16,18 @@
  * under the License.
  */
 
+/**
+ * Checks if provided input is valid against RegEx input.
+ *
+ * @param regExp Regular expression
+ * @param inputString Input string to check
+ * @returns {boolean} Returns true if input matches RegEx
+ */
+function inputIsValid(regExp, inputString) {
+    regExp = new RegExp(regExp);
+    return regExp.test(inputString);
+}
+
 $(function () {
     var sortableElem = '.wr-sortable';
     $(sortableElem).sortable({
@@ -116,9 +128,8 @@ $("a.invite-user-link").click(function () {
  * when a user clicks on "Remove" link
  * on User Listing page in WSO2 MDM Console.
  */
-function removeUser(uname, uid) {
+function removeUser(uname) {
     var username = uname;
-    var userid = uid;
     var removeUserAPI = apiBasePath + "/users/" + username;
     $(modalPopupContent).html($('#remove-user-modal-content').html());
     showPopup();
@@ -127,7 +138,7 @@ function removeUser(uname, uid) {
         invokerUtil.delete(
             removeUserAPI,
             function () {
-                $("#" + userid).remove();
+                $("#role-" + username).remove();
                 // get new user-list-count
                 var newUserListCount = $(".user-list > span").length;
                 // update user-listing-status-msg with new user-count
@@ -264,12 +275,12 @@ function loadUsers(searchParam) {
         };
 
         return JSON.stringify( json );
-    };
+    }
 
     var fnCreatedRow = function( nRow, aData, iDataIndex ) {
         $(nRow).attr('data-type', 'selectable');
         $(nRow).attr('data-username', aData["filter"]);
-    };
+    }
 
     var columns = [
         {
@@ -302,19 +313,19 @@ function loadUsers(searchParam) {
             class: "text-right content-fill text-left-on-grid-view no-wrap",
             data: null,
             render: function ( data, type, row, meta ) {
-                return '<a href="/emm/users/edit-user?username=' + data.username + '" data-username="' + data.username +
+                return '<a href="/emm/user/edit?username=' + data.filter + '" data-username="' + data.filter +
                     '" data-click-event="edit-form" class="btn padding-reduce-on-grid-view edit-user-link"> ' +
                     '<span class="fw-stack"> <i class="fw fw-ring fw-stack-2x"></i> <i class="fw fw-edit fw-stack-1x"></i>' +
                     ' </span> <span class="hidden-xs hidden-on-grid-view">Edit</span> </a>' +
 
-                    '<a href="#" data-username="' + data.username + '" data-userid=' + data.username +
+                    '<a href="#" data-username="' + data.filter + '" data-userid=' + data.filter +
-                    ' data-click-event="remove-form" onclick="javascript:removeUser(\'' + data.username + '\', \'' +
+                    ' data-click-event="remove-form" onclick="javascript:removeUser(\'' + data.filter + '\')" ' +
-                    data.username + '\')" class="btn padding-reduce-on-grid-view remove-user-link">' +
+                    'class="btn padding-reduce-on-grid-view remove-user-link">' +
                     '<span class="fw-stack"> <i class="fw fw-ring fw-stack-2x"></i> <i class="fw fw-delete fw-stack-1x">' +
                     '</i> </span> <span class="hidden-xs hidden-on-grid-view">Remove</span> </a>' +
 
-                    '<a href="#" data-username="' + data.username + '" data-userid="' + data.username +
+                    '<a href="#" data-username="' + data.filter + '" data-userid="' + data.filter +
-                    '" data-click-event="edit-form" onclick="javascript:resetPassword(\'' + data.username +
+                    '" data-click-event="edit-form" onclick="javascript:resetPassword(\'' + data.filter +
                     '\')" class="btn padding-reduce-on-grid-view remove-user-link"> <span class="fw-stack"> <i class="fw fw-ring fw-stack-2x">' +
                     '</i> <i class="fw fw-key fw-stack-1x"></i> <span class="fw-stack fw-move-right fw-move-bottom"> <i class="fw fw-circle fw-stack-2x fw-stroke fw-inverse"><' +
                     '/i> <i class="fw fw-circle fw-stack-2x"></i> <i class="fw fw-refresh fw-stack-1x fw-inverse">' +