Merge pull request #326 from charithag/master

Removed url from application uninstall

components/mobile-plugins/android-plugin/org.wso2.carbon.device.mgt.mobile.android.api/src/main/java/org/wso2/carbon/mdm/services/android/bean/ApplicationUninstallation.java

@@ -43,9 +43,6 @@ public class ApplicationUninstallation extends AndroidOperation implements Seria
     @Pattern(regexp = "^[A-Za-z]*$")
     private String type;
 
-    @ApiModelProperty(name = "url", value = "The URL of the application.", required = true)
-    private String url;
-
     @ApiModelProperty(name = "name", value = "The name of the application.", required = true)
     @Size(min = 2, max = 45)
     private String name;
@@ -66,14 +63,6 @@ public class ApplicationUninstallation extends AndroidOperation implements Seria
         this.type = type;
     }
 
-    public String getUrl() {
-        return url;
-    }
-
-    public void setUrl(String url) {
-        this.url = url;
-    }
-
     public String getName() {
         return name;
     }

components/mobile-plugins/android-plugin/org.wso2.carbon.device.mgt.mobile.android.api/src/main/java/org/wso2/carbon/mdm/services/android/services/impl/DeviceManagementAdminServiceImpl.java

@@ -558,22 +558,7 @@ public class DeviceManagementAdminServiceImpl implements DeviceManagementAdminSe
                     throw new BadRequestException(
                             new ErrorResponse.ErrorResponseBuilder().setCode(400l).setMessage(errorMessage).build());
                 }
-                if (payload.has("type")) {
+                validateType(payload);
-                    String type = payload.getString("type");
-                    if (!"enterprise".equalsIgnoreCase(type)
-                        && !"public".equalsIgnoreCase(type)
-                        && !"webapp".equalsIgnoreCase(type)) {
-                        String errorMessage = "Invalid application type.";
-                        log.error(errorMessage);
-                        throw new BadRequestException(
-                                new ErrorResponse.ErrorResponseBuilder().setCode(400l).setMessage(errorMessage).build());
-                    }
-                } else {
-                    String errorMessage = "Application type is missing.";
-                    log.error(errorMessage);
-                    throw new BadRequestException(
-                            new ErrorResponse.ErrorResponseBuilder().setCode(400l).setMessage(errorMessage).build());
-                }
             } catch (MalformedURLException e) {
                 String errorMessage = "Malformed application url.";
                 log.error(errorMessage);
@@ -673,6 +658,9 @@ public class DeviceManagementAdminServiceImpl implements DeviceManagementAdminSe
                         new ErrorResponse.ErrorResponseBuilder().setCode(400l).setMessage(errorMessage).build());
             }
             ApplicationUninstallation applicationUninstallation = applicationUninstallationBeanWrapper.getOperation();
+            JSONObject payload = new JSONObject(applicationUninstallation.toJSON());
+            validateType(payload);
+
             ProfileOperation operation = new ProfileOperation();
             operation.setCode(AndroidConstants.OperationCodes.UNINSTALL_APPLICATION);
             operation.setType(Operation.Type.PROFILE);
@@ -698,6 +686,25 @@ public class DeviceManagementAdminServiceImpl implements DeviceManagementAdminSe
         }
     }
 
+    private void validateType(JSONObject payload) {
+        if (payload.has("type")) {
+            String type = payload.getString("type");
+            if (!"enterprise".equalsIgnoreCase(type)
+                && !"public".equalsIgnoreCase(type)
+                && !"webapp".equalsIgnoreCase(type)) {
+                String errorMessage = "Invalid application type.";
+                log.error(errorMessage);
+                throw new BadRequestException(
+                        new ErrorResponse.ErrorResponseBuilder().setCode(400l).setMessage(errorMessage).build());
+            }
+        } else {
+            String errorMessage = "Application type is missing.";
+            log.error(errorMessage);
+            throw new BadRequestException(
+                    new ErrorResponse.ErrorResponseBuilder().setCode(400l).setMessage(errorMessage).build());
+        }
+    }
+
     @POST
     @Path("/blacklist-applications")
     @Override