Added capability to filter apps with system installed apps or user installed apps #539

Open
ruwin wants to merge 3 commits from ruwin/device-mgt-core:classify-apps into master
ruwin commented 3 weeks ago

Purpose

Description

This pull request addresses an improvement to filter apps based on user installed apps and system installed apps.

## Purpose * Fixed https://roadmap.entgra.net/issues/11291 ## Description This pull request addresses an improvement to filter apps based on user installed apps and system installed apps.
ruwin added 2 commits 3 weeks ago
ab87a8199a
Add capability to filter apps by system installed apps or user installed apps
navodzoysa requested changes 1 week ago
byte[] appProperties = rs.getBytes("APP_PROPERTIES");
bais = new ByteArrayInputStream(appProperties);
ois = new ObjectInputStream(bais);
Collaborator

It is better to use try with resources when using ByteArrayInputStream and ObjectInputStream.

It is better to use try with resources when using ByteArrayInputStream and ObjectInputStream.
ruwin marked this conversation as resolved
} catch (ClassNotFoundException e) {
throw new DeviceManagementDAOException("Class not found error occurred fetch at app properties", e);
} catch (SQLException e) {
throw new DeviceManagementDAOException("SQL error occurred fetch at application", e);
Collaborator

Log the exceptions before throwing

Log the exceptions before throwing
ruwin marked this conversation as resolved
stmt.setInt(3, tenantId);
stmt.setInt(4, limit);
stmt.setInt(5, offset);
int paramIndex = 4;
Collaborator

Isn't it more elegant to use this paramIndex starting from the 1st index instead of from here.

Isn't it more elegant to use this paramIndex starting from the 1st index instead of from here.
ruwin marked this conversation as resolved
ruwin added 1 commit 1 week ago
navodzoysa approved these changes 1 week ago

Reviewers

navodzoysa approved these changes 1 week ago
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: community/device-mgt-core#539
Loading…
There is no content yet.