community
/
device-mgt-core
12
0
Fork 43
Code Issues Pull Requests 20 Packages Projects Releases Wiki Activity
Labels Milestones

Add improvements for api publishing procedure #488

Merged
tcdlpds merged 3 commits from rajitha/device-mgt-core:improvements-for-api-publishing-flow into apim420 1 month ago
Conversation 0 Commits 3 Files Changed 4
rajitha commented 1 month ago
Collaborator
There is no content yet.
rajitha added 1 commit 1 month ago
rajitha added 1 commit 1 month ago
rajitha force-pushed improvements-for-api-publishing-flow from 30976748b5 to bfcc6dab1b 1 month ago
rajitha force-pushed improvements-for-api-publishing-flow from bfcc6dab1b to c6f65d9675 1 month ago
tcdlpds requested changes 1 month ago
components/apimgt-extensions/io.entgra.device.mgt.core.apimgt.webapp.publisher/src/main/java/io/entgra/device/mgt/core/apimgt/webapp/publisher/APIPublisherStartupHandler.java Outdated
error.append("']");
log.error(error.toString());
Stack<APIConfig> failedApis;
if (!APIPublisherDataHolder.getInstance().getUnpublishedApis().isEmpty()) {
tcdlpds commented 1 month ago
Owner

replace with "!currentAPIsStack.isEmpty()"

replace with "!currentAPIsStack.isEmpty()"
rajitha marked this conversation as resolved
components/apimgt-extensions/io.entgra.device.mgt.core.apimgt.webapp.publisher/src/main/java/io/entgra/device/mgt/core/apimgt/webapp/publisher/APIPublisherStartupHandler.java Outdated
log.info("Starting API publishing procedure");
}
private void publishAPIs(Stack<APIConfig> apis, Stack<APIConfig> failedStack) {
tcdlpds commented 1 month ago
Owner

Add Java Doc comment

Add Java Doc comment
rajitha marked this conversation as resolved
rajitha added 1 commit 1 month ago
tcdlpds merged commit 4660b59c97 into apim420 1 month ago

Reviewers

tcdlpds requested changes 1 month ago
The pull request has been merged as 4660b59c97.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
tcdlpds
Labels
Apply labels
Clear labels
pending upstream
PR depends on pending upstream dependency
No Label pending upstream
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: community/device-mgt-core#488
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'rajitha/device-mgt-core:improvements-for-api-publishing-flow'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes