Improve tenant deleting logic #481

Merged
tcdlpds merged 1 commits from tcdlpds/device-mgt-core:apim420 into apim420 2 months ago
Owner
There is no content yet.
tcdlpds force-pushed apim420 from c4901bf1d3 to e1594c00f1 2 months ago
rajitha approved these changes 2 months ago
/**
* Delete all application related data of a tenant by tenant Domain
Collaborator

Comments should be corrected as tenant id in the places where it previously mentioned as tenant domain

Comments should be corrected as tenant id in the places where it previously mentioned as tenant domain
tcdlpds marked this conversation as resolved
* @throws ApplicationManagementException thrown if an error occurs when deleting data
*/
void deleteApplicationDataByTenantDomain(String tenantDomain) throws ApplicationManagementException;
void deleteApplicationDataByTenantDomain(int tenantId) throws ApplicationManagementException;
Collaborator

Method name should be corrected as deleteApplicationDataByTenantId

Method name should be corrected as `deleteApplicationDataByTenantId`
tcdlpds marked this conversation as resolved
* @throws ApplicationManagementException thrown if an error occurs when deleting app folders
*/
void deleteApplicationArtifactsByTenantDomain(String tenantDomain) throws ApplicationManagementException;
void deleteApplicationArtifactsByTenantDomain(int tenantId) throws ApplicationManagementException;
Collaborator

Method name should be corrected as deleteApplicationArtifactsByTenantId

Method name should be corrected as `deleteApplicationArtifactsByTenantId`
tcdlpds marked this conversation as resolved
} catch (DBConnectionException e) {
String msg = "Error occurred while observing the database connection to delete applications for tenant with " +
"domain: " + tenantDomain;
"tenant ID: " + tenantId;
Collaborator

Message should be corrected with tenantId instead of domain.

Message should be corrected with `tenantId` instead of domain.
tcdlpds marked this conversation as resolved
tcdlpds merged commit 289f6ef352 into apim420 2 months ago

Reviewers

rajitha approved these changes 2 months ago
The pull request has been merged as 289f6ef352.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: community/device-mgt-core#481
Loading…
There is no content yet.