community
/
device-mgt-core
12
0
Fork 47
Code Issues Pull Requests 27 Packages Projects Releases Wiki Activity
Labels Milestones

Fix usage generation in billing #477

Merged
tcdlpds merged 5 commits from osh.silva/device-mgt-core:usage-11591 into master 2 months ago
Conversation 0 Commits 5 Files Changed 2
osh.silva commented 4 months ago
Collaborator

fixes https://roadmap.entgra.net/issues/11591

fixes https://roadmap.entgra.net/issues/11591
osh.silva added 2 commits 4 months ago
tcdlpds requested changes 4 months ago
components/device-mgt/io.entgra.device.mgt.core.device.mgt.core/src/main/java/io/entgra/device/mgt/core/device/mgt/core/service/DeviceManagementProviderServiceImpl.java Outdated
String msg = "Error occurred while opening a connection to the data source";
log.info(msg, e);
throw new DeviceManagementException(msg, e);
} finally {
tcdlpds commented 4 months ago
Owner

What's the reason for this?

What's the reason for this?
osh.silva marked this conversation as resolved
osh.silva added 1 commit 4 months ago
tcdlpds requested changes 4 months ago
components/device-mgt/io.entgra.device.mgt.core.device.mgt.core/src/main/java/io/entgra/device/mgt/core/device/mgt/core/service/DeviceManagementProviderServiceImpl.java Outdated
} catch (SQLException e) {
String msg = "Error occurred while opening a connection to the data source";
log.info(msg, e);
throw new DeviceManagementException(msg, e);
tcdlpds commented 4 months ago
Owner

Shouldn't we close the connection ?

Shouldn't we close the connection ?
osh.silva commented 3 months ago
Poster
Collaborator

This method is used inside another method where the connection is closed. If we close the connection in this method, the subsequent SQL queries will not execute because the connection will no longer be available.

This method is used inside another method where the connection is closed. If we close the connection in this method, the subsequent SQL queries will not execute because the connection will no longer be available.
tcdlpds commented 3 months ago
Owner

If that is the case, do we need to open the connection here?

In other words, can't we remove "DeviceManagementDAOFactory.getConnection();" line?

If that is the case, do we need to open the connection here? In other words, can't we remove "DeviceManagementDAOFactory.getConnection();" line?
osh.silva commented 2 months ago
Poster
Collaborator

yes this can be removed

yes this can be removed
osh.silva marked this conversation as resolved
osh.silva added 2 commits 2 months ago
tcdlpds merged commit b40c5a625d into master 2 months ago

Reviewers

tcdlpds requested changes 4 months ago
The pull request has been merged as b40c5a625d.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
tcdlpds
Labels
Apply labels
Clear labels
pending upstream
PR depends on pending upstream dependency
No Label pending upstream
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: community/device-mgt-core#477
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'osh.silva/device-mgt-core:usage-11591'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes