community
/
device-mgt-core
12
0
Fork 47
Code Issues Pull Requests 27 Packages Projects Releases Wiki Activity
Labels Milestones

Fix Search is not working in installation details in app store #451

Merged
tcdlpds merged 3 commits from nipuni/device-mgt-core:#11464 into master 4 months ago
Conversation 0 Commits 3 Files Changed 14
nipuni commented 4 months ago

Fixes for: http://roadmap.entgra.net/issues/11464

Fixes for: http://roadmap.entgra.net/issues/11464
nipuni added 2 commits 4 months ago
f0fafde0d2 Merge branch 'master' of https://repository.entgra.net/community/device-mgt-core into #11464
nipuni added 1 commit 4 months ago
nipuni changed title from WIP: Fix Search is not working in installation details in app store to Fix Search is not working in installation details in app store 4 months ago
rajitha requested changes 4 months ago
components/application-mgt/io.entgra.device.mgt.core.application.mgt.common/src/main/java/io/entgra/device/mgt/core/application/mgt/common/CategorizedSubscriptionResult.java
case "SUBSCRIBED":
this.subscribedDevices = devices;
break;
}
rajitha commented 4 months ago
Collaborator

What is the default case here?

What is the default case here?
components/application-mgt/io.entgra.device.mgt.core.application.mgt.core/src/main/java/io/entgra/device/mgt/core/application/mgt/core/impl/SubscriptionManagerImpl.java
if (subscribedDevices.isEmpty()) {
categorizedSubscriptionResult =
new CategorizedSubscriptionResult(installedDevices, pendingDevices, errorDevices, newDevices);
List<DeviceSubscriptionData> requestedDevices = new ArrayList<>();
rajitha commented 4 months ago
Collaborator

Move instantiate to the default case.

Move instantiate to the default case.
components/application-mgt/io.entgra.device.mgt.core.application.mgt.core/src/main/java/io/entgra/device/mgt/core/application/mgt/core/impl/SubscriptionManagerImpl.java
if (subscribedDevices.isEmpty()) {
categorizedSubscriptionResult =
new CategorizedSubscriptionResult(installedDevices, pendingDevices, errorDevices, newDevices);
List<DeviceSubscriptionData> requestedDevices = new ArrayList<>();
rajitha commented 4 months ago
Collaborator

Move instantiate to the default case.

Move instantiate to the default case.
components/application-mgt/io.entgra.device.mgt.core.application.mgt.core/src/main/java/io/entgra/device/mgt/core/application/mgt/core/impl/SubscriptionManagerImpl.java
if (subscribedDevices.isEmpty()) {
categorizedSubscriptionResult =
new CategorizedSubscriptionResult(installedDevices, pendingDevices, errorDevices, newDevices);
List<DeviceSubscriptionData> requestedDevices = new ArrayList<>();
rajitha commented 4 months ago
Collaborator

Move instantiate to the default case (Doing so we can reduce the life time of empty array instance through out the switch statement).

Move instantiate to the default case (Doing so we can reduce the life time of empty array instance through out the switch statement).
components/application-mgt/io.entgra.device.mgt.core.application.mgt.core/src/main/java/io/entgra/device/mgt/core/application/mgt/core/impl/SubscriptionManagerImpl.java
if (subscribedDevices.isEmpty()) {
categorizedSubscriptionResult =
new CategorizedSubscriptionResult(installedDevices, pendingDevices, errorDevices, newDevices);
List<DeviceSubscriptionData> requestedDevices = new ArrayList<>();
rajitha commented 4 months ago
Collaborator

Move instantiate to the default case.

Move instantiate to the default case.
components/application-mgt/io.entgra.device.mgt.core.application.mgt.core/src/main/java/io/entgra/device/mgt/core/application/mgt/core/impl/SubscriptionManagerImpl.java
statusPercentages.put(entry.getKey(), Double.valueOf(formattedPercentage));
}
List<DeviceSubscriptionData> requestedDevices = new ArrayList<>();
rajitha commented 4 months ago
Collaborator

Move instantiate to the default case.

Move instantiate to the default case.
tcdlpds merged commit 08e9625373 into master 4 months ago

Reviewers

rajitha requested changes 4 months ago
The pull request has been merged as 08e9625373.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
rajitha
Labels
Apply labels
Clear labels
pending upstream
PR depends on pending upstream dependency
No Label pending upstream
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: community/device-mgt-core#451
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'nipuni/device-mgt-core:#11464'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes