community
/
device-mgt-core
12
0
Fork 47
Code Issues Pull Requests 27 Packages Projects Releases Wiki Activity
Labels Milestones

Fix web apps not installing via user, group, role issue #415

Merged
tcdlpds merged 1 commits from ashvini/device-mgt-core:Bug#10953 into master 5 months ago
Conversation 0 Commits 1 Files Changed 3
ashvini commented 5 months ago

Fix for : https://roadmap.entgra.net/issues/10953

Fix for : https://roadmap.entgra.net/issues/10953
ashvini force-pushed Bug#10953 from db9019c7b6 to 6546ecdde3 5 months ago
ashvini changed title from WIP: Fix web apps not installing via user, group, role issue to Fix web apps not installing via user, group, role issue 5 months ago
tcdlpds requested changes 5 months ago
components/device-mgt/io.entgra.device.mgt.core.device.mgt.common/src/main/java/io/entgra/device/mgt/core/device/mgt/common/app/mgt/windows/WebClipApplication.java Outdated
package io.entgra.device.mgt.core.device.mgt.common.app.mgt.windows;
tcdlpds commented 5 months ago
Owner

Add the license

Add the license
ashvini force-pushed Bug#10953 from 6546ecdde3 to f9b3183fa3 5 months ago
tcdlpds requested changes 5 months ago
components/device-mgt/io.entgra.device.mgt.core.device.mgt.common/src/main/java/io/entgra/device/mgt/core/device/mgt/common/MDMAppConstants.java Outdated
}
public static final String INSTALL_ENTERPRISE_APPLICATION = "INSTALL_ENTERPRISE_APPLICATION";
public static final String UNINSTALL_ENTERPRISE_APPLICATION = "UNINSTALL_ENTERPRISE_APPLICATION";
public static final String INSTALL_WEB_CLIP_APPLICATION = "WEB_CLIP";
tcdlpds commented 5 months ago
Owner

Can't we use single Constance here? Like 'WEB_CLIP_APPLICATION'

Can't we use single Constance here? Like 'WEB_CLIP_APPLICATION'
components/device-mgt/io.entgra.device.mgt.core.device.mgt.common/src/main/java/io/entgra/device/mgt/core/device/mgt/common/MDMAppConstants.java Outdated
public static final String APPX_CERTIFICATE_HASH = "Certificate_Hash";
public static final String APPX_ENCODED_CERT_CONTENT = "Encoded_Cert_Content";
public static final String APPX_PACKAGE_FAMILY_NAME = "Package_Family_Name";
tcdlpds commented 5 months ago
Owner

remove new line

remove new line
components/device-mgt/io.entgra.device.mgt.core.device.mgt.core/src/main/java/io/entgra/device/mgt/core/device/mgt/core/util/MDMAndroidOperationUtil.java Outdated
webApplication.setUrl(application.getLocation());
webApplication.setName(application.getName());
webApplication.setType(application.getType().toString());
webApplication.setType("webapp");
tcdlpds commented 5 months ago
Owner

What is the reason for having hard coded value here?

What is the reason for having hard coded value here?
ashvini commented 5 months ago
Poster

Some agent versions accept only "webapp" as the type. This is hard-coded in some other places as well.

Some agent versions accept only "webapp" as the type. This is hard-coded in some other places as well.
tcdlpds commented 5 months ago
Owner

I mean what's the value getting with the object? why it was required to hard code the value? Instead of hard coding you could have set the value properly and pass it to the method right?

IMO, if the required value is "webapp" then this is not the correct place to fix it.

I mean what's the value getting with the object? why it was required to hard code the value? Instead of hard coding you could have set the value properly and pass it to the method right? IMO, if the required value is "webapp" then this is not the correct place to fix it.
ashvini force-pushed Bug#10953 from f9b3183fa3 to 2545fddcdc 5 months ago
ashvini force-pushed Bug#10953 from 2545fddcdc to ea10eb1f3c 5 months ago
tcdlpds merged commit ae8834da0d into master 5 months ago

Reviewers

tcdlpds requested changes 5 months ago
The pull request has been merged as ae8834da0d.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
tcdlpds
Labels
Apply labels
Clear labels
pending upstream
PR depends on pending upstream dependency
No Label pending upstream
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: community/device-mgt-core#415
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'ashvini/device-mgt-core:Bug#10953'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes