community
/
device-mgt-core
12
0
Fork 43
Code Issues Pull Requests 20 Packages Projects Releases Wiki Activity
Labels Milestones

Add necessary improvements and configs for grafana version 10.3.3 #396

Merged
navodzoysa merged 5 commits from Sasini_Sandamali/device-mgt-core-forked:master into master 3 months ago
Conversation 0 Commits 5 Files Changed 7
Sasini_Sandamali commented 4 months ago
There is no content yet.
Sasini_Sandamali added 1 commit 4 months ago
Sasini_Sandamali added 1 commit 4 months ago
Sasini_Sandamali changed title from WIP: Add necessary improvements and configs for grafana version 10.3.3 to Add necessary improvements and configs for grafana version 10.3.3 4 months ago
Sasini_Sandamali added 1 commit 3 months ago
navodzoysa requested changes 3 months ago
components/analytics-mgt/grafana-mgt/io.entgra.device.mgt.core.analytics.mgt.grafana.proxy.api/src/main/java/io/entgra/device/mgt/core/analytics/mgt/grafana/proxy/api/impl/util/GrafanaRequestHandlerUtil.java Outdated
} catch (GrafanaManagementException e) {
String msg = "Error occurred while retrieving Grafana configuration";
log.error(msg, e);
throw e;
navodzoysa commented 3 months ago
Collaborator

I don't see the point of catching and rethrowing the same exception here. If we already have the exception in the method signature there is no need to catch it and rethrow.

This can be corrected in 2 ways either create a new exception type or handle the GrafanaManagementException from the caller method without catching here. IMO 2nd approach is ideal.

I don't see the point of catching and rethrowing the same exception here. If we already have the exception in the method signature there is no need to catch it and rethrow. This can be corrected in 2 ways either create a new exception type or handle the GrafanaManagementException from the caller method without catching here. IMO 2nd approach is ideal.
Sasini_Sandamali marked this conversation as resolved
Sasini_Sandamali added 1 commit 3 months ago
Sasini_Sandamali added 1 commit 3 months ago
navodzoysa approved these changes 3 months ago
navodzoysa merged commit 01d76c6dbd into master 3 months ago

Reviewers

navodzoysa approved these changes 3 months ago
The pull request has been merged as 01d76c6dbd.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
navodzoysa
Labels
Apply labels
Clear labels
pending upstream
PR depends on pending upstream dependency
No Label pending upstream
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: community/device-mgt-core#396
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'Sasini_Sandamali/device-mgt-core-forked:master'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes