fixed the validation issue #37

Merged

inosh merged 1 commits from ThilinaPremachandra/device-mgt-core:error-msg-device-status into master

ThilinaPremachandra commented

Purpose

fixes https://roadmap.entgra.net/issues/9678

Approach

The mentioned values were not validated and those values will validated now through a switch case. and the error message was updated.
and the enrolment information related to these values were not returned from the DAO layer and these values were added for that and now they are being returned.

ThilinaPremachandra added 1 commit

e4bc9f87f8 fixed the validation issue

tcdlpds requested changes

components/application-mgt/io.entgra.application.mgt.store.api/src/main/java/io/entgra/application/mgt/store/api/services/impl/util/RequestValidationUtil.java

													
					                case "REMOVED":

					                case "BLOCKED":

					                case "CREATED":

					                case "CONFIGURED":

tcdlpds commented

Owner

This is method duplication, this will not related to the issue that has been fixed. But IMO in a seperate effort it is better to improve this as well. Therefore create an issue for it.

tcdlpds approved these changes

ThilinaPremachandra closed this pull request

ThilinaPremachandra reopened this pull request

inosh referenced this issue from a commit

Merge pull request 'fixed the validation issue' (#37) from ThilinaPremachandra/device-mgt-core:error-msg-device-status into master

inosh merged commit 25d3428355 into master 2 years ago

Reviewers

tcdlpds approved these changes

The pull request has been merged as 25d3428355.

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: community/device-mgt-core#37