Added validation for app name length when creating an app

Conversation 0 Commits 9 Files Changed 2

ravindu commented

There is no content yet.

ravindu added 4 commits

5679beb80c Merge pull request 'master' (#1 ) from community/device-mgt-core:master into master

Reviewed-on: ravindu/device-mgt-core#1

ba3a1b09d8 Merge pull request 'added device-extensions, logger, default-role-manager, stateengine (#8 )' (#2 ) from community/device-mgt-core:master into master

Reviewed-on: ravindu/device-mgt-core#2

18f4a4c93c Merge pull request 'master' (#3 ) from community/device-mgt-core:master into master

Reviewed-on: ravindu/device-mgt-core#3

2f637cbc3f added validation for app name length when creating an app (Front end part)

tcdlpds requested changes

components/application-mgt/io.entgra.application.mgt.publisher.api/src/main/java/io/entgra/application/mgt/publisher/api/services/ApplicationManagementPublisherAPI.java Outdated

tcdlpds commented

Owner

What's the reason to use 411 error code to handle this case?

ravindu commented

Poster

Bit confused with the variable length and defined Content-Length header (it must be used when the server refuses to accept the request without a defined Content-Length header.). In here it must be bad request error code. I will correct it.

tcdlpds commented

Owner

Yes for this case you need to send Bad Request

tcdlpds marked this conversation as resolved

components/application-mgt/io.entgra.application.mgt.publisher.api/src/main/java/io/entgra/application/mgt/publisher/api/services/impl/ApplicationManagementPublisherAPIImpl.java Outdated

ravindu added 1 commit

2bc90b1746 fixed the issue with formatting

ravindu added 1 commit

86aef67613 fixed the issue with formatting

ravindu added 1 commit

1ec51c057b formating issue resolved

tcdlpds changed title from ~~Added validation for app name length when creating an app (backend part)~~ to Added validation for app name length when creating an app

ravindu added 1 commit

67660b478b Add app name length validation condition to the applicationManagmentimpl file

ravindu added 1 commit

fcba484ee4 Add app name length validation for all types of applications in ApplicationManagerImpl file

tcdlpds approved these changes

tcdlpds merged commit e28c71d4ae into master 2 years ago

Reviewers

tcdlpds approved these changes

The pull request has been merged as e28c71d4ae.

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: community/device-mgt-core#27

                     @ApiResponse(
                             code = 409,
                             message = "CONFLICT. \n Application exists"),
                     @ApiResponse(

                 log.error(msg);
                 return Response.status(Response.Status.BAD_REQUEST).build();
             }
             if(appName.length()>20){

Added validation for app name length when creating an app #27

Reviewers