community
/
device-mgt-core
12
0
Fork 47
Code Issues Pull Requests 27 Packages Projects Releases Wiki Activity
Labels Milestones

Fix delete groups with Geo Fence references issue #223

Merged
pahansith merged 1 commits from ThilinaPremachandra/device-mgt-core:Bug#10236#issue36 into master 1 year ago
Conversation 0 Commits 1 Files Changed 2
ThilinaPremachandra commented 1 year ago

Purpose

Fix: 36th issue in https://roadmap.entgra.net/issues/10236 (If a group was selected in a geofence, we can't delete that group.)

Approach

  • update delete query
  • fix test failures - add related db scripts to "test/resources/sql/h2.sql" file
**Purpose** Fix: 36th issue in https://roadmap.entgra.net/issues/10236 (If a group was selected in a geofence, we can't delete that group.) **Approach** * update delete query * fix test failures - add related db scripts to "test/resources/sql/h2.sql" file
ThilinaPremachandra added 1 commit 1 year ago
pahansith reviewed 1 year ago
components/device-mgt/io.entgra.device.mgt.core.device.mgt.core/src/main/java/io/entgra/device/mgt/core/device/mgt/core/dao/impl/AbstractGroupDAOImpl.java
stmt.setInt(1, groupId);
stmt.setInt(2, tenantId);
stmt.executeUpdate();
sql = "DELETE FROM DM_DEVICE_EVENT_GROUP_MAPPING WHERE GROUP_ID = ?";
pahansith commented 1 year ago
Owner

I'm seeing multiple delete queries in a single DAO method. What is the reason for adding this? What will happen if any of a delete fails?

I'm seeing multiple delete queries in a single DAO method. What is the reason for adding this? What will happen if any of a delete fails?
pahansith marked this conversation as resolved
pahansith merged commit 616c70face into master 1 year ago
The pull request has been merged as 616c70face.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
pending upstream
PR depends on pending upstream dependency
No Label pending upstream
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: community/device-mgt-core#223
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'ThilinaPremachandra/device-mgt-core:Bug#10236#issue36'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes