community
/
device-mgt-core
12
0
Fork 46
Code Issues Pull Requests 26 Packages Projects Releases Wiki Activity
Labels Milestones

Device names in endpoint-mgt and traccar are not consistent - Fix #21

Merged
pahansith merged 13 commits from deenath/device-mgt-core:master into master 2 years ago
Conversation 0 Commits 13 Files Changed 6
deenath commented 2 years ago

Fix: https://roadmap.entgra.net/issues/9656

When renaming an agent, the update wasn't send to the traccar server.
Added new methods and combined it with existing agent modification code

Fix: [https://roadmap.entgra.net/issues/9656](https://roadmap.entgra.net/issues/9656) When renaming an agent, the update wasn't send to the traccar server. Added new methods and combined it with existing agent modification code
deenath added 8 commits 2 years ago
shamalka1 reviewed 2 years ago
components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/traccar/api/service/impl/DeviceAPIClientServiceImpl.java Outdated
@Override
public void modifyDevice(Device device,int tenantId) throws ExecutionException,InterruptedException{
TraccarDevice traccarDevice = new TraccarDevice(device.getId(), device.getName(), device.getDeviceIdentifier(), null,null,null,null,null,null,null,null,null);
shamalka1 commented 2 years ago

Better to define a new constructor with only required parameters, or create a default constructor and set the required values to the object.

Better to define a new constructor with only required parameters, or create a default constructor and set the required values to the object.
deenath marked this conversation as resolved
deenath added 2 commits 2 years ago
deenath added 2 commits 2 years ago
pahansith added 1 commit 2 years ago
pahansith merged commit 7e914aeafd into master 2 years ago
The pull request has been merged as 7e914aeafd.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
pending upstream
PR depends on pending upstream dependency
No Label pending upstream
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: community/device-mgt-core#21
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'deenath/device-mgt-core:master'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes