Add a config to decide which device statuses to persist in the database #250

Merged
pahansith merged 13 commits from pramilaniroshan/device-mgt-core:rm-10378 into master 11 months ago
Collaborator
There is no content yet.
pramilaniroshan added 1 commit 1 year ago
pramilaniroshan added 1 commit 1 year ago
Poster
Collaborator
https://roadmap.entgra.net/issues/10378
pramilaniroshan added 1 commit 1 year ago
pramilaniroshan added 41 commits 1 year ago
c3cc4fe6d4
Add fix for search operation (#251)
9767f7e90f
Add validation for user deletion (#244)
pramilaniroshan changed title from WIP: Add a config to decide which device statuses to persist in the database to Add a config to decide which device statuses to persist in the database 1 year ago
pramilaniroshan added 1 commit 1 year ago
pramilaniroshan added 1 commit 1 year ago
pahansith requested changes 12 months ago
Response getDeviceStatusFilters( @ApiParam(
name = "deviceType",
value = "The device type.",
required = true) @QueryParam("device-type") String deviceType);
Owner

Better to change the deviceType to a path parameter.

Better to change the deviceType to a path parameter.
pramilaniroshan marked this conversation as resolved
Response getDeviceStatusCheck();
@PUT
@Path("/is-enabled")
Owner

Path /is-enabled seems not suitable for a POST API. Check the possibilities of changing this to a more related one.

Path /is-enabled seems not suitable for a POST API. Check the possibilities of changing this to a more related one.
pramilaniroshan marked this conversation as resolved
name = "deviceStatus",
value = "A list of device status values to update for the given device type.",
required = true)
@QueryParam("deviceStatus") List<String> deviceStatus);
Owner

Better to attach this statuses to the request body instead of sending them as query params

Better to attach this statuses to the request body instead of sending them as query params
pramilaniroshan marked this conversation as resolved
try {
DeviceStatusManagementService deviceManagementProviderService = DeviceMgtAPIUtils.getDeviceStatusManagmentService();
deviceManagementProviderService.updateDefaultDeviceStatusFilters(tenantId, deviceType, deviceStatus);
return Response.status(Response.Status.OK).entity("Successfully updated device status filters for" + deviceType).build();
Owner

Need to add a space to the message string after the last character ('r') for the clarity of the message.

Need to add a space to the message string after the last character ('r') for the clarity of the message.
pramilaniroshan marked this conversation as resolved
pramilaniroshan added 3 commits 12 months ago
pramilaniroshan added 1 commit 11 months ago
pramilaniroshan added 1 commit 11 months ago
pramilaniroshan added 1 commit 11 months ago
pahansith merged commit c2a9b6a073 into master 11 months ago

Reviewers

pahansith requested changes 12 months ago
The pull request has been merged as c2a9b6a073.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: community/device-mgt-core#250
Loading…
There is no content yet.