Add a config to decide which device statuses to persist in the database #250
Merged
pahansith
merged 13 commits from pramilaniroshan/device-mgt-core:rm-10378
into master
11 months ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'pramilaniroshan/device-mgt-core:rm-10378'
Deleting a branch is permanent. It CANNOT be undone. Continue?
https://roadmap.entgra.net/issues/10378
WIP: Add a config to decide which device statuses to persist in the databaseto Add a config to decide which device statuses to persist in the database 1 year agoResponse getDeviceStatusFilters( @ApiParam(
name = "deviceType",
value = "The device type.",
required = true) @QueryParam("device-type") String deviceType);
Better to change the deviceType to a path parameter.
Response getDeviceStatusCheck();
@PUT
@Path("/is-enabled")
Path /is-enabled seems not suitable for a POST API. Check the possibilities of changing this to a more related one.
name = "deviceStatus",
value = "A list of device status values to update for the given device type.",
required = true)
@QueryParam("deviceStatus") List<String> deviceStatus);
Better to attach this statuses to the request body instead of sending them as query params
try {
DeviceStatusManagementService deviceManagementProviderService = DeviceMgtAPIUtils.getDeviceStatusManagmentService();
deviceManagementProviderService.updateDefaultDeviceStatusFilters(tenantId, deviceType, deviceStatus);
return Response.status(Response.Status.OK).entity("Successfully updated device status filters for" + deviceType).build();
Need to add a space to the message string after the last character ('r') for the clarity of the message.
c2a9b6a073
into master 11 months agoReviewers
c2a9b6a073
.