community
/
device-mgt-core
12
0
Fork 47
Code Issues Pull Requests 26 Packages Projects Releases Wiki Activity
Labels Milestones

Add validation for user deletion #244

Merged
pahansith merged 3 commits from prathabanKavin/device-mgt-core:uservalidate into master 1 year ago
Conversation 0 Commits 3 Files Changed 2
prathabanKavin commented 1 year ago

Purpose

Description

  • Add validation to check whether the user has enrolled devices
## Purpose * Fixes https://roadmap.entgra.net/issues/10337 ## Description * Add validation to check whether the user has enrolled devices
prathabanKavin added 2 commits 1 year ago
pahansith requested changes 1 year ago
components/device-mgt/io.entgra.device.mgt.core.device.mgt.api/src/main/java/io/entgra/device/mgt/core/device/mgt/api/jaxrs/service/impl/UserManagementServiceImpl.java Outdated
username = domain + '/' + username;
}
try {
List<Device> deviceList;
pahansith commented 1 year ago
Owner

Remove the list and use an integer variable to check the size of the list

Remove the list and use an integer variable to check the size of the list
prathabanKavin marked this conversation as resolved
components/device-mgt/io.entgra.device.mgt.core.device.mgt.api/src/main/java/io/entgra/device/mgt/core/device/mgt/api/jaxrs/service/impl/UserManagementServiceImpl.java Outdated
userStoreManager.deleteUser(username);
if (log.isDebugEnabled()) {
log.debug("User '" + username + "' was successfully removed.");
if (domain != null && !domain.isEmpty()) {
pahansith commented 1 year ago
Owner

Same condition is checking twice. Handle it in an appropriate way

Same condition is checking twice. Handle it in an appropriate way
prathabanKavin marked this conversation as resolved
components/device-mgt/io.entgra.device.mgt.core.device.mgt.api/src/main/java/io/entgra/device/mgt/core/device/mgt/api/jaxrs/service/impl/UserManagementServiceImpl.java Outdated
} else {
String msg = "There are enrolled devices for username: " + username;
log.error(msg);
return Response.serverError().entity(
pahansith commented 1 year ago
Owner

Change the response to a Bad request

Change the response to a Bad request
prathabanKavin marked this conversation as resolved
prathabanKavin added 1 commit 1 year ago
pahansith merged commit 9767f7e90f into master 1 year ago

Reviewers

pahansith requested changes 1 year ago
The pull request has been merged as 9767f7e90f.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
pahansith
Labels
Apply labels
Clear labels
pending upstream
PR depends on pending upstream dependency
No Label pending upstream
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: community/device-mgt-core#244
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'prathabanKavin/device-mgt-core:uservalidate'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes