Charitha Goonetilleke charithag
1 Followers · 0 Following
  • Joined on
Repositories Packages Public Activity Starred Repositories
1
Loading Heatmap…

charithag commented on pull request community/device-mgt-core#536

Api application registration & token generation restructuring

Do not use wildcard imports here. Use exact package name.

3 weeks ago

charithag commented on pull request community/device-mgt-core#536

Api application registration & token generation restructuring

Add method comment specifying this method require FQUN and will extracts the tenant domain from FQUN. According to logic, if user name provided without a tenant domain, it will assign to super tenant. So developer has to be aware.

3 weeks ago

charithag commented on pull request community/device-mgt-core#536

Api application registration & token generation restructuring

Shouldn't this call APIG MGT host? In a clustered environment with a seperate APIG profile, the request will be sent to IoT Core according to this.

3 weeks ago

charithag commented on pull request community/device-mgt-core#536

Api application registration & token generation restructuring

Use synchronized blocks and appropriate singletons to safeguard critical paths of the flow. Make sure there will be no parallel executions of critical paths such as api application creations, update, token generation, renewal etc.

3 weeks ago

charithag commented on pull request community/device-mgt-core#536

Api application registration & token generation restructuring

Can't we cache the apiApplicationKey for future use?

3 weeks ago

charithag commented on pull request community/device-mgt-core#536

Api application registration & token generation restructuring

Can't we cache the apiApplicationKey for future use?

3 weeks ago

charithag commented on pull request community/device-mgt-core#536

Api application registration & token generation restructuring

I've seen this GsonMessageBodyHandler code duplicate over all the WARs. Can't we just have a common library with similar stuffs?

3 weeks ago

charithag commented on pull request community/device-mgt-core#536

Api application registration & token generation restructuring

Do not define constants for existing constants. Use constant provided by framework.

3 weeks ago

charithag commented on pull request community/device-mgt-core#536

Api application registration & token generation restructuring

This makes a serious security issue.

3 weeks ago

charithag commented on pull request community/device-mgt-core#536

Api application registration & token generation restructuring

This makes a serious security issue.

3 weeks ago

charithag pushed to master at charithag/device-mgt-core

  • 39e16c41f0 Merge branch 'master' of ssh://repository.entgra.net:222/community/device-mgt-core
  • 66c9c4f4e6 Fix Device statuses intermittently not saving issue
  • b2b4c5c676 Add scpeific instructions in java doc comment
  • 7f06804823 Fix client cert verification issue in sub tenants
  • 00633e34f5 Fix client cert verification issue in sub tenants
  • Compare 7 commits »

3 weeks ago

charithag pushed to feature/operation-template at thameera/product-iots-community

1 month ago

charithag commented on pull request community/device-mgt-core#530

Fix Device statuses intermitantly not saving issue

this can be further simplified to

1 month ago

charithag pushed to master at charithag/device-mgt-core

  • 1b32c3ddc9 Merge branch 'master' of ssh://repository.entgra.net:222/community/device-mgt-core
  • 09b9dd3ded Fix login issues in sub tenants
  • 3d872e3b72 Merge pull request 'Remove unused windows os updates scopes' (#535) from subodhinie/device-mgt-core:os_updates into master
  • 66f6982098 Merge pull request 'Fix missing commit by moving transaction commit after metadata update.' (#532) from nipuni/device-mgt-core:11963 into master
  • 0e82c9c304 Remove unused windows os updates scopes
  • Compare 7 commits »

1 month ago

charithag pushed to master at charithag/device-mgt-core

  • 6a0244d334 Merge branch 'master' of ssh://repository.entgra.net:222/community/device-mgt-core
  • a45820e845 Remove code quality check from PRs
  • 337f26446b Fix the validation issue when the APK file and screenshot names contain spaces
  • cba9f7ce08 Fix the validation issue when the APK file and screenshot names contain spaces
  • 0ac795903f Remove code quality check from PRs
  • Compare 5 commits »

1 month ago