Merge pull request #931 from Nirothipan/master

Fixes for [MDM-367] Proper "Error" message is not given when trying to invite a user without having the email transport properly configured. #504

components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/service/impl/UserManagementServiceImpl.java

@@ -562,7 +562,12 @@ public class UserManagementServiceImpl implements UserManagementService {
             }
         } catch (DeviceManagementException e) {
             String msg = "Error occurred while inviting user to enrol their device";
+            if (e.getMessage() != null && !e.getMessage().isEmpty()) {
+                msg = e.getMessage();
+            }
             log.error(msg, e);
+            return Response.serverError().entity(
+                    new ErrorResponse.ErrorResponseBuilder().setMessage(msg).build()).build();
         } catch (UserStoreException e) {
             String msg = "Error occurred while getting claim values to invite user";
             log.error(msg, e);

components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/service/DeviceManagementProviderServiceImpl.java

@@ -837,7 +837,7 @@ public class DeviceManagementProviderServiceImpl implements DeviceManagementProv
                             metaInfo.getRecipients()).build();
             DeviceManagementDataHolder.getInstance().getEmailSenderService().sendEmail(ctx);
         } catch (EmailSendingFailedException e) {
-            String msg = "Error occurred while sending user registration notification";
+            String msg = "Error occurred while sending user registration notification." + e.getMessage();
             log.error(msg, e);
             throw new DeviceManagementException(msg, e);
         } catch (Exception e) {

components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.users/public/js/listing.js

@@ -89,10 +89,11 @@ $("a#invite-user-link").click(function () {
                     modalDialog.hide();
                 });
             },
-            function () {
+            function (data) {
+                var msg = JSON.parse(data.responseText);
                 modalDialog.header('<span class="fw-stack"> <i class="fw fw-circle-outline fw-stack-2x"></i> <i class="fw ' +
                     'fw-error fw-stack-1x"></i> </span> Unexpected Error !');
-                modalDialog.content('An unexpected error occurred. Try again later.');
+                modalDialog.content(msg.message);
                 modalDialog.footer('<div class="buttons"><a href="#" id="invite-user-error-link" ' +
                     'class="btn-operations">Ok </a></div>');
                 $("a#invite-user-error-link").click(function () {

components/email-sender/org.wso2.carbon.email.sender.core/src/main/java/org/wso2/carbon/email/sender/core/service/EmailSenderServiceImpl.java

@@ -65,8 +65,13 @@ public class EmailSenderServiceImpl implements EmailSenderService {
         for (String recipient : emailCtx.getRecipients()) {
             ContentProviderInfo info = emailCtx.getContentProviderInfo();
             EmailData emailData;
+            String transportSenderName = "mailto";
             try {
                 emailData = contentProvider.getContent(info.getTemplate(), info.getParams());
+                if(EmailSenderDataHolder.getInstance().getConfigurationContextService()
+                        .getServerConfigContext().getAxisConfiguration().getTransportOut(transportSenderName) == null){
+                    throw new EmailSendingFailedException("Email transport is not configured.");
+                }
             } catch (ContentProcessingInterruptedException e) {
                 throw new EmailSendingFailedException("Error occurred while retrieving email content to be " +
                         "sent for recipient '" + recipient + "'", e);