From a625ccecf0d131c68de910b656cb3d64f9e69e83 Mon Sep 17 00:00:00 2001
From: charitha <charitha.ws@gmail.com>
Date: Thu, 22 Dec 2016 19:53:12 +0530
Subject: [PATCH] Fixed https://wso2.org/jira/browse/IOTS-342

---
 .../app/pages/cdmf.page.groups/groups.hbs         | 10 +++++-----
 .../app/pages/cdmf.page.groups/groups.js          |  2 --
 .../public/group-permissions.json                 | 15 ---------------
 .../pages/cdmf.page.groups/public/js/listing.js   |  2 +-
 4 files changed, 6 insertions(+), 23 deletions(-)
 delete mode 100644 components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.groups/public/group-permissions.json

diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.groups/groups.hbs b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.groups/groups.hbs
index 5aeca7d38c..5c6238282d 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.groups/groups.hbs
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.groups/groups.hbs
@@ -120,14 +120,14 @@
                             <h4>
                                 Select user roles to manage group sharing
                                 <br><br>
-                                <div style="max-height: 200px; overflow: scroll" id="rolesListing">
+                                <div style="max-height: 200px; overflow: auto" id="rolesListing">
                                 </div>
                             </h4>
                         </div>
                     </div>
                     <div class="modal-footer">
                         <div class="buttons">
-                            {{#if permissions.CREATE_GROUP_ROLES}}
+                            {{#if permissions.ADD_ROLE}}
                                 <a href="{{@app.context}}/role/add" class="btn-operations">
                                     New Role
                                 </a>
@@ -186,9 +186,9 @@
                     <div class="content">
                         <div class="row">
                             <div class="col-lg-5 col-md-6 col-centered">
-                                <h3>Group was successfully updated.</h3>
+                                <h3>Group successfully updated.</h3>
                                 <br />
-                                Do you need to Add / Remove users to the chosen roles?
+                                Do you want to manage users?
                                 <div class="buttons">
                                     <a href="{{@app.context}}/users" id="share-group-add-users-yes-link"
                                        class="btn-operations">
@@ -211,7 +211,7 @@
                             <div class="col-lg-5 col-md-6 col-centered">
                                 <h3>New Role was successfully created.</h3>
                                 <br />
-                                Do you need to Add / Remove users to the chosen roles?
+                                Do you need to Add / Remove users from the chosen roles?
                                 <div class="buttons">
                                     <a href="{{@app.context}}/users" id="share-group-add-users-yes-link"
                                        class="btn-operations">
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.groups/groups.js b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.groups/groups.js
index 0c04f9bb2d..532ce661c7 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.groups/groups.js
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.groups/groups.js
@@ -20,13 +20,11 @@ function onRequest(context) {
     var groupModule = require("/app/modules/business-controllers/group.js")["groupModule"];
     var userModule = require("/app/modules/business-controllers/user.js")["userModule"];
     var constants = require("/app/modules/constants.js");
-    var groupPermissions = require("/app/pages/cdmf.page.groups/public/group-permissions.json");
     var currentUser = session.get(constants.USER_SESSION_KEY);
     var page = {};
     if (currentUser) {
         page.permissions = userModule.getUIPermissions();
         page.permissions.list = stringify(page.permissions);
-        page.groupPermissions = groupPermissions.permissionList;
         page.currentUser = currentUser;
         var groupCount = groupModule.getGroupCount();
         if (groupCount > 0) {
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.groups/public/group-permissions.json b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.groups/public/group-permissions.json
deleted file mode 100644
index 92a8ccfd5d..0000000000
--- a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.groups/public/group-permissions.json
+++ /dev/null
@@ -1,15 +0,0 @@
-{
-    "permissionList":["device-mgt/admin/groups/view",
-        "device-mgt/groups/add",
-        "device-mgt/groups/devices/add",
-        "device-mgt/groups/devices/remove",
-        "device-mgt/groups/devices/view",
-        "device-mgt/groups/remove",
-        "device-mgt/groups/roles/create",
-        "device-mgt/groups/roles/view",
-        "device-mgt/groups/share",
-        "device-mgt/groups/update",
-        "device-mgt/groups/users/view",
-        "device-mgt/groups/view"
-    ]
-}
\ No newline at end of file
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.groups/public/js/listing.js b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.groups/public/js/listing.js
index 1d76f94977..4597a71297 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.groups/public/js/listing.js
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.groups/public/js/listing.js
@@ -96,7 +96,7 @@ function loadGroups() {
         serviceURL = "/api/device-mgt/v1.0/admin/groups";
     } else if ($.hasPermission("LIST_GROUPS")) {
         //Get authenticated users groups
-        serviceURL = "/api/device-mgt/v1.0/groups/user/" + currentUser;
+        serviceURL = "/api/device-mgt/v1.0/groups";
     } else {
         $("#loading-content").remove();
         $('#device-table').addClass('hidden');