diff --git a/components/apimgt-extensions/org.wso2.carbon.apimgt.webapp.publisher/src/main/java/org/wso2/carbon/apimgt/webapp/publisher/lifecycle/util/AnnotationProcessor.java b/components/apimgt-extensions/org.wso2.carbon.apimgt.webapp.publisher/src/main/java/org/wso2/carbon/apimgt/webapp/publisher/lifecycle/util/AnnotationProcessor.java index c967039259a..8c95252db89 100644 --- a/components/apimgt-extensions/org.wso2.carbon.apimgt.webapp.publisher/src/main/java/org/wso2/carbon/apimgt/webapp/publisher/lifecycle/util/AnnotationProcessor.java +++ b/components/apimgt-extensions/org.wso2.carbon.apimgt.webapp.publisher/src/main/java/org/wso2/carbon/apimgt/webapp/publisher/lifecycle/util/AnnotationProcessor.java @@ -27,7 +27,15 @@ import org.wso2.carbon.apimgt.webapp.publisher.config.APIResource; import org.wso2.carbon.apimgt.webapp.publisher.config.APIResourceConfiguration; import javax.servlet.ServletContext; -import javax.ws.rs.*; +import javax.ws.rs.Consumes; +import javax.ws.rs.DELETE; +import javax.ws.rs.GET; +import javax.ws.rs.HttpMethod; +import javax.ws.rs.OPTIONS; +import javax.ws.rs.POST; +import javax.ws.rs.PUT; +import javax.ws.rs.Path; +import javax.ws.rs.Produces; import java.io.File; import java.io.IOException; import java.lang.annotation.Annotation; diff --git a/components/apimgt-extensions/org.wso2.carbon.apimgt.webapp.publisher/src/main/java/org/wso2/carbon/apimgt/webapp/publisher/lifecycle/util/ExtendedFileProtocolIteratorFactory.java b/components/apimgt-extensions/org.wso2.carbon.apimgt.webapp.publisher/src/main/java/org/wso2/carbon/apimgt/webapp/publisher/lifecycle/util/ExtendedFileProtocolIteratorFactory.java index 3d5ad74087f..c073387016c 100644 --- a/components/apimgt-extensions/org.wso2.carbon.apimgt.webapp.publisher/src/main/java/org/wso2/carbon/apimgt/webapp/publisher/lifecycle/util/ExtendedFileProtocolIteratorFactory.java +++ b/components/apimgt-extensions/org.wso2.carbon.apimgt.webapp.publisher/src/main/java/org/wso2/carbon/apimgt/webapp/publisher/lifecycle/util/ExtendedFileProtocolIteratorFactory.java @@ -21,7 +21,7 @@ import java.io.File; import java.io.IOException; import java.net.URL; -class ExtendedFileProtocolIteratorFactory implements DirectoryIteratorFactory { +final class ExtendedFileProtocolIteratorFactory implements DirectoryIteratorFactory { private static final String ENCODING_SCHEME = "UTF-8"; diff --git a/components/certificate-mgt/org.wso2.carbon.certificate.mgt.core/src/main/java/org/wso2/carbon/certificate/mgt/core/impl/CertificateGenerator.java b/components/certificate-mgt/org.wso2.carbon.certificate.mgt.core/src/main/java/org/wso2/carbon/certificate/mgt/core/impl/CertificateGenerator.java index 8f47afc6881..f81539018bc 100755 --- a/components/certificate-mgt/org.wso2.carbon.certificate.mgt.core/src/main/java/org/wso2/carbon/certificate/mgt/core/impl/CertificateGenerator.java +++ b/components/certificate-mgt/org.wso2.carbon.certificate.mgt.core/src/main/java/org/wso2/carbon/certificate/mgt/core/impl/CertificateGenerator.java @@ -21,8 +21,6 @@ import org.apache.commons.codec.binary.Base64; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.bouncycastle.asn1.ASN1Encodable; -import org.bouncycastle.asn1.ASN1InputStream; -import org.bouncycastle.asn1.ASN1Primitive; import org.bouncycastle.asn1.pkcs.Attribute; import org.bouncycastle.asn1.pkcs.PKCSObjectIdentifiers; import org.bouncycastle.asn1.x500.RDN; @@ -65,13 +63,13 @@ import org.wso2.carbon.context.PrivilegedCarbonContext; import javax.security.auth.x500.X500Principal; import javax.xml.bind.DatatypeConverter; -import java.io.*; +import java.io.ByteArrayInputStream; +import java.io.IOException; +import java.io.InputStream; import java.math.BigInteger; import java.security.*; import java.security.cert.Certificate; import java.security.cert.*; -import java.security.spec.InvalidKeySpecException; -import java.security.spec.PKCS8EncodedKeySpec; import java.util.ArrayList; import java.util.Collection; import java.util.Date; diff --git a/components/device-mgt-extensions/org.wso2.carbon.device.mgt.extensions.push.notification.provider.gcm/pom.xml b/components/device-mgt-extensions/org.wso2.carbon.device.mgt.extensions.push.notification.provider.gcm/pom.xml index 48621fc0c89..4a5bd406601 100644 --- a/components/device-mgt-extensions/org.wso2.carbon.device.mgt.extensions.push.notification.provider.gcm/pom.xml +++ b/components/device-mgt-extensions/org.wso2.carbon.device.mgt.extensions.push.notification.provider.gcm/pom.xml @@ -115,6 +115,10 @@ + + org.apache.felix + maven-scr-plugin + org.apache.felix maven-bundle-plugin diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/beans/ApplicationWrapper.java b/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/beans/ApplicationWrapper.java index 1040045dde6..39d6de263e6 100644 --- a/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/beans/ApplicationWrapper.java +++ b/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/beans/ApplicationWrapper.java @@ -29,14 +29,29 @@ import java.util.List; "role or devices the application is associated with.") public class ApplicationWrapper { - @ApiModelProperty(name = "userNameList", value = "List of user names.", required = true) + @ApiModelProperty( + name = "userNameList", + value = "List of user names.", + required = true) private List userNameList; - @ApiModelProperty(name = "roleNameList", value = "List of role names.", required = true) + + @ApiModelProperty( + name = "roleNameList", + value = "List of role names.", + required = true) private List roleNameList; - @ApiModelProperty(name = "deviceIdentifiers", value = "List of device identifiers.", required = true, + + @ApiModelProperty( + name = "deviceIdentifiers", + value = "List of device identifiers.", + required = true, dataType = "List[org.wso2.carbon.device.mgt.common.DeviceIdentifier]") private List deviceIdentifiers; - @ApiModelProperty(name = "application", value = "Details of the mobile application.", required = true) + + @ApiModelProperty( + name = "application", + value = "Details of the mobile application.", + required = true) private MobileApp application; public MobileApp getApplication() { diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/beans/BasePaginatedResult.java b/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/beans/BasePaginatedResult.java index 422a3d30085..8d1c82d8d75 100644 --- a/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/beans/BasePaginatedResult.java +++ b/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/beans/BasePaginatedResult.java @@ -26,7 +26,9 @@ public class BasePaginatedResult { /** * Number of Resources returned. */ - @ApiModelProperty(value = "Number of total resources.", example = "2") + @ApiModelProperty( + value = "Number of total resources.", + example = "1") @JsonProperty("count") private int count; diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/beans/OldPasswordResetWrapper.java b/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/beans/OldPasswordResetWrapper.java index bef53c06b75..bbd8a3dcdf4 100644 --- a/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/beans/OldPasswordResetWrapper.java +++ b/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/beans/OldPasswordResetWrapper.java @@ -25,9 +25,12 @@ import io.swagger.annotations.ApiModelProperty; public class OldPasswordResetWrapper extends PasswordResetWrapper{ /* - Base64 encoded password - */ - @ApiModelProperty(name = "oldPassword", value = "Old password of the user.", required = true ) + Base64 encoded password + */ + @ApiModelProperty( + name = "oldPassword", + value = "Old password of the user.", + required = true ) private String oldPassword; public String getOldPassword() { diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/beans/PasswordResetWrapper.java b/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/beans/PasswordResetWrapper.java index f1e186835a1..ae288604663 100644 --- a/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/beans/PasswordResetWrapper.java +++ b/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/beans/PasswordResetWrapper.java @@ -27,8 +27,11 @@ public class PasswordResetWrapper { /* Base64 encoded password */ - @ApiModelProperty(name = "newPassword", value = "New password of the user.", required = true, - example = "JiM&100%pW") + @ApiModelProperty( + name = "newPassword", + value = "New password of the user.", + required = true, + example = "JiM&100%pW") private String newPassword; public String getNewPassword() { diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/beans/PolicyWrapper.java b/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/beans/PolicyWrapper.java index 1028a334be7..06e99cd74da 100644 --- a/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/beans/PolicyWrapper.java +++ b/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/beans/PolicyWrapper.java @@ -30,49 +30,71 @@ import java.util.List; + "Wrappers") public class PolicyWrapper { - @ApiModelProperty(name = "policyName", value = "The name of the policy", required = true) + @ApiModelProperty( + name = "policyName", + value = "The name of the policy", + required = true) @Size(max = 45) private String policyName; - @ApiModelProperty(name = "description", value = "Gives a description on the policy", required = true) + @ApiModelProperty( + name = "description", + value = "Gives a description on the policy", + required = true) @Size(max = 1000) private String description; - @ApiModelProperty(name = "compliance", value = "Provides the non-compliance rules. WSO2 EMM provides the" - + " following non-compliance rules:\n" + @ApiModelProperty( + name = "compliance", + value = "Provides the non-compliance rules. WSO2 EMM provides the following non-compliance rules:\n" + "Enforce - Forcefully enforce the policies on the devices\n" + "Warning - If the device does not adhere to the given policies a warning message will be sent\n" + "Monitor - If the device does not adhere to the given policies the server is notified of the " + "violation unknown to the user and the administrator can take the necessary actions with regard" - + " to the reported", required = true) + + " to the reported", + required = true) @Size(max = 100) private String compliance; - @ApiModelProperty(name = "ownershipType", value = "The policy ownership type. It can be any of the " - + "following values:\n" + @ApiModelProperty( + name = "ownershipType", + value = "The policy ownership type. It can be any of the following values:\n" + "ANY - The policy will be applied on the BYOD and COPE device types\n" + "BYOD (Bring Your Own Device) - The policy will only be applied on the BYOD device type\n" + "COPE (Corporate-Owned, Personally-Enabled) - The policy will only be applied on the COPE " - + "device type", required = true) + + "device type", + required = true) @Size(max = 45) private String ownershipType; - @ApiModelProperty(name = "active", value = "If the value is true it indicates that the policy is active. " - + "If the value is false it indicates that the policy is inactive", required = true) + @ApiModelProperty( + name = "active", + value = "If the value is true it indicates that the policy is active. If the value is false it " + + "indicates that the policy is inactive", + required = true) private boolean active; - @ApiModelProperty(name = "profile", value = "Contains the details of the profile that is included in the" - + " policy", required = true) + @ApiModelProperty( + name = "profile", + value = "Contains the details of the profile that is included in the policy", + required = true) private Profile profile; - @ApiModelProperty(name = "roles", value = "The roles to whom the policy is applied on", required = true) + @ApiModelProperty( + name = "roles", + value = "The roles to whom the policy is applied on", + required = true) private List roles; - @ApiModelProperty(name = "deviceIdentifiers", value = "Lists out the devices the policy is enforced on", + @ApiModelProperty( + name = "deviceIdentifiers", + value = "Lists out the devices the policy is enforced on", required = true) private List deviceIdentifiers; - @ApiModelProperty(name = "users", value = "Lists out the users on whose devices the policy is enforced", + @ApiModelProperty( + name = "users", + value = "Lists out the users on whose devices the policy is enforced", required = true) private List users; diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/config/permission/AnnotationProcessor.java b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/config/permission/AnnotationProcessor.java index 88849f2d22d..01532e259e0 100644 --- a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/config/permission/AnnotationProcessor.java +++ b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/config/permission/AnnotationProcessor.java @@ -27,7 +27,15 @@ import org.wso2.carbon.apimgt.api.model.Scope; import org.wso2.carbon.device.mgt.common.permission.mgt.Permission; import javax.servlet.ServletContext; -import javax.ws.rs.*; +import javax.ws.rs.Consumes; +import javax.ws.rs.DELETE; +import javax.ws.rs.GET; +import javax.ws.rs.HttpMethod; +import javax.ws.rs.OPTIONS; +import javax.ws.rs.POST; +import javax.ws.rs.PUT; +import javax.ws.rs.Path; +import javax.ws.rs.Produces; import java.io.File; import java.io.IOException; import java.lang.annotation.Annotation; @@ -332,7 +340,7 @@ public class AnnotationProcessor { * @param servletContext * @return null if cannot determin /WEB-INF/classes */ - public static URL findWebInfClassesPath(ServletContext servletContext) { + private static URL findWebInfClassesPath(ServletContext servletContext) { String path = servletContext.getRealPath("/WEB-INF/classes"); if (path == null) return null; File fp = new File(path); diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/DeviceManagementDAOFactory.java b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/DeviceManagementDAOFactory.java index 9ec776d2ef2..a949ee7f99f 100644 --- a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/DeviceManagementDAOFactory.java +++ b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/DeviceManagementDAOFactory.java @@ -26,7 +26,10 @@ import org.wso2.carbon.device.mgt.common.TransactionManagementException; import org.wso2.carbon.device.mgt.common.UnsupportedDatabaseEngineException; import org.wso2.carbon.device.mgt.core.config.datasource.DataSourceConfig; import org.wso2.carbon.device.mgt.core.config.datasource.JNDILookupDefinition; -import org.wso2.carbon.device.mgt.core.dao.impl.*; +import org.wso2.carbon.device.mgt.core.dao.impl.ApplicationDAOImpl; +import org.wso2.carbon.device.mgt.core.dao.impl.ApplicationMappingDAOImpl; +import org.wso2.carbon.device.mgt.core.dao.impl.DeviceTypeDAOImpl; +import org.wso2.carbon.device.mgt.core.dao.impl.EnrollmentDAOImpl; import org.wso2.carbon.device.mgt.core.dao.impl.device.GenericDeviceDAOImpl; import org.wso2.carbon.device.mgt.core.dao.impl.device.OracleDeviceDAOImpl; import org.wso2.carbon.device.mgt.core.dao.impl.device.PostgreSQLDeviceDAOImpl; @@ -34,8 +37,6 @@ import org.wso2.carbon.device.mgt.core.dao.impl.device.SQLServerDeviceDAOImpl; import org.wso2.carbon.device.mgt.core.dao.util.DeviceManagementDAOUtil; import org.wso2.carbon.device.mgt.core.device.details.mgt.dao.DeviceDetailsDAO; import org.wso2.carbon.device.mgt.core.device.details.mgt.dao.impl.DeviceDetailsDAOImpl; -import org.wso2.carbon.device.mgt.core.search.mgt.dao.SearchDAO; -import org.wso2.carbon.device.mgt.core.search.mgt.dao.impl.SearchDAOImpl; import javax.sql.DataSource; import java.sql.Connection; @@ -135,10 +136,6 @@ public class DeviceManagementDAOFactory { return new DeviceDetailsDAOImpl(); } - public static SearchDAO getSearchDAO() { - return new SearchDAOImpl(); - } - public static void init(DataSourceConfig config) { dataSource = resolveDataSource(config); try { diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/search/mgt/dao/SearchDAO.java b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/search/mgt/dao/SearchDAO.java deleted file mode 100644 index f40c074d8c7..00000000000 --- a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/search/mgt/dao/SearchDAO.java +++ /dev/null @@ -1,29 +0,0 @@ -/* - * Copyright (c) 2016, WSO2 Inc. (http://www.wso2.org) All Rights Reserved. - * - * WSO2 Inc. licenses this file to you under the Apache License, - * Version 2.0 (the "License"); you may not use this file except - * in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ - - -package org.wso2.carbon.device.mgt.core.search.mgt.dao; - - -public interface SearchDAO { - -// List searchDeviceDetailsTable(String query) throws SearchDAOException; -// -// List searchDevicePropertyTable(String query) throws SearchDAOException; - -} diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/search/mgt/dao/impl/SearchDAOImpl.java b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/search/mgt/dao/impl/SearchDAOImpl.java deleted file mode 100644 index 8d2c7056992..00000000000 --- a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/search/mgt/dao/impl/SearchDAOImpl.java +++ /dev/null @@ -1,238 +0,0 @@ -/* - * Copyright (c) 2016, WSO2 Inc. (http://www.wso2.org) All Rights Reserved. - * - * WSO2 Inc. licenses this file to you under the Apache License, - * Version 2.0 (the "License"); you may not use this file except - * in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ - - -package org.wso2.carbon.device.mgt.core.search.mgt.dao.impl; - -import org.wso2.carbon.device.mgt.core.search.mgt.dao.SearchDAO; - - -public class SearchDAOImpl implements SearchDAO { -// -// private static final Log log = LogFactory.getLog(SearchDAOImpl.class); -// -// @Override -// public List searchDeviceDetailsTable(String query) throws SearchDAOException { -// if (log.isDebugEnabled()) { -// log.debug("Query : " + query); -// } -// Connection conn; -// PreparedStatement stmt = null; -// ResultSet rs; -// List devices = new ArrayList<>(); -// Map devs = new HashMap<>(); -// try { -// conn = this.getConnection(); -// stmt = conn.prepareStatement(query); -// rs = stmt.executeQuery(); -// while (rs.next()) { -// if (!devs.containsKey(rs.getInt("ID"))) { -// Device device = new Device(); -// device.setId(rs.getInt("ID")); -// device.setDescription(rs.getString("DESCRIPTION")); -// device.setName("NAME"); -// device.setType(rs.getString("DEVICE_TYPE_NAME")); -// device.setDeviceIdentifier(rs.getString("DEVICE_IDENTIFICATION")); -// -// DeviceIdentifier identifier = new DeviceIdentifier(); -// identifier.setType(rs.getString("DEVICE_TYPE_NAME")); -// identifier.setId(rs.getString("DEVICE_IDENTIFICATION")); -// -// DeviceInfo deviceInfo = new DeviceInfo(); -// deviceInfo.setAvailableRAMMemory(rs.getDouble("AVAILABLE_RAM_MEMORY")); -// deviceInfo.setBatteryLevel(rs.getDouble("BATTERY_LEVEL")); -// deviceInfo.setConnectionType(rs.getString("CONNECTION_TYPE")); -// deviceInfo.setCpuUsage(rs.getDouble("CPU_USAGE")); -// deviceInfo.setDeviceModel(rs.getString("DEVICE_MODEL")); -// deviceInfo.setExternalAvailableMemory(rs.getDouble("EXTERNAL_AVAILABLE_MEMORY")); -// deviceInfo.setExternalTotalMemory(rs.getDouble("EXTERNAL_TOTAL_MEMORY")); -// deviceInfo.setInternalAvailableMemory(rs.getDouble("INTERNAL_AVAILABLE_MEMORY")); -// deviceInfo.setInternalTotalMemory(rs.getDouble("EXTERNAL_TOTAL_MEMORY")); -// deviceInfo.setOsVersion(rs.getString("OS_VERSION")); -// deviceInfo.setOsBuildDate(rs.getString("OS_BUILD_DATE")); -// deviceInfo.setPluggedIn(rs.getBoolean("PLUGGED_IN")); -// deviceInfo.setSsid(rs.getString("SSID")); -// deviceInfo.setTotalRAMMemory(rs.getDouble("TOTAL_RAM_MEMORY")); -// deviceInfo.setVendor(rs.getString("VENDOR")); -// deviceInfo.setUpdatedTime(new java.util.Date(rs.getLong("UPDATE_TIMESTAMP"))); -// -// DeviceLocation deviceLocation = new DeviceLocation(); -// deviceLocation.setLatitude(rs.getDouble("LATITUDE")); -// deviceLocation.setLongitude(rs.getDouble("LONGITUDE")); -// deviceLocation.setStreet1(rs.getString("STREET1")); -// deviceLocation.setStreet2(rs.getString("STREET2")); -// deviceLocation.setCity(rs.getString("CITY")); -// deviceLocation.setState(rs.getString("STATE")); -// deviceLocation.setZip(rs.getString("ZIP")); -// deviceLocation.setCountry(rs.getString("COUNTRY")); -// deviceLocation.setDeviceId(rs.getInt("ID")); -// deviceLocation.setUpdatedTime(new java.util.Date(rs.getLong("DL_UPDATED_TIMESTAMP"))); -// -// deviceInfo.setLocation(deviceLocation); -// device.setDeviceInfo(deviceInfo); -// devices.add(device); -// devs.put(device.getId(), device.getId()); -// } -// } -// } catch (SQLException e) { -// throw new SearchDAOException("Error occurred while acquiring the device details.", e); -// } finally { -// DeviceManagementDAOUtil.cleanupResources(stmt, null); -// } -// -// this.fillPropertiesOfDevices(devices); -// -// if (log.isDebugEnabled()) { -// log.debug("Number of the device returned from the query : " + devices.size()); -// } -// return devices; -// } -// -// @Override -// public List searchDevicePropertyTable(String query) throws SearchDAOException { -// if (log.isDebugEnabled()) { -// log.debug("Query : " + query); -// } -// -// Connection conn; -// PreparedStatement stmt = null; -// ResultSet rs; -// List devices = new ArrayList<>(); -// Map devs = new HashMap<>(); -// try { -// conn = this.getConnection(); -// stmt = conn.prepareStatement(query); -// rs = stmt.executeQuery(); -// while (rs.next()) { -// if (!devs.containsKey(rs.getInt("ID"))) { -// Device device = new Device(); -// device.setId(rs.getInt("ID")); -// device.setDescription(rs.getString("DESCRIPTION")); -// device.setName(rs.getString("NAME")); -// device.setType(rs.getString("DEVICE_TYPE_NAME")); -// device.setDeviceIdentifier(rs.getString("DEVICE_IDENTIFICATION")); -// -// DeviceIdentifier identifier = new DeviceIdentifier(); -// identifier.setType(rs.getString("DEVICE_TYPE_NAME")); -// identifier.setId(rs.getString("DEVICE_IDENTIFICATION")); -// -// DeviceInfo deviceInfo = new DeviceInfo(); -// deviceInfo.setAvailableRAMMemory(rs.getDouble("AVAILABLE_RAM_MEMORY")); -// deviceInfo.setBatteryLevel(rs.getDouble("BATTERY_LEVEL")); -// deviceInfo.setConnectionType(rs.getString("CONNECTION_TYPE")); -// deviceInfo.setCpuUsage(rs.getDouble("CPU_USAGE")); -// deviceInfo.setDeviceModel(rs.getString("DEVICE_MODEL")); -// deviceInfo.setExternalAvailableMemory(rs.getDouble("EXTERNAL_AVAILABLE_MEMORY")); -// deviceInfo.setExternalTotalMemory(rs.getDouble("EXTERNAL_TOTAL_MEMORY")); -// deviceInfo.setInternalAvailableMemory(rs.getDouble("INTERNAL_AVAILABLE_MEMORY")); -// deviceInfo.setInternalTotalMemory(rs.getDouble("EXTERNAL_TOTAL_MEMORY")); -// deviceInfo.setOsVersion(rs.getString("OS_VERSION")); -// deviceInfo.setOsBuildDate(rs.getString("OS_BUILD_DATE")); -// deviceInfo.setPluggedIn(rs.getBoolean("PLUGGED_IN")); -// deviceInfo.setSsid(rs.getString("SSID")); -// deviceInfo.setTotalRAMMemory(rs.getDouble("TOTAL_RAM_MEMORY")); -// deviceInfo.setVendor(rs.getString("VENDOR")); -// deviceInfo.setUpdatedTime(new java.util.Date(rs.getLong("UPDATE_TIMESTAMP"))); -// -// DeviceLocation deviceLocation = new DeviceLocation(); -// deviceLocation.setLatitude(rs.getDouble("LATITUDE")); -// deviceLocation.setLongitude(rs.getDouble("LONGITUDE")); -// deviceLocation.setStreet1(rs.getString("STREET1")); -// deviceLocation.setStreet2(rs.getString("STREET2")); -// deviceLocation.setCity(rs.getString("CITY")); -// deviceLocation.setState(rs.getString("STATE")); -// deviceLocation.setZip(rs.getString("ZIP")); -// deviceLocation.setCountry(rs.getString("COUNTRY")); -// deviceLocation.setDeviceId(rs.getInt("ID")); -// deviceLocation.setUpdatedTime(new java.util.Date(rs.getLong("DL_UPDATED_TIMESTAMP"))); -// -// deviceInfo.setLocation(deviceLocation); -// device.setDeviceInfo(deviceInfo); -// devices.add(device); -// devs.put(device.getId(), device.getId()); -// } -// -// } -// } catch (SQLException e) { -// throw new SearchDAOException("Error occurred while aquiring the device details.", e); -// } finally { -// DeviceManagementDAOUtil.cleanupResources(stmt, null); -// } -// -// this.fillPropertiesOfDevices(devices); -// -// if (log.isDebugEnabled()) { -// log.debug("Number of the device returned from the query : " + devices.size()); -// } -// -// return devices; -// } -// -// -// private Connection getConnection() throws SQLException { -// return DeviceManagementDAOFactory.getConnection(); -// } -// -// private List fillPropertiesOfDevices(List devices) throws SearchDAOException { -// if (devices.isEmpty()) { -// return null; -// } -// -// Connection conn; -// PreparedStatement stmt; -// ResultSet rs; -// -// try { -// conn = this.getConnection(); -// String query = "SELECT * FROM DM_DEVICE_INFO WHERE DEVICE_ID IN (?) ORDER BY DEVICE_ID ;"; -// stmt = conn.prepareStatement(query); -// if (conn.getMetaData().getDatabaseProductName().contains("H2") || -// conn.getMetaData().getDatabaseProductName().contains("MySQL")) { -// String inData = Utils.getDeviceIdsAsString(devices); -// stmt.setString(1, inData); -// } else { -// Array array = conn.createArrayOf("INT", Utils.getArrayOfDeviceIds(devices)); -// stmt.setArray(1, array); -// } -// rs = stmt.executeQuery(); -// -// DeviceInfo dInfo; -// while (rs.next()) { -// dInfo = this.getDeviceInfo(devices, rs.getInt("DEVICE_ID")); -// dInfo.getDeviceDetailsMap().put(rs.getString("KEY_FIELD"), rs.getString("VALUE_FIELD")); -// } -// } catch (SQLException e) { -// throw new SearchDAOException("Error occurred while retrieving the device properties.", e); -// } -// return devices; -// } -// -// private DeviceInfo getDeviceInfo(List devices, int deviceId) { -// for (Device device : devices) { -// if (device.getId() == deviceId) { -// if (device.getDeviceInfo() == null) { -// device.setDeviceInfo(new DeviceInfo()); -// } -// return device.getDeviceInfo(); -// } -// } -// return null; -// } - -} - diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/test/java/org/wso2/carbon/device/mgt/core/search/DeviceDetails.java b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/test/java/org/wso2/carbon/device/mgt/core/search/DeviceDetails.java index 0d9a8243225..7846c21ea06 100644 --- a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/test/java/org/wso2/carbon/device/mgt/core/search/DeviceDetails.java +++ b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/test/java/org/wso2/carbon/device/mgt/core/search/DeviceDetails.java @@ -23,12 +23,10 @@ import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.testng.annotations.BeforeClass; import org.testng.annotations.Test; -import org.wso2.carbon.device.mgt.common.DeviceIdentifier; import org.wso2.carbon.device.mgt.core.common.BaseDeviceManagementTest; import org.wso2.carbon.device.mgt.core.device.details.mgt.DeviceInformationManager; import org.wso2.carbon.device.mgt.core.device.details.mgt.impl.DeviceInformationManagerImpl; import org.wso2.carbon.device.mgt.core.internal.DeviceManagementDataHolder; -import org.wso2.carbon.device.mgt.core.search.util.Utils; import org.wso2.carbon.device.mgt.core.service.DeviceManagementProviderService; import org.wso2.carbon.device.mgt.core.service.DeviceManagementProviderServiceImpl; diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/test/java/org/wso2/carbon/device/mgt/core/search/SearchDevice.java b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/test/java/org/wso2/carbon/device/mgt/core/search/SearchDevice.java index 8d46eb2d58b..d624bfa4e69 100644 --- a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/test/java/org/wso2/carbon/device/mgt/core/search/SearchDevice.java +++ b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/test/java/org/wso2/carbon/device/mgt/core/search/SearchDevice.java @@ -39,7 +39,7 @@ import java.util.List; public class SearchDevice extends BaseDeviceManagementTest { - private static final Log log = LogFactory.getLog(DeviceDetails.class); + private static final Log log = LogFactory.getLog(SearchDevice.class); @BeforeClass @Override diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/conf/config.json b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/conf/config.json index a1d79646d9f..83671e61bef 100644 --- a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/conf/config.json +++ b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/conf/config.json @@ -1,8 +1,7 @@ { "appContext": "/devicemgt/", - "httpsURL" : "%https.ip%", - "httpURL" : "%http.ip%", - "httpsWebURL" : "%https.ip%", + "httpsURL" : "https://localhost:8243", + "httpURL" : "http://localhost:8280", "wssURL" : "https://localhost:9445", "wsURL" : "%http.ip%", "portalURL": "https://%server.ip%:9445", @@ -13,7 +12,7 @@ "iOSConfigRoot" : "%https.ip%/ios-enrollment/", "iOSAPIRoot" : "%https.ip%/ios/", "adminService": "%https.ip%", - "gatewayEnabled": false, + "gatewayEnabled": true, "oauthProvider": { "appRegistration": { "appType": "webapp", diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/modules/business-controllers/user.js b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/modules/business-controllers/user.js index 51cbd25c647..c6ed7da1bdb 100644 --- a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/modules/business-controllers/user.js +++ b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/modules/business-controllers/user.js @@ -674,6 +674,7 @@ var userModule = function () { */ publicMethods.getSecondaryUserStores = function () { var returnVal = []; + // To call the userstore admin service, user needs to have admin permission if (publicMethods.isAuthorized("/permission/admin")) { var endpoint = devicemgtProps["adminService"] + constants["USER_STORE_CONFIG_ADMIN_SERVICE_END_POINT"]; var wsPayload = ""; @@ -682,7 +683,7 @@ var userModule = function () { wsPayload, endpoint, function (wsResponse) { - var domainIDs = stringify(wsResponse.*::['return']. *::domainId.text()); + var domainIDs = stringify(wsResponse. * ::['return']. * ::domainId.text()); if (domainIDs != "\"\"") { var regExpForSearch = new RegExp(constants["USER_STORES_NOISY_CHAR"], "g"); domainIDs = domainIDs.replace(regExpForSearch, ""); @@ -692,11 +693,11 @@ var userModule = function () { log.error("Error retrieving secondary user stores", e); }, constants["SOAP_VERSION"]); - } else { + } else { if (log.isDebugEnabled()) { log.debug("User does not have admin permission to get the secondary user store details."); - } - } + } + } return returnVal; }; diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.users/public/js/listing.js b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.users/public/js/listing.js index 3e3c64781fc..ad1e3b549de 100644 --- a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.users/public/js/listing.js +++ b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.users/public/js/listing.js @@ -68,10 +68,10 @@ $("a#invite-user-link").click(function () { modalDialog.showAsError(); } else { modalDialog.header(""); - modalDialog.content("An invitation mail will be sent to the selected user(s) to initiate an enrolment process." + - " Do you wish to continue ?"); - modalDialog.footer('
yes' + - 'No
'); + modalDialog.content("An invitation mail will be sent to the selected user(s) to initiate an enrolment " + + "process. Do you wish to continue ?"); + modalDialog.footer('
yes' + + 'No
'); modalDialog.show(); } @@ -82,18 +82,18 @@ $("a#invite-user-link").click(function () { usernameList, function () { modalDialog.header("User invitation email for enrollment was successfully sent."); - modalDialog.footer('
Ok
'); + modalDialog.footer('
Ok
'); $("a#invite-user-success-link").click(function () { modalDialog.hide(); }); }, function () { - modalDialog.header(' Unexpected Error !'); + modalDialog.header(' Unexpected Error !'); modalDialog.content('An unexpected error occurred. Try again later.'); - modalDialog.footer('
Ok
'); + modalDialog.footer('
Ok
'); $("a#invite-user-error-link").click(function () { modalDialog.hide(); }); diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/uuf-template-app/lib/modules/auth/auth.js b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/uuf-template-app/lib/modules/auth/auth.js index a18d2efc501..93cffdbf862 100644 --- a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/uuf-template-app/lib/modules/auth/auth.js +++ b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/uuf-template-app/lib/modules/auth/auth.js @@ -502,25 +502,34 @@ var module = {}; // This is a logout response. module.logout(response); } else { - // This is a login response. - var ssoConfigs = getSsoConfigurations(); - var CarbonUtils = Packages.org.wso2.carbon.utils.CarbonUtils; - var keyStorePassword = CarbonUtils.getServerConfiguration().getFirstProperty("Security.TrustStore.Password"); - var keyStoreName = CarbonUtils.getServerConfiguration().getFirstProperty("Security.TrustStore.Location"); - var identityAlias = ssoConfigs[constants.APP_CONF_AUTH_MODULE_SSO_IDENTITY_ALIAS]; - var keyStoreParams = { - KEY_STORE_NAME: keyStoreName, - KEY_STORE_PASSWORD: keyStorePassword, - IDP_ALIAS: identityAlias - }; - - if (!ssoClient.validateSamlResponse(samlResponseObj, ssoConfigs, keyStoreParams)) { - var msg = "Invalid signature found in the SAML response."; - log.error(msg); - response.sendError(500, msg); - return; - } + // This is a login response. + var ssoConfigs = getSsoConfigurations(); + var CarbonUtils = Packages.org.wso2.carbon.utils.CarbonUtils; + var keyStorePassword = CarbonUtils.getServerConfiguration().getFirstProperty("Security.TrustStore.Password"); + var keyStoreName = CarbonUtils.getServerConfiguration().getFirstProperty("Security.TrustStore.Location"); + var identityAlias = ssoConfigs[constants.APP_CONF_AUTH_MODULE_SSO_IDENTITY_ALIAS]; + var keyStoreParams = { + KEY_STORE_NAME: keyStoreName, + KEY_STORE_PASSWORD: keyStorePassword, + IDP_ALIAS: identityAlias + }; + var rsEnabled = ssoConfigs[constants.APP_CONF_AUTH_MODULE_SSO_RESPONSE_SIGNING_ENABLED]; + if (utils.parseBoolean(rsEnabled)) { + if (!ssoClient.validateSignature(samlResponseObj, keyStoreParams)) { + var msg = "Invalid signature found in the SAML response."; + log.error(msg); + response.sendError(500, msg); + return; + } + } + if (!ssoClient.validateSamlResponse(samlResponseObj, ssoConfigs, keyStoreParams)) { + var msg = "Invalid SAML response found."; + log.error(msg); + response.sendError(500, msg); + return; + } + /** * @type {{sessionId: string, loggedInUser: string, sessionIndex: string, samlToken: * string}} @@ -531,10 +540,9 @@ var module = {}; var ssoSessions = getSsoSessions(); ssoSessions[ssoSession.sessionId] = ssoSession; if (ssoSession.sessionIndex) { - module.loadTenant(ssoSession.loggedInUser); var carbonUser = (require("carbon")).server.tenantUser(ssoSession.loggedInUser); - module.loadTenant(ssoSession.loggedInUser); utils.setCurrentUser(carbonUser.username, carbonUser.domain, carbonUser.tenantId); + module.loadTenant(ssoSession.loggedInUser); var scriptArgument = {input: {samlToken: ssoSession.samlToken}, user: module.getCurrentUser()}; handleEvent(OPERATION_LOGIN, EVENT_SUCCESS, scriptArgument); } diff --git a/pom.xml b/pom.xml index 76fb99e3b2d..dfe9e5c8dad 100644 --- a/pom.xml +++ b/pom.xml @@ -1581,7 +1581,7 @@ io.swagger swagger-annotations - ${swagger.version} + ${swagger.annotations.version} io.swagger