From cbd42d202635f6eb7dfbdb449ce9d4211c5dd08d Mon Sep 17 00:00:00 2001 From: Shabirmean Date: Thu, 2 Jun 2016 17:13:09 +0530 Subject: [PATCH 1/2] Changes to the certificate generators to fetch the Certificate alias from the Unique Identifier set in the CSR --- .../dao/impl/GenericCertificateDAOImpl.java | 1 + .../mgt/core/impl/CertificateGenerator.java | 74 +++++++++++++++---- 2 files changed, 62 insertions(+), 13 deletions(-) diff --git a/components/certificate-mgt/org.wso2.carbon.certificate.mgt.core/src/main/java/org/wso2/carbon/certificate/mgt/core/dao/impl/GenericCertificateDAOImpl.java b/components/certificate-mgt/org.wso2.carbon.certificate.mgt.core/src/main/java/org/wso2/carbon/certificate/mgt/core/dao/impl/GenericCertificateDAOImpl.java index 73f6ee7b793..d85795984df 100644 --- a/components/certificate-mgt/org.wso2.carbon.certificate.mgt.core/src/main/java/org/wso2/carbon/certificate/mgt/core/dao/impl/GenericCertificateDAOImpl.java +++ b/components/certificate-mgt/org.wso2.carbon.certificate.mgt.core/src/main/java/org/wso2/carbon/certificate/mgt/core/dao/impl/GenericCertificateDAOImpl.java @@ -61,6 +61,7 @@ public class GenericCertificateDAOImpl implements CertificateDAO { getThreadLocalCarbonContext(); String username = threadLocalCarbonContext.getUsername(); for (Certificate certificate : certificates) { + // the serial number of the certificate used for its creation is set as its alias. String serialNumber = certificate.getSerial(); if (serialNumber == null || serialNumber.isEmpty()) { serialNumber = String.valueOf(certificate.getCertificate().getSerialNumber()); diff --git a/components/certificate-mgt/org.wso2.carbon.certificate.mgt.core/src/main/java/org/wso2/carbon/certificate/mgt/core/impl/CertificateGenerator.java b/components/certificate-mgt/org.wso2.carbon.certificate.mgt.core/src/main/java/org/wso2/carbon/certificate/mgt/core/impl/CertificateGenerator.java index f8cc47cbf4b..f71162904c4 100755 --- a/components/certificate-mgt/org.wso2.carbon.certificate.mgt.core/src/main/java/org/wso2/carbon/certificate/mgt/core/impl/CertificateGenerator.java +++ b/components/certificate-mgt/org.wso2.carbon.certificate.mgt.core/src/main/java/org/wso2/carbon/certificate/mgt/core/impl/CertificateGenerator.java @@ -25,7 +25,9 @@ import org.bouncycastle.asn1.ASN1InputStream; import org.bouncycastle.asn1.ASN1Primitive; import org.bouncycastle.asn1.pkcs.Attribute; import org.bouncycastle.asn1.pkcs.PKCSObjectIdentifiers; +import org.bouncycastle.asn1.x500.RDN; import org.bouncycastle.asn1.x500.X500Name; +import org.bouncycastle.asn1.x500.style.BCStyle; import org.bouncycastle.asn1.x509.KeyUsage; import org.bouncycastle.asn1.x509.X509Extension; import org.bouncycastle.cert.CertIOException; @@ -44,14 +46,14 @@ import org.bouncycastle.operator.OperatorCreationException; import org.bouncycastle.operator.jcajce.JcaContentSignerBuilder; import org.bouncycastle.pkcs.PKCS10CertificationRequest; import org.bouncycastle.util.Store; -import org.jscep.message.PkcsPkiEnvelopeDecoder; -import org.jscep.message.PkiMessageDecoder; -import org.jscep.message.PkiMessage; import org.jscep.message.CertRep; +import org.jscep.message.MessageDecodingException; +import org.jscep.message.MessageEncodingException; +import org.jscep.message.PkcsPkiEnvelopeDecoder; import org.jscep.message.PkcsPkiEnvelopeEncoder; +import org.jscep.message.PkiMessage; +import org.jscep.message.PkiMessageDecoder; import org.jscep.message.PkiMessageEncoder; -import org.jscep.message.MessageEncodingException; -import org.jscep.message.MessageDecodingException; import org.jscep.transaction.FailInfo; import org.jscep.transaction.Nonce; import org.jscep.transaction.TransactionId; @@ -70,10 +72,31 @@ import org.wso2.carbon.device.mgt.common.TransactionManagementException; import javax.security.auth.x500.X500Principal; import javax.xml.bind.DatatypeConverter; -import java.io.*; -import java.security.*; +import java.io.ByteArrayInputStream; +import java.io.DataInputStream; +import java.io.File; +import java.io.FileInputStream; +import java.io.FileNotFoundException; +import java.io.IOException; +import java.io.InputStream; +import java.math.BigInteger; +import java.security.InvalidKeyException; +import java.security.KeyFactory; +import java.security.KeyPair; +import java.security.KeyPairGenerator; +import java.security.NoSuchAlgorithmException; +import java.security.NoSuchProviderException; +import java.security.PrivateKey; +import java.security.SecureRandom; +import java.security.Security; +import java.security.SignatureException; import java.security.cert.Certificate; -import java.security.cert.*; +import java.security.cert.CertificateEncodingException; +import java.security.cert.CertificateException; +import java.security.cert.CertificateExpiredException; +import java.security.cert.CertificateFactory; +import java.security.cert.CertificateNotYetValidException; +import java.security.cert.X509Certificate; import java.security.spec.InvalidKeySpecException; import java.security.spec.PKCS8EncodedKeySpec; import java.util.ArrayList; @@ -299,7 +322,7 @@ public class CertificateGenerator { if (distinguishedName != null && !distinguishedName.isEmpty()) { String[] dnSplits = distinguishedName.split("/CN="); if (dnSplits != null) { - String commonNameExtracted = dnSplits[dnSplits.length-1]; + String commonNameExtracted = dnSplits[dnSplits.length - 1]; lookUpCertificate = keyStoreReader.getCertificateBySerial(commonNameExtracted); } } @@ -419,12 +442,37 @@ public class CertificateGenerator { // } // } + + RDN[] certUniqueIdRDN; + BigInteger certUniqueIdentifier; + + // IMPORTANT: "Serial-Number" of the certificate used when creating it, is set as its "Alias" to save to + // keystore. + if (request.getSubject().getRDNs(BCStyle.UNIQUE_IDENTIFIER).length != 0) { + // if certificate attribute "UNIQUE_IDENTIFIER" exists use its hash as the "Serial-Number" for the + // certificate. + certUniqueIdRDN = request.getSubject().getRDNs(BCStyle.UNIQUE_IDENTIFIER); + certUniqueIdentifier = BigInteger.valueOf(certUniqueIdRDN[0].getFirst().getValue().toString().hashCode()); + + } else if (request.getSubject().getRDNs(BCStyle.SERIALNUMBER).length != 0) { + // else if certificate attribute "SERIAL_NUMBER" exists use its hash as the "Serial-Number" for the + // certificate. + certUniqueIdRDN = request.getSubject().getRDNs(BCStyle.SERIALNUMBER); + certUniqueIdentifier = BigInteger.valueOf(certUniqueIdRDN[0].getFirst().getValue().toString().hashCode()); + + } else { + // else get the BigInteger Value of the integer that is the current system-time in millis as the + // "Serial-Number". + certUniqueIdentifier = CommonUtil.generateSerialNumber(); + } + X509v3CertificateBuilder certificateBuilder = new X509v3CertificateBuilder( - new X500Name(issueSubject), CommonUtil.generateSerialNumber(), - validityBeginDate, validityEndDate, certSubject, request.getSubjectPublicKeyInfo()); + new X500Name(issueSubject), certUniqueIdentifier, validityBeginDate, validityEndDate, certSubject, + request.getSubjectPublicKeyInfo()); ContentSigner sigGen; X509Certificate issuedCert; + try { certificateBuilder.addExtension(X509Extension.keyUsage, true, new KeyUsage( KeyUsage.digitalSignature | KeyUsage.keyEncipherment)); @@ -434,7 +482,7 @@ public class CertificateGenerator { if (extractedValue != null) { certificateBuilder.addExtension(PKCSObjectIdentifiers.pkcs_9_at_challengePassword, true, - extractedValue); + extractedValue); } } @@ -691,7 +739,7 @@ public class CertificateGenerator { throw new KeystoreException("CSR cannot be recovered.", e); } X509Certificate signedCertificate = generateCertificateFromCSR(privateKeyCA, certificationRequest, - certCA.getIssuerX500Principal().getName()); + certCA.getIssuerX500Principal().getName()); return signedCertificate; } From a55dc9bce891c0cbca8a8da560716138868323bc Mon Sep 17 00:00:00 2001 From: Shabirmean Date: Tue, 7 Jun 2016 09:29:54 +0530 Subject: [PATCH 2/2] Adding necessary imports for the Certificate generation from CSR --- .../org.wso2.carbon.certificate.mgt.core/pom.xml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/components/certificate-mgt/org.wso2.carbon.certificate.mgt.core/pom.xml b/components/certificate-mgt/org.wso2.carbon.certificate.mgt.core/pom.xml index 8635865bf49..b6abda03d1c 100644 --- a/components/certificate-mgt/org.wso2.carbon.certificate.mgt.core/pom.xml +++ b/components/certificate-mgt/org.wso2.carbon.certificate.mgt.core/pom.xml @@ -68,8 +68,9 @@ org.bouncycastle.jce.provider, org.bouncycastle.operator, org.bouncycastle.operator.jcajce, + org.bouncycastle.asn1.x500.style, org.bouncycastle.pkcs, - org.bouncycastle.openssl, + org.bouncycastle.util, org.jscep.message, org.wso2.carbon.context, @@ -77,7 +78,7 @@ org.w3c.dom, org.xml.sax, javax.sql, - javax.cache, + javax.naming, javax.xml.bind.annotation, javax.xml.bind, @@ -85,7 +86,7 @@ org.wso2.carbon.device.mgt.common.*, io.swagger.annotations.*;resolution:=optional, org.wso2.carbon.device.mgt.core.*, - org.bouncycastle.pkcs.jcajce + !org.wso2.carbon.certificate.mgt.core.internal.*,