From 345fdc0ceda79f5028ac80473940e044d34fa188 Mon Sep 17 00:00:00 2001
From: Madawa Soysa <madawa.rc@gmail.com>
Date: Thu, 1 Dec 2016 12:34:15 +0530
Subject: [PATCH 1/2] IOTS-296: Removing ownership selection when policy
 creation

Removes ownership selection when creating and editing policies. Ownership management is done by the groups.
---
 .../app/units/cdmf.unit.policy.create/create.hbs   | 14 --------------
 .../public/js/policy-create.js                     |  5 ++---
 .../app/units/cdmf.unit.policy.edit/edit.hbs       | 13 -------------
 .../cdmf.unit.policy.edit/public/js/policy-edit.js |  2 +-
 4 files changed, 3 insertions(+), 31 deletions(-)

diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.policy.create/create.hbs b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.policy.create/create.hbs
index 32e124a9a4b..a39f6513789 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.policy.create/create.hbs
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.policy.create/create.hbs
@@ -129,20 +129,6 @@
                                     <i class="icon fw fw-error"></i><span></span>
                                 </div>
                                 <div>
-                                    <label class="wr-input-label">
-                                        Set device ownership type
-                                    </label>
-                                    <div class="wr-input-control">
-                                        <div class="cus-col-50">
-                                            <!--suppress HtmlFormInputWithoutLabel -->
-                                            <select id="ownership-input" class="form-control">
-                                                <option value="ANY" selected>ANY</option>
-                                                <option value="BYOD">BYOD (Bring Your Own Device)</option>
-                                                <option value="COPE">COPE (Corporate-Owned, Personally Enabled)</option>
-                                            </select>
-                                        </div>
-                                        <br class="c-both"/>
-                                    </div>
                                     <div class="wr-input-control">
                                         {{#if isAuthorizedViewRoles}}
                                             <label class="wr-input-control radio light">
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.policy.create/public/js/policy-create.js b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.policy.create/public/js/policy-create.js
index 2f849a44c94..b783f165c6d 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.policy.create/public/js/policy-create.js
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.policy.create/public/js/policy-create.js
@@ -201,12 +201,11 @@ stepForwardFrom["policy-criteria"] = function () {
         }
     });
     policy["selectedGroups"] = $("#groups-input").val();
-    if (policy["selectedGroups"].length > 1 || policy["selectedGroups"][0] !== "NONE") {
+    if (policy["selectedGroup"] && (policy["selectedGroups"].length > 1 || policy["selectedGroups"][0] !== "NONE")) {
         policy["selectedGroups"] = createDeviceGroupWrapper(policy["selectedGroups"]);
     }
 
     policy["selectedNonCompliantAction"] = $("#action-input").find(":selected").data("action");
-    policy["selectedOwnership"] = $("#ownership-input").val();
     //updating next-page wizard title with selected platform
     $("#policy-naming-page-wizard-title").text("ADD " + policy["platform"] + " POLICY");
 };
@@ -373,7 +372,7 @@ var savePolicy = function (policy, isActive, serviceURL) {
         "policyName": policy["policyName"],
         "description": policy["description"],
         "compliance": policy["selectedNonCompliantAction"],
-        "ownershipType": policy["selectedOwnership"],
+        "ownershipType": null,
         "active": isActive,
         "profile": {
             "profileName": policy["policyName"],
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.policy.edit/edit.hbs b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.policy.edit/edit.hbs
index 9a6135b607d..16399beb1bc 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.policy.edit/edit.hbs
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.policy.edit/edit.hbs
@@ -123,19 +123,6 @@
                                     <i class="icon fw fw-error"></i><span></span>
                                 </div>
                                 <div>
-                                    <label class="wr-input-label">
-                                        Set device ownership type
-                                    </label>
-                                    <div class="wr-input-control">
-                                        <div class="cus-col-50">
-                                            <select id="ownership-input" class="form-control">
-                                                <option value="ANY" selected>ANY</option>
-                                                <option value="BYOD">BYOD (Bring Your Own Device)</option>
-                                                <option value="COPE">COPE (Corporate-Owned, Personally Enabled)</option>
-                                            </select>
-                                        </div>
-                                        <br class="c-both"/>
-                                    </div>
                                     <div class="wr-input-control">
                                         {{#if isAuthorizedViewRoles}}
                                             <label class="wr-input-control radio light">
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.policy.edit/public/js/policy-edit.js b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.policy.edit/public/js/policy-edit.js
index 76969b0889a..fc69aa53e45 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.policy.edit/public/js/policy-edit.js
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.policy.edit/public/js/policy-edit.js
@@ -425,7 +425,7 @@ var updatePolicy = function (policy, state) {
         "policyName": policy["policyName"],
         "description": policy["description"],
         "compliance": policy["selectedNonCompliantAction"],
-        "ownershipType": policy["selectedOwnership"],
+        "ownershipType": null,
         "profile": {
             "profileName": policy["policyName"],
             "deviceType": policy["platform"],

From b2650e439c8652f520a782862a6679193c8e495c Mon Sep 17 00:00:00 2001
From: Madawa Soysa <madawa.rc@gmail.com>
Date: Thu, 1 Dec 2016 15:23:00 +0530
Subject: [PATCH 2/2] Fix issue with policy wrapper group select

---
 .../units/cdmf.unit.policy.create/public/js/policy-create.js    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.policy.create/public/js/policy-create.js b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.policy.create/public/js/policy-create.js
index b783f165c6d..d52d8e7df4e 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.policy.create/public/js/policy-create.js
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.policy.create/public/js/policy-create.js
@@ -201,7 +201,7 @@ stepForwardFrom["policy-criteria"] = function () {
         }
     });
     policy["selectedGroups"] = $("#groups-input").val();
-    if (policy["selectedGroup"] && (policy["selectedGroups"].length > 1 || policy["selectedGroups"][0] !== "NONE")) {
+    if (policy["selectedGroups"] && (policy["selectedGroups"].length > 1 || policy["selectedGroups"][0] !== "NONE")) {
         policy["selectedGroups"] = createDeviceGroupWrapper(policy["selectedGroups"]);
     }