From b4a6864c69333d5ffdcad72f6140fadc7739c2bb Mon Sep 17 00:00:00 2001 From: megala21 Date: Mon, 2 Oct 2017 10:20:00 +0530 Subject: [PATCH 1/4] Fixing build failure --- modules/distribution/src/assembly/bin.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/modules/distribution/src/assembly/bin.xml b/modules/distribution/src/assembly/bin.xml index 85809762..f503f159 100755 --- a/modules/distribution/src/assembly/bin.xml +++ b/modules/distribution/src/assembly/bin.xml @@ -1992,16 +1992,19 @@ src/core/resources/security/wso2carbon.jks ${pom.artifactId}-${pom.version}/repository/resources/security + false 644 src/core/resources/security/wso2carbon.jks ${pom.artifactId}-${pom.version}/wso2/analytics/repository/resources/security + false 644 src/core/resources/security/wso2carbon.jks ${pom.artifactId}-${pom.version}/wso2/broker/repository/resources/security + false 644 From 914ae3db9350e5c465c59ed4149a469aff88c1ad Mon Sep 17 00:00:00 2001 From: megala21 Date: Tue, 3 Oct 2017 10:32:05 +0530 Subject: [PATCH 2/4] Fixing build failure --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 71f834dd..4a8dab4c 100644 --- a/pom.xml +++ b/pom.xml @@ -21,7 +21,7 @@ 4.0.0 org.wso2.iot - wso2iot-parent + wso2iot-parent pom 3.1.1-SNAPSHOT WSO2 IoT - Parent @@ -31,7 +31,7 @@ org.wso2 wso2 - 1 + 2 From 44fff51574369dc52219a5a4c6e99f6cf047dbad Mon Sep 17 00:00:00 2001 From: megala21 Date: Tue, 3 Oct 2017 10:38:08 +0530 Subject: [PATCH 3/4] Refactor --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 4a8dab4c..1005118e 100644 --- a/pom.xml +++ b/pom.xml @@ -21,7 +21,7 @@ 4.0.0 org.wso2.iot - wso2iot-parent + wso2iot-parent pom 3.1.1-SNAPSHOT WSO2 IoT - Parent From 5a401d67a10c03ea23106956a3545c0c24e9330e Mon Sep 17 00:00:00 2001 From: maheshika Date: Tue, 3 Oct 2017 15:22:46 +0530 Subject: [PATCH 4/4] Adding Pull Request Template --- pull_request_template.md | 52 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) create mode 100644 pull_request_template.md diff --git a/pull_request_template.md b/pull_request_template.md new file mode 100644 index 00000000..9b32185a --- /dev/null +++ b/pull_request_template.md @@ -0,0 +1,52 @@ +## Purpose +> Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: Resolves issue1, issue2, etc. + +## Goals +> Describe the solutions that this feature/fix will introduce to resolve the problems described above + +## Approach +> Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here. + +## User stories +> Summary of user stories addressed by this change> + +## Release note +> Brief description of the new feature or bug fix as it will appear in the release notes + +## Documentation +> Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact + +## Training +> Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable + +## Certification +> Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why. + +## Marketing +> Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable + +## Automation tests + - Unit tests + > Code coverage information + - Integration tests + > Details about the test cases and coverage + +## Security checks + - Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no + - Ran FindSecurityBugs plugin and verified report? yes/no + - Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no + +## Samples +> Provide high-level details about the samples related to this feature + +## Related PRs +> List any other related PRs + +## Migrations (if applicable) +> Describe migration steps and platforms on which migration has been tested + +## Test environment +> List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested + +## Learning +> Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem. \ No newline at end of file