From 130cad34ee4bed835f30c75ac63faf43d1b30d04 Mon Sep 17 00:00:00 2001 From: Menaka Madushanka Date: Mon, 14 Mar 2016 19:50:50 +0530 Subject: [PATCH] Changes suggested in the Code review. --- .../test/samples/SampleInstallationTest.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/modules/integration/tests-iot-web-ui/src/test/java/org/wso2/carbon/iot/integration/web/ui/test/samples/SampleInstallationTest.java b/modules/integration/tests-iot-web-ui/src/test/java/org/wso2/carbon/iot/integration/web/ui/test/samples/SampleInstallationTest.java index 5d5f1c79..1368e0b1 100644 --- a/modules/integration/tests-iot-web-ui/src/test/java/org/wso2/carbon/iot/integration/web/ui/test/samples/SampleInstallationTest.java +++ b/modules/integration/tests-iot-web-ui/src/test/java/org/wso2/carbon/iot/integration/web/ui/test/samples/SampleInstallationTest.java @@ -65,7 +65,7 @@ public class SampleInstallationTest extends IOTIntegrationUIBaseTestCase { private Process tempProcess = null; private Properties properties = System.getProperties(); private String carbonHome = properties.getProperty(Constants.CARBON_HOME); - private String[] cmdArray; + private String[] commands; private LogViewerClient logViewerClient; @BeforeClass(alwaysRun = true) @@ -84,12 +84,12 @@ public class SampleInstallationTest extends IOTIntegrationUIBaseTestCase { try { if (System.getProperty(Constants.OS_NAME).toLowerCase().contains("windows")) { log.info("Executing maven clean install --------------------------------"); - cmdArray = new String[]{"cmd.exe", "/c", "mvn clean install"}; - tempProcess = Runtime.getRuntime().exec(cmdArray, null, dir); + commands = new String[]{"cmd.exe", "/c", "mvn clean install"}; + tempProcess = Runtime.getRuntime().exec(commands, null, dir); } else { log.info("Executing maven clean install --------------------------------"); - cmdArray = new String[]{"mvn", "clean", "install"}; - tempProcess = Runtime.getRuntime().exec(cmdArray, null, dir); + commands = new String[]{"mvn", "clean", "install"}; + tempProcess = Runtime.getRuntime().exec(commands, null, dir); } boolean buildStatus = waitForMessage(tempProcess.getInputStream(), Constants.BUILD_SUCCESS_MSG); @@ -111,11 +111,11 @@ public class SampleInstallationTest extends IOTIntegrationUIBaseTestCase { log.info("Sample installation started : mvn clean install -f device-deployer.xml"); try { if (System.getProperty(Constants.OS_NAME).toLowerCase().contains("windows")) { - cmdArray = new String[]{"cmd.exe", "/c", "mvn clean install -f device-deployer.xml"}; - tempProcess = Runtime.getRuntime().exec(cmdArray, null, dir); + commands = new String[]{"cmd.exe", "/c", "mvn clean install -f device-deployer.xml"}; + tempProcess = Runtime.getRuntime().exec(commands, null, dir); } else { - cmdArray = new String[]{"mvn", "clean", "install", "-f", "device-deployer.xml"}; - tempProcess = Runtime.getRuntime().exec(cmdArray, null, dir); + commands = new String[]{"mvn", "clean", "install", "-f", "device-deployer.xml"}; + tempProcess = Runtime.getRuntime().exec(commands, null, dir); } boolean buildStatus = waitForMessage(tempProcess.getInputStream(), Constants.BUILD_SUCCESS_MSG); Assert.assertTrue(buildStatus, "Sample installation was not successful");