Merge pull request #9 from milanperera/master

Refactored to support device info function

components/device-mgt/org.wso2.carbon.device.mgt.common/src/main/java/org/wso2/carbon/device/mgt/common/spi/DeviceManager.java

@@ -118,10 +118,11 @@ public interface DeviceManager {
     /**
      * Method to update device information.
      *
+     * @param deviceIdentifier   identifier to identify the device
      * @param device   Updated device information related data
      * @throws DeviceManagementException If some unusual behaviour is observed while updating the device info
      */
-    boolean updateDeviceInfo(Device device) throws DeviceManagementException;
+    boolean updateDeviceInfo(DeviceIdentifier deviceIdentifier, Device device) throws DeviceManagementException;
 
     /**
      * Method to set the ownership type of a particular device. i.e. BYOD, COPE.

components/device-mgt/org.wso2.carbon.device.mgt.common/src/main/java/org/wso2/carbon/device/mgt/common/spi/DeviceMgtService.java

@@ -19,6 +19,6 @@
 
 package org.wso2.carbon.device.mgt.common.spi;
 
-public interface DeviceMgtService extends DeviceManager,AppManager {
+public interface DeviceMgtService extends DeviceManager, AppManager {
 
 }

components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/DeviceManagementServiceProviderImpl.java

@@ -378,9 +378,10 @@ public class DeviceManagementServiceProviderImpl implements DeviceManagementServ
     }
 
     @Override
-    public boolean updateDeviceInfo(Device device) throws DeviceManagementException {
-        DeviceManager dms = this.getPluginRepository().getDeviceManagementProvider(device.getType());
-        return dms.updateDeviceInfo(device);
+    public boolean updateDeviceInfo(DeviceIdentifier deviceIdentifier, Device device) throws DeviceManagementException {
+        DeviceManager dms =
+                this.getPluginRepository().getDeviceManagementProvider(device.getType());
+        return dms.updateDeviceInfo(deviceIdentifier, device);
     }
 
     @Override

components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/operation/mgt/OperationManagerImpl.java

@@ -170,7 +170,7 @@ public class OperationManagerImpl implements OperationManager {
 
             if (device == null) {
                 throw new OperationManagementException("Device not found for given device " +
-                        "Identifier:" + deviceIdentifier.getId() + " and given type" + deviceIdentifier.getType());
+                        "Identifier:" + deviceIdentifier.getId() + " and given type:" + deviceIdentifier.getType());
             }
             operations = new ArrayList<Operation>();
             dtoOperationList = operationDAO.getOperationsByDeviceAndStatus(device.getId(),

components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/service/DeviceManagementServiceImpl.java

@@ -98,8 +98,10 @@ public class DeviceManagementServiceImpl implements DeviceManagementService {
     }
 
     @Override
-    public boolean updateDeviceInfo(Device device) throws DeviceManagementException {
-        return DeviceManagementDataHolder.getInstance().getDeviceManagementProvider().updateDeviceInfo(device);
+    public boolean updateDeviceInfo(DeviceIdentifier deviceIdentifier, Device device) throws DeviceManagementException {
+        return DeviceManagementDataHolder.getInstance().getDeviceManagementProvider().
+                updateDeviceInfo(deviceIdentifier, device);
+
     }
 
     @Override
@@ -203,4 +205,4 @@ public class DeviceManagementServiceImpl implements DeviceManagementService {
         return DeviceManagementDataHolder.getInstance().getDeviceManagementProvider()
                                          .getAllDevicesOfRole(roleName);
     }
-}
+}