From 58a31d0031bcb8ceb82ddb995b89b326210b29f1 Mon Sep 17 00:00:00 2001
From: Saad Sahibjan
Date: Tue, 25 Jun 2019 19:15:24 +0000
Subject: [PATCH 01/18] Plugin level support for deleting device permanently
---
.../device/mgt/common/DeviceManager.java | 26 ++++
.../core/dao/impl/AbstractDeviceDAOImpl.java | 136 ++++++++----------
.../DeviceManagementProviderServiceImpl.java | 36 +++--
.../device/mgt/core/TestDeviceManager.java | 5 +
.../type/template/DeviceTypeManager.java | 47 ++++++
.../template/dao/DeviceTypePluginDAOImpl.java | 48 +++++++
.../device/type/template/dao/PluginDAO.java | 19 +++
.../dao/PropertyBasedPluginDAOImpl.java | 38 +++++
.../mgt/core/mock/TypeXDeviceManager.java | 22 +++
9 files changed, 290 insertions(+), 87 deletions(-)
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.common/src/main/java/org/wso2/carbon/device/mgt/common/DeviceManager.java b/components/device-mgt/org.wso2.carbon.device.mgt.common/src/main/java/org/wso2/carbon/device/mgt/common/DeviceManager.java
index ebb225ae4f..5a2259fe40 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.common/src/main/java/org/wso2/carbon/device/mgt/common/DeviceManager.java
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.common/src/main/java/org/wso2/carbon/device/mgt/common/DeviceManager.java
@@ -14,6 +14,23 @@
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
+ *
+ *
+ * Copyright (c) 2019, Entgra (Pvt) Ltd. (http://entgra.io) All Rights Reserved.
+ *
+ * Entgra (Pvt) Ltd. licenses this file to you under the Apache License,
+ * Version 2.0 (the "License"); you may not use this file except
+ * in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
*/
package org.wso2.carbon.device.mgt.common;
@@ -79,6 +96,15 @@ public interface DeviceManager {
*/
boolean disenrollDevice(DeviceIdentifier deviceId) throws DeviceManagementException;
+ /**
+ * Method to delete a particular device from CDM.
+ *
+ * @param deviceId Fully qualified device identifier
+ * @return A boolean indicating the status of the operation.
+ * @throws DeviceManagementException If some unusual behaviour is observed while deleting a device
+ */
+ boolean deleteDevice(DeviceIdentifier deviceId, Device device) throws DeviceManagementException;
+
/**
* Method to retrieve the status of the registration process of a particular device.
*
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/impl/AbstractDeviceDAOImpl.java b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/impl/AbstractDeviceDAOImpl.java
index aa07aba8b4..866b230ed2 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/impl/AbstractDeviceDAOImpl.java
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/impl/AbstractDeviceDAOImpl.java
@@ -1409,91 +1409,97 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
}
public void deleteDevice(DeviceIdentifier deviceIdentifier, int tenantId) throws DeviceManagementDAOException {
+ String deviceIdentifierId = deviceIdentifier.getId();
+ String deviceType = deviceIdentifier.getType();
Connection conn;
try {
conn = this.getConnection();
int deviceId = getDeviceId(conn, deviceIdentifier, tenantId);
if (deviceId == -1) {
- String msg = "Device " + deviceIdentifier.getId() + " of type " + deviceIdentifier.getType() +
- " is not found";
+ String msg = "Device " + deviceIdentifierId + " of type " + deviceType + " is not found";
log.error(msg);
throw new DeviceManagementDAOException(msg);
} else {
- int enrollmentId = getEnrollmentId(conn, deviceId, tenantId);
- if (enrollmentId == -1) {
- String msg = "Enrollment not found for the device " + deviceIdentifier.getId() + " of type " +
- deviceIdentifier.getType();
+ List enrollmentIds = getEnrollmentIds(conn, deviceId, tenantId);
+ if (enrollmentIds == null || enrollmentIds.isEmpty()) {
+ String msg = "Enrollments not found for the device " + deviceIdentifierId + " of type "
+ + deviceType;
log.error(msg);
throw new DeviceManagementDAOException(msg);
} else {
removeDeviceDetail(conn, deviceId);
if (log.isDebugEnabled()) {
- log.debug("Successfully removed device detail data");
+ log.debug("Successfully removed device detail data of device " + deviceIdentifierId
+ + " of type " + deviceType);
}
removeDeviceLocation(conn, deviceId);
if (log.isDebugEnabled()) {
- log.debug("Successfully removed device location data");
+ log.debug("Successfully removed device location data of device " + deviceIdentifierId
+ + " of type " + deviceType);
}
removeDeviceInfo(conn, deviceId);
if (log.isDebugEnabled()) {
- log.debug("Successfully removed device info data");
+ log.debug("Successfully removed device info data of device " + deviceIdentifierId
+ + " of type " + deviceType);
}
removeDeviceNotification(conn, deviceId);
if (log.isDebugEnabled()) {
- log.debug("Successfully removed device notification data");
+ log.debug("Successfully removed device notification data of device " + deviceIdentifierId
+ + " of type " + deviceType);
}
removeDeviceApplicationMapping(conn, deviceId);
if (log.isDebugEnabled()) {
- log.debug("Successfully removed device application mapping data");
+ log.debug("Successfully removed device application mapping data of device "
+ + deviceIdentifierId + " of type " + deviceType);
}
removeDevicePolicyApplied(conn, deviceId);
if (log.isDebugEnabled()) {
- log.debug("Successfully removed device applied policy data");
+ log.debug("Successfully removed device applied policy data of device " + deviceIdentifierId
+ + " of type " + deviceType);
}
removeDevicePolicy(conn, deviceId);
if (log.isDebugEnabled()) {
- log.debug("Successfully removed device policy data");
+ log.debug("Successfully removed device policy data of device " + deviceIdentifierId
+ + " of type " + deviceType);
}
- removeEnrollmentDeviceDetail(conn, enrollmentId);
if (log.isDebugEnabled()) {
- log.debug("Successfully removed enrollment device detail data");
+ log.debug("Starting to remove " + enrollmentIds.size() + " enrollment data of device "
+ + deviceIdentifierId + " of type " + deviceType);
}
- removeEnrollmentDeviceLocation(conn, enrollmentId);
- if (log.isDebugEnabled()) {
- log.debug("Successfully removed enrollment device location data");
- }
- removeEnrollmentDeviceInfo(conn, enrollmentId);
- if (log.isDebugEnabled()) {
- log.debug("Successfully removed enrollment device info data");
- }
- removeEnrollmentDeviceApplicationMapping(conn, enrollmentId);
- if (log.isDebugEnabled()) {
- log.debug("Successfully removed enrollment device application mapping data");
- }
- removeDeviceOperationResponse(conn, enrollmentId);
- if (log.isDebugEnabled()) {
- log.debug("Successfully removed device operation response data");
+ for (Integer enrollmentId : enrollmentIds) {
+ removeEnrollmentDeviceDetail(conn, enrollmentId);
+ removeEnrollmentDeviceLocation(conn, enrollmentId);
+ removeEnrollmentDeviceInfo(conn, enrollmentId);
+ removeEnrollmentDeviceApplicationMapping(conn, enrollmentId);
+ removeDeviceOperationResponse(conn, enrollmentId);
+ removeEnrollmentOperationMapping(conn, enrollmentId);
}
- removeEnrollmentOperationMapping(conn, enrollmentId);
if (log.isDebugEnabled()) {
- log.debug("Successfully removed enrollment operation mapping data");
+ log.debug("Successfully removed enrollment device details, enrollment device location, " +
+ "enrollment device info, enrollment device application mapping, " +
+ "enrollment device operation response, enrollment operation mapping data of device "
+ + deviceIdentifierId + " of type " + deviceType);
}
removeDeviceEnrollment(conn, deviceId);
if (log.isDebugEnabled()) {
- log.debug("Successfully removed device enrollment data");
+ log.debug("Successfully removed device enrollment data of device " + deviceIdentifierId
+ + " of type " + deviceType);
}
removeDeviceGroupMapping(conn, deviceId);
if (log.isDebugEnabled()) {
- log.debug("Successfully removed device group mapping data");
+ log.debug("Successfully removed device group mapping data of device " + deviceIdentifierId
+ + " of type " + deviceType);
}
removeDevice(conn, deviceId);
if (log.isDebugEnabled()) {
- log.debug("Successfully permanently deleted the device");
+ log.debug("Successfully permanently deleted the device of device " + deviceIdentifierId
+ + " of type " + deviceType);
}
}
}
} catch (SQLException e) {
- throw new DeviceManagementDAOException("Error occurred while deleting the device", e);
+ throw new DeviceManagementDAOException("Error occurred while deleting the device " + deviceIdentifierId
+ + " of type " + deviceType, e);
}
}
@@ -1519,30 +1525,29 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
return deviceId;
}
- private int getEnrollmentId(Connection conn, int deviceId, int tenantId) throws DeviceManagementDAOException {
+ private List getEnrollmentIds(Connection conn, int deviceId, int tenantId) throws DeviceManagementDAOException {
PreparedStatement stmt = null;
ResultSet rs = null;
- int enrollmentId = -1;
+ List enrollmentIds = new ArrayList<>();
try {
String sql = "SELECT ID FROM DM_ENROLMENT WHERE DEVICE_ID = ? AND TENANT_ID = ?";
stmt = conn.prepareStatement(sql);
stmt.setInt(1, deviceId);
stmt.setInt(2, tenantId);
rs = stmt.executeQuery();
- if (rs.next()) {
- enrollmentId = rs.getInt("ID");
+ while (rs.next()) {
+ enrollmentIds.add(rs.getInt("ID"));
}
} catch (SQLException e) {
throw new DeviceManagementDAOException("Error occurred while retrieving enrollment id of the device", e);
} finally {
DeviceManagementDAOUtil.cleanupResources(stmt, rs);
}
- return enrollmentId;
+ return enrollmentIds;
}
private void removeDeviceDetail(Connection conn, int deviceId) throws DeviceManagementDAOException {
PreparedStatement stmt = null;
- ResultSet rs = null;
try {
String sql = "DELETE FROM DM_DEVICE_DETAIL WHERE DEVICE_ID = ?";
stmt = conn.prepareStatement(sql);
@@ -1551,13 +1556,12 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
} catch (SQLException e) {
throw new DeviceManagementDAOException("Error occurred while removing device detail", e);
} finally {
- DeviceManagementDAOUtil.cleanupResources(stmt, rs);
+ DeviceManagementDAOUtil.cleanupResources(stmt, null);
}
}
private void removeDeviceLocation(Connection conn, int deviceId) throws DeviceManagementDAOException {
PreparedStatement stmt = null;
- ResultSet rs = null;
try {
String sql = "DELETE FROM DM_DEVICE_LOCATION WHERE DEVICE_ID = ?";
stmt = conn.prepareStatement(sql);
@@ -1566,13 +1570,12 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
} catch (SQLException e) {
throw new DeviceManagementDAOException("Error occurred while removing device location", e);
} finally {
- DeviceManagementDAOUtil.cleanupResources(stmt, rs);
+ DeviceManagementDAOUtil.cleanupResources(stmt, null);
}
}
private void removeDeviceInfo(Connection conn, int deviceId) throws DeviceManagementDAOException {
PreparedStatement stmt = null;
- ResultSet rs = null;
try {
String sql = "DELETE FROM DM_DEVICE_INFO WHERE DEVICE_ID = ?";
stmt = conn.prepareStatement(sql);
@@ -1581,13 +1584,12 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
} catch (SQLException e) {
throw new DeviceManagementDAOException("Error occurred while removing device info", e);
} finally {
- DeviceManagementDAOUtil.cleanupResources(stmt, rs);
+ DeviceManagementDAOUtil.cleanupResources(stmt, null);
}
}
private void removeDeviceNotification(Connection conn, int deviceId) throws DeviceManagementDAOException {
PreparedStatement stmt = null;
- ResultSet rs = null;
try {
String sql = "DELETE FROM DM_NOTIFICATION WHERE DEVICE_ID = ?";
stmt = conn.prepareStatement(sql);
@@ -1596,13 +1598,12 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
} catch (SQLException e) {
throw new DeviceManagementDAOException("Error occurred while removing device notification", e);
} finally {
- DeviceManagementDAOUtil.cleanupResources(stmt, rs);
+ DeviceManagementDAOUtil.cleanupResources(stmt, null);
}
}
private void removeDeviceApplicationMapping(Connection conn, int deviceId) throws DeviceManagementDAOException {
PreparedStatement stmt = null;
- ResultSet rs = null;
try {
String sql = "DELETE FROM DM_DEVICE_APPLICATION_MAPPING WHERE DEVICE_ID = ?";
stmt = conn.prepareStatement(sql);
@@ -1611,13 +1612,12 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
} catch (SQLException e) {
throw new DeviceManagementDAOException("Error occurred while removing device application mapping", e);
} finally {
- DeviceManagementDAOUtil.cleanupResources(stmt, rs);
+ DeviceManagementDAOUtil.cleanupResources(stmt, null);
}
}
private void removeDevicePolicyApplied(Connection conn, int deviceId) throws DeviceManagementDAOException {
PreparedStatement stmt = null;
- ResultSet rs = null;
try {
String sql = "DELETE FROM DM_DEVICE_POLICY_APPLIED WHERE DEVICE_ID = ?";
stmt = conn.prepareStatement(sql);
@@ -1626,13 +1626,12 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
} catch (SQLException e) {
throw new DeviceManagementDAOException("Error occurred while removing device policy applied", e);
} finally {
- DeviceManagementDAOUtil.cleanupResources(stmt, rs);
+ DeviceManagementDAOUtil.cleanupResources(stmt, null);
}
}
private void removeDevicePolicy(Connection conn, int deviceId) throws DeviceManagementDAOException {
PreparedStatement stmt = null;
- ResultSet rs = null;
try {
String sql = "DELETE FROM DM_DEVICE_POLICY WHERE DEVICE_ID = ?";
stmt = conn.prepareStatement(sql);
@@ -1641,13 +1640,12 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
} catch (SQLException e) {
throw new DeviceManagementDAOException("Error occurred while removing device policy", e);
} finally {
- DeviceManagementDAOUtil.cleanupResources(stmt, rs);
+ DeviceManagementDAOUtil.cleanupResources(stmt, null);
}
}
private void removeEnrollmentDeviceDetail(Connection conn, int enrollmentId) throws DeviceManagementDAOException {
PreparedStatement stmt = null;
- ResultSet rs = null;
try {
String sql = "DELETE FROM DM_DEVICE_DETAIL WHERE ENROLMENT_ID = ?";
stmt = conn.prepareStatement(sql);
@@ -1656,13 +1654,12 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
} catch (SQLException e) {
throw new DeviceManagementDAOException("Error occurred while removing enrollment device detail", e);
} finally {
- DeviceManagementDAOUtil.cleanupResources(stmt, rs);
+ DeviceManagementDAOUtil.cleanupResources(stmt, null);
}
}
private void removeEnrollmentDeviceLocation(Connection conn, int enrollmentId) throws DeviceManagementDAOException {
PreparedStatement stmt = null;
- ResultSet rs = null;
try {
String sql = "DELETE FROM DM_DEVICE_LOCATION WHERE ENROLMENT_ID = ?";
stmt = conn.prepareStatement(sql);
@@ -1671,13 +1668,12 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
} catch (SQLException e) {
throw new DeviceManagementDAOException("Error occurred while removing enrollment device location", e);
} finally {
- DeviceManagementDAOUtil.cleanupResources(stmt, rs);
+ DeviceManagementDAOUtil.cleanupResources(stmt, null);
}
}
private void removeEnrollmentDeviceInfo(Connection conn, int enrollmentId) throws DeviceManagementDAOException {
PreparedStatement stmt = null;
- ResultSet rs = null;
try {
String sql = "DELETE FROM DM_DEVICE_INFO WHERE ENROLMENT_ID = ?";
stmt = conn.prepareStatement(sql);
@@ -1686,14 +1682,13 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
} catch (SQLException e) {
throw new DeviceManagementDAOException("Error occurred while removing enrollment device info", e);
} finally {
- DeviceManagementDAOUtil.cleanupResources(stmt, rs);
+ DeviceManagementDAOUtil.cleanupResources(stmt, null);
}
}
private void removeEnrollmentDeviceApplicationMapping(Connection conn, int enrollmentId)
throws DeviceManagementDAOException {
PreparedStatement stmt = null;
- ResultSet rs = null;
try {
String sql = "DELETE FROM DM_DEVICE_APPLICATION_MAPPING WHERE ENROLMENT_ID = ?";
stmt = conn.prepareStatement(sql);
@@ -1703,13 +1698,12 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
throw new DeviceManagementDAOException("Error occurred while removing enrollment device application " +
"mapping", e);
} finally {
- DeviceManagementDAOUtil.cleanupResources(stmt, rs);
+ DeviceManagementDAOUtil.cleanupResources(stmt, null);
}
}
private void removeDeviceOperationResponse(Connection conn, int enrollmentId) throws DeviceManagementDAOException {
PreparedStatement stmt = null;
- ResultSet rs = null;
try {
String sql = "DELETE FROM DM_DEVICE_OPERATION_RESPONSE WHERE ENROLMENT_ID = ?";
stmt = conn.prepareStatement(sql);
@@ -1718,14 +1712,13 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
} catch (SQLException e) {
throw new DeviceManagementDAOException("Error occurred while removing device operation response", e);
} finally {
- DeviceManagementDAOUtil.cleanupResources(stmt, rs);
+ DeviceManagementDAOUtil.cleanupResources(stmt, null);
}
}
private void removeEnrollmentOperationMapping(Connection conn, int enrollmentId)
throws DeviceManagementDAOException {
PreparedStatement stmt = null;
- ResultSet rs = null;
try {
String sql = "DELETE FROM DM_ENROLMENT_OP_MAPPING WHERE ENROLMENT_ID = ?";
stmt = conn.prepareStatement(sql);
@@ -1734,13 +1727,12 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
} catch (SQLException e) {
throw new DeviceManagementDAOException("Error occurred while removing enrollment operation mapping", e);
} finally {
- DeviceManagementDAOUtil.cleanupResources(stmt, rs);
+ DeviceManagementDAOUtil.cleanupResources(stmt, null);
}
}
private void removeDeviceEnrollment(Connection conn, int deviceId) throws DeviceManagementDAOException {
PreparedStatement stmt = null;
- ResultSet rs = null;
try {
String sql = "DELETE FROM DM_ENROLMENT WHERE DEVICE_ID = ?";
stmt = conn.prepareStatement(sql);
@@ -1749,13 +1741,12 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
} catch (SQLException e) {
throw new DeviceManagementDAOException("Error occurred while removing device enrollment", e);
} finally {
- DeviceManagementDAOUtil.cleanupResources(stmt, rs);
+ DeviceManagementDAOUtil.cleanupResources(stmt, null);
}
}
private void removeDeviceGroupMapping(Connection conn, int deviceId) throws DeviceManagementDAOException {
PreparedStatement stmt = null;
- ResultSet rs = null;
try {
String sql = "DELETE FROM DM_DEVICE_GROUP_MAP WHERE DEVICE_ID = ?";
stmt = conn.prepareStatement(sql);
@@ -1764,13 +1755,12 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
} catch (SQLException e) {
throw new DeviceManagementDAOException("Error occurred while removing device group mapping", e);
} finally {
- DeviceManagementDAOUtil.cleanupResources(stmt, rs);
+ DeviceManagementDAOUtil.cleanupResources(stmt, null);
}
}
private void removeDevice(Connection conn, int deviceId) throws DeviceManagementDAOException {
PreparedStatement stmt = null;
- ResultSet rs = null;
try {
String sql = "DELETE FROM DM_DEVICE WHERE ID = ?";
stmt = conn.prepareStatement(sql);
@@ -1779,7 +1769,7 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
} catch (SQLException e) {
throw new DeviceManagementDAOException("Error occurred while removing device", e);
} finally {
- DeviceManagementDAOUtil.cleanupResources(stmt, rs);
+ DeviceManagementDAOUtil.cleanupResources(stmt, null);
}
}
}
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/service/DeviceManagementProviderServiceImpl.java b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/service/DeviceManagementProviderServiceImpl.java
index 621cc966e3..76e86420d3 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/service/DeviceManagementProviderServiceImpl.java
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/service/DeviceManagementProviderServiceImpl.java
@@ -14,23 +14,23 @@
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
- */
-/*
- * Copyright (c) 2019, Entgra (pvt) Ltd. (http://entgra.io) All Rights Reserved.
*
- * Entgra (pvt) Ltd. licenses this file to you under the Apache License,
- * Version 2.0 (the "License"); you may not use this file except
- * in compliance with the License.
- * You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * Copyright (c) 2019, Entgra (Pvt) Ltd. (http://entgra.io) All Rights Reserved.
+ *
+ * Entgra (Pvt) Ltd. licenses this file to you under the Apache License,
+ * Version 2.0 (the "License"); you may not use this file except
+ * in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
*
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
*/
package org.wso2.carbon.device.mgt.core.service;
@@ -550,6 +550,14 @@ public class DeviceManagementProviderServiceImpl implements DeviceManagementProv
try {
DeviceManagementDAOFactory.beginTransaction();
deviceDAO.deleteDevice(deviceId, tenantId);
+ try {
+ deviceManager.deleteDevice(deviceId, device);
+ } catch (DeviceManagementException e) {
+ String msg = "Error occurred while permanently deleting '" + deviceId.getType() +
+ "' device with the identifier '" + deviceId.getId() + "' in plugin.";
+ log.error(msg, e);
+ throw new DeviceManagementDAOException(msg, e);
+ }
DeviceManagementDAOFactory.commitTransaction();
this.removeDeviceFromCache(deviceId);
} catch (DeviceManagementDAOException e) {
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/test/java/org/wso2/carbon/device/mgt/core/TestDeviceManager.java b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/test/java/org/wso2/carbon/device/mgt/core/TestDeviceManager.java
index 47a01c9e59..8675858f8b 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/test/java/org/wso2/carbon/device/mgt/core/TestDeviceManager.java
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/test/java/org/wso2/carbon/device/mgt/core/TestDeviceManager.java
@@ -59,6 +59,11 @@ public class TestDeviceManager implements DeviceManager {
return true;
}
+ @Override
+ public boolean deleteDevice(DeviceIdentifier deviceId, Device device) throws DeviceManagementException {
+ return true;
+ }
+
@Override
public boolean isEnrolled(DeviceIdentifier deviceId) throws DeviceManagementException {
return true;
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/DeviceTypeManager.java b/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/DeviceTypeManager.java
index b84d165814..948e5a5ff6 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/DeviceTypeManager.java
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/DeviceTypeManager.java
@@ -15,6 +15,22 @@
* specific language governing permissions and limitations
* under the License.
*
+ *
+ * Copyright (c) 2019, Entgra (Pvt) Ltd. (http://entgra.io) All Rights Reserved.
+ *
+ * Entgra (Pvt) Ltd. licenses this file to you under the Apache License,
+ * Version 2.0 (the "License"); you may not use this file except
+ * in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
*/
package org.wso2.carbon.device.mgt.extensions.device.type.template;
@@ -568,4 +584,35 @@ public class DeviceTypeManager implements DeviceManager {
return null;
}
+ @Override
+ public boolean deleteDevice(DeviceIdentifier deviceIdentifier, Device device) throws DeviceManagementException {
+ if (propertiesExist) {
+ boolean status;
+ Device existingDevice = this.getDevice(deviceIdentifier);
+ if (existingDevice == null) {
+ return false;
+ }
+ try {
+ if (log.isDebugEnabled()) {
+ log.debug("Deleting the details of " + deviceType + " device : " + device.getDeviceIdentifier());
+ }
+ deviceTypePluginDAOManager.getDeviceTypeDAOHandler().beginTransaction();
+ status = deviceTypePluginDAOManager.getDeviceDAO().deleteDevice(existingDevice);
+ deviceTypePluginDAOManager.getDeviceTypeDAOHandler().commitTransaction();
+ } catch (DeviceTypeMgtPluginException e) {
+ try {
+ deviceTypePluginDAOManager.getDeviceTypeDAOHandler().rollbackTransaction();
+ } catch (DeviceTypeMgtPluginException e1) {
+ log.warn("Error occurred while roll back the delete device info transaction : '" +
+ device.toString() + "'", e1);
+ }
+ throw new DeviceManagementException(
+ "Error occurred while deleting the " + deviceType + " device: '" +
+ device.getDeviceIdentifier() + "'", e);
+ }
+ return status;
+ }
+ return true;
+ }
+
}
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/dao/DeviceTypePluginDAOImpl.java b/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/dao/DeviceTypePluginDAOImpl.java
index 755cb0397b..00c9e4ff40 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/dao/DeviceTypePluginDAOImpl.java
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/dao/DeviceTypePluginDAOImpl.java
@@ -14,6 +14,23 @@
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
+ *
+ *
+ * Copyright (c) 2019, Entgra (Pvt) Ltd. (http://entgra.io) All Rights Reserved.
+ *
+ * Entgra (Pvt) Ltd. licenses this file to you under the Apache License,
+ * Version 2.0 (the "License"); you may not use this file except
+ * in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
*/
package org.wso2.carbon.device.mgt.extensions.device.type.template.dao;
@@ -45,6 +62,7 @@ public class DeviceTypePluginDAOImpl implements PluginDAO {
private String createDBqueryForAddDevice;
private String updateDBQueryForUpdateDevice;
private String selectDBQueryToGetAllDevice;
+ private String deleteDBQueryForDeleteDevice;
public DeviceTypePluginDAOImpl(DeviceDAODefinition deviceDAODefinition,
DeviceTypeDAOHandler deviceTypeDAOHandler) {
@@ -196,6 +214,33 @@ public class DeviceTypePluginDAOImpl implements PluginDAO {
}
}
+ @Override
+ public boolean deleteDevice(Device device) throws DeviceTypeMgtPluginException {
+ boolean status = false;
+ Connection conn;
+ PreparedStatement stmt = null;
+ try {
+ conn = deviceTypeDAOHandler.getConnection();
+ stmt = conn.prepareStatement(deleteDBQueryForDeleteDevice);
+ stmt.setString(1, device.getDeviceIdentifier());
+ int rows = stmt.executeUpdate();
+ if (rows > 0) {
+ status = true;
+ if (log.isDebugEnabled()) {
+ log.debug("Device " + device.getDeviceIdentifier() + " data has been deleted.");
+ }
+ }
+ } catch (SQLException e) {
+ String msg = "Error occurred while deleting the device '" + device.getDeviceIdentifier() + "' data in "
+ + deviceDAODefinition.getDeviceTableName();
+ log.error(msg, e);
+ throw new DeviceTypeMgtPluginException(msg, e);
+ } finally {
+ DeviceTypeUtils.cleanupResources(stmt, null);
+ }
+ return status;
+ }
+
private String getDeviceTableColumnNames() {
return StringUtils.join(deviceDAODefinition.getColumnNames(), ", ");
}
@@ -239,5 +284,8 @@ public class DeviceTypePluginDAOImpl implements PluginDAO {
selectDBQueryToGetAllDevice =
"SELECT " + getDeviceTableColumnNames() + "," + deviceDAODefinition.getPrimaryKey() + " FROM "
+ deviceDAODefinition.getDeviceTableName();
+
+ deleteDBQueryForDeleteDevice = "DELETE FROM " + deviceDAODefinition.getDeviceTableName() + " WHERE "
+ + deviceDAODefinition.getPrimaryKey() + " = ?";
}
}
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/dao/PluginDAO.java b/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/dao/PluginDAO.java
index 47606fe6a6..bd1747d454 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/dao/PluginDAO.java
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/dao/PluginDAO.java
@@ -14,6 +14,23 @@
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
+ *
+ *
+ * Copyright (c) 2019, Entgra (Pvt) Ltd. (http://entgra.io) All Rights Reserved.
+ *
+ * Entgra (Pvt) Ltd. licenses this file to you under the Apache License,
+ * Version 2.0 (the "License"); you may not use this file except
+ * in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
*/
package org.wso2.carbon.device.mgt.extensions.device.type.template.dao;
@@ -31,4 +48,6 @@ public interface PluginDAO {
boolean updateDevice(Device device) throws DeviceTypeMgtPluginException;
List getAllDevices() throws DeviceTypeMgtPluginException;
+
+ boolean deleteDevice(Device device) throws DeviceTypeMgtPluginException;
}
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/dao/PropertyBasedPluginDAOImpl.java b/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/dao/PropertyBasedPluginDAOImpl.java
index ac90fb1052..1c38884ca7 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/dao/PropertyBasedPluginDAOImpl.java
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/dao/PropertyBasedPluginDAOImpl.java
@@ -14,6 +14,23 @@
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
+ *
+ *
+ * Copyright (c) 2019, Entgra (Pvt) Ltd. (http://entgra.io) All Rights Reserved.
+ *
+ * Entgra (Pvt) Ltd. licenses this file to you under the Apache License,
+ * Version 2.0 (the "License"); you may not use this file except
+ * in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
*/
package org.wso2.carbon.device.mgt.extensions.device.type.template.dao;
@@ -201,6 +218,27 @@ public class PropertyBasedPluginDAOImpl implements PluginDAO {
}
}
+ @Override
+ public boolean deleteDevice(Device device) throws DeviceTypeMgtPluginException {
+ Connection conn;
+ PreparedStatement stmt = null;
+ try {
+ conn = deviceTypeDAOHandler.getConnection();
+ stmt = conn.prepareStatement("DELETE FROM DM_DEVICE_PROPERTIES WHERE DEVICE_IDENTIFICATION = ?");
+ stmt.setString(1, device.getDeviceIdentifier());
+ stmt.executeUpdate();
+ return true;
+ } catch (SQLException e) {
+ String msg = "Error occurred while deleting the device '" + device.getDeviceIdentifier() + "' data on"
+ + deviceType;
+ log.error(msg, e);
+ throw new DeviceTypeMgtPluginException(msg, e);
+ } finally {
+ DeviceTypeUtils.cleanupResources(stmt, null);
+ }
+ }
+
+
private String getPropertyValue(List properties, String propertyName) {
for (Device.Property property : properties) {
if (property.getName() != null && property.getName().equals(propertyName)) {
diff --git a/components/policy-mgt/org.wso2.carbon.policy.mgt.core/src/test/java/org/wso2/carbon/policy/mgt/core/mock/TypeXDeviceManager.java b/components/policy-mgt/org.wso2.carbon.policy.mgt.core/src/test/java/org/wso2/carbon/policy/mgt/core/mock/TypeXDeviceManager.java
index d9477b5119..f303b15c7f 100644
--- a/components/policy-mgt/org.wso2.carbon.policy.mgt.core/src/test/java/org/wso2/carbon/policy/mgt/core/mock/TypeXDeviceManager.java
+++ b/components/policy-mgt/org.wso2.carbon.policy.mgt.core/src/test/java/org/wso2/carbon/policy/mgt/core/mock/TypeXDeviceManager.java
@@ -14,6 +14,23 @@
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
+ *
+ *
+ * Copyright (c) 2019, Entgra (Pvt) Ltd. (http://entgra.io) All Rights Reserved.
+ *
+ * Entgra (Pvt) Ltd. licenses this file to you under the Apache License,
+ * Version 2.0 (the "License"); you may not use this file except
+ * in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
*/
package org.wso2.carbon.policy.mgt.core.mock;
@@ -61,6 +78,11 @@ public class TypeXDeviceManager implements DeviceManager {
return false;
}
+ @Override
+ public boolean deleteDevice(DeviceIdentifier deviceId, Device device) throws DeviceManagementException {
+ return false;
+ }
+
@Override
public boolean isEnrolled(DeviceIdentifier deviceId) throws DeviceManagementException {
return false;
From 33ffa23efc155329d1ca7252ff684194b7b54f1a Mon Sep 17 00:00:00 2001
From: Ace
Date: Wed, 26 Jun 2019 13:24:00 +0530
Subject: [PATCH 02/18] updating references to 3.5.0 release to 3.6.0
---
.../cdmf.page.cookie-policy/cookie-policy.hbs | 52 ++++++++---------
.../privacy-policy.hbs | 58 +++++++++----------
.../app/units/uuf.unit.footer/footer.hbs | 4 +-
3 files changed, 57 insertions(+), 57 deletions(-)
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.cookie-policy/cookie-policy.hbs b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.cookie-policy/cookie-policy.hbs
index 9a2df65f5e..cc48c8bad1 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.cookie-policy/cookie-policy.hbs
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.cookie-policy/cookie-policy.hbs
@@ -26,14 +26,14 @@
About Entgra IoT Server
-
Entgra IoT Server 3.5.0 is a complete solution that enables device manufacturers and enterprises to
+
Entgra IoT Server 3.6.0 is a complete solution that enables device manufacturers and enterprises to
connect and manage their devices, build apps, manage events, secure devices and data, and visualize
sensor data in a scalable manner.
It also offers a complete and secure Enterprise Mobility Management (EMM/MDM) solution that aims to
address mobile computing challenges faced by enterprises today. Supporting iOS, Android, and Windows
devices, it helps organizations deal with both Corporate Owned, Personally Enabled (COPE) and
employee-owned devices with the Bring Your Own Device (BYOD) concept.
-
Entgra IoT Server 3.5.0 comes with advanced analytics, enabling users to analyze speed, proximity, and
+
Entgra IoT Server 3.6.0 comes with advanced analytics, enabling users to analyze speed, proximity, and
geo-fencing information of devices including details of those in motion and stationary state.
Cookie Policy
@@ -45,12 +45,12 @@
apps remember things about you. Other technologies, including Web storage and identifiers associated
with your device, may be used for similar purposes. In this policy, we use the term “cookies” to
discuss all of these technologies.
-
How does Entgra IoT Server 3.5.0 process cookies?
-
Entgra IoT Server 3.5.0 uses cookies to store and retrieve information on your browser. This
+
How does Entgra IoT Server 3.6.0 process cookies?
+
Entgra IoT Server 3.6.0 uses cookies to store and retrieve information on your browser. This
information is used to provide a better user experience. Some cookies serve the purpose of allowing a
user to log in to the system, maintain sessions, and keep track of activities within the login
session.
-
Some cookies in Entgra IoT Server 3.5.0 are used to personally identify you. However, the cookie
+
Some cookies in Entgra IoT Server 3.6.0 are used to personally identify you. However, the cookie
lifetime ends once your session ends, i.e., after you log-out, or after the session expiry time has
elapsed.
Some cookies are simply used to give you a more personalised web experience, and these cannot be used
@@ -58,42 +58,42 @@
This Cookie Policy is part of the IoT Server Privacy Policy.
What does Entgra IoT Server 3.0.0 use cookies for?
-
Cookies are used for two purposes in Entgra IoT Server 3.5.0.
+
Cookies are used for two purposes in Entgra IoT Server 3.6.0.
To identify you and provide security
To provide a satisfying user experience.
Preferences
-
Entgra IoT Server 3.5.0 uses cookies to remember your settings and preferences and to auto-fill the
+
Entgra IoT Server 3.6.0 uses cookies to remember your settings and preferences and to auto-fill the
fields to make your interactions with the site easier.
These cookies can not be used to personally identify you.
Security
-
Entgra IoT Server 3.5.0 uses selected cookies to identify and prevent security risks. For example,
- Entgra IoT Server 3.5.0 may use cookies to store your session information to prevent others from
+
Entgra IoT Server 3.6.0 uses selected cookies to identify and prevent security risks. For example,
+ Entgra IoT Server 3.6.0 may use cookies to store your session information to prevent others from
changing your password without your username and password.
-
Entgra IoT Server 3.5.0 uses session cookie to maintain your active session.
-
Entgra IoT Server 3.5.0 may use a temporary cookie when performing multi-factor authentication and
+
Entgra IoT Server 3.6.0 uses session cookie to maintain your active session.
+
Entgra IoT Server 3.6.0 may use a temporary cookie when performing multi-factor authentication and
federated authentication.
-
Entgra IoT Server 3.5.0 may use permanent cookies to detect the devices you have logged in
+
Entgra IoT Server 3.6.0 may use permanent cookies to detect the devices you have logged in
previously. This is to to calculate the risk level associated with your current login
attempt. Using these cookies protects you and your account from possible attacks.
Performance
-
Entgra IoT Server 3.5.0 may use cookies to allow Remember Me functionalities.
+
Entgra IoT Server 3.6.0 may use cookies to allow Remember Me functionalities.
Analytics
-
Entgra IoT Server 3.5.0 as a product does not use cookies for analytical purposes.
+
Entgra IoT Server 3.6.0 as a product does not use cookies for analytical purposes.
Third party cookies
-
Using Entgra IoT Server 3.5.0 may cause third-party cookie to be set in your browser. Entgra IoT Server
+
Using Entgra IoT Server 3.6.0 may cause third-party cookie to be set in your browser. Entgra IoT Server
3.5.0 has no control over how any of them operate. The third-party cookies that maybe set
include:
-
Any social login sites. For example, third-party cookies may be set when Entgra IoT Server 3.5.0
+
Any social login sites. For example, third-party cookies may be set when Entgra IoT Server 3.6.0
is configured to use “social” or “federated” login, and you opt to login with your “Social
Account”.
@@ -101,11 +101,11 @@
Entgra strongly advises you to refer the respective cookie policies of such sites carefully as Entgra has
no knowledge or use on these cookies.
-
What type of cookies does Entgra IoT Server 3.5.0 use?
-
Entgra IoT Server 3.5.0 uses persistent cookies and session cookies. A persistent cookie helps Entgra IS
+
What type of cookies does Entgra IoT Server 3.6.0 use?
+
Entgra IoT Server 3.6.0 uses persistent cookies and session cookies. A persistent cookie helps Entgra IS
3.5.0 to recognize you as an existing user so that it is easier to return to Entgra or interact with
Entgra IS 3.5.0 without signing in again. After you sign in, a persistent cookie stays in your browser
- and will be read by Entgra IoT Server 3.5.0 when you return to Entgra IoT Server 3.5.0.
+ and will be read by Entgra IoT Server 3.6.0 when you return to Entgra IoT Server 3.6.0.
A session cookie is a cookie that is erased when the user closes the Web browser. The session cookie
is stored in temporarily and is not retained after the browser is closed. Session cookies do not
collect information from the user’s computer.
@@ -114,9 +114,9 @@
for websites to set cookies, you may worsen your overall user experience since it will no longer be
personalized to you. It may also stop you from saving customized settings like login information.
Most likely, disabling cookies will make it unable for you to use authentication and authorization
- functionalities offered by Entgra IoT Server 3.5.0.
+ functionalities offered by Entgra IoT Server 3.6.0.
If you have any questions or concerns regarding the use of cookies, please contact the entity or
- individuals (or their data protection officer, if applicable) running this Entgra IoT Server 3.5.0
+ individuals (or their data protection officer, if applicable) running this Entgra IoT Server 3.6.0
instance.
What are the cookies used?
@@ -150,17 +150,17 @@
Disclaimer
-
This cookie policy is only for illustrative purposes of the product Entgra IoT Server 3.5.0. The
+
This cookie policy is only for illustrative purposes of the product Entgra IoT Server 3.6.0. The
content in the policy is technically correct at the time of the product shipment. The
- entity,organization or individual that runs this Entgra IoT Server 3.5.0 instance has full authority
+ entity,organization or individual that runs this Entgra IoT Server 3.6.0 instance has full authority
and responsibility with regard to the effective Cookie Policy. Entgra, its employees, partners, and
affiliates do not have access to and do not require, store, process or control any of the data,
- including personal data contained in Entgra IoT Server 3.5.0. All data, including personal data is
- controlled and processed by the entity, organization or individual running Entgra IoT Server 3.5.0.
+ including personal data contained in Entgra IoT Server 3.6.0. All data, including personal data is
+ controlled and processed by the entity, organization or individual running Entgra IoT Server 3.6.0.
Entgra, its employees partners and affiliates are not a data processor or a data controller within the
meaning of any data privacy regulations. Entgra does not provide any warranties or undertake any
responsibility or liability in connection with the lawfulness or the manner and purposes for which
- Entgra IoT Server 3.5.0 is used by such entities, organizations or persons.
+ Entgra IoT Server 3.6.0 is used by such entities, organizations or persons.
Entgra IoT Server comes with advanced analytics, enabling users to analyze speed, proximity, and
geo-fencing information of devices including details of those in motion and stationary state.
Privacy Policy
-
This policy describes how Entgra IoT Server 3.5.0 captures your personal information, the purposes of
+
This policy describes how Entgra IoT Server 3.6.0 captures your personal information, the purposes of
collection, and information about the retention of your personal information.
Please note that this policy is for reference only, and is applicable for the software as a product.
Entgra and its developers have no access to the information held within Entgra IoT Server
3.5.0.Please see the Disclaimer section for more information. Entities, organisations or individuals
- controlling the use and administration of Entgra IoT Server 3.5.0 should create their own privacy
+ controlling the use and administration of Entgra IoT Server 3.6.0 should create their own privacy
policies setting out the manner in which data is controlled or processed by the respective entity,
organisation or individual.
What is personal information?
-
Entgra IoT Server 3.5.0 considers anything related to you and by which you may be identified as your
+
Entgra IoT Server 3.6.0 considers anything related to you and by which you may be identified as your
personal information.
-
Signing in to Entgra IoT Server 3.5.0
+
Signing in to Entgra IoT Server 3.6.0
Your user name (except in cases where the user name created by your employer is under
contract)
@@ -55,7 +55,7 @@
IP address used to log in
Email address
-
Enrolling a device with Entgra IoT Server 3.5.0
+
Enrolling a device with Entgra IoT Server 3.6.0
Your device ID (e.g., phone or tablet), mobile number, IMEI number, and IMSI number
Your device’s location
@@ -64,7 +64,7 @@
memory usage
-
However, Entgra IoT Server 3.5.0 also collects the following information that is not considered
+
However, Entgra IoT Server 3.6.0 also collects the following information that is not considered
personal information, but is used only for statistical purposes. The reason for this is that
this information can not be used to track you.
@@ -74,17 +74,17 @@
Operating system and generic browser information
Collection of personal information
-
Entgra IoT Server 3.5.0 collects your information only to serve your access requirements. For example:
+
Entgra IoT Server 3.6.0 collects your information only to serve your access requirements. For example:
-
Entgra IoT Server 3.5.0 uses your IP address to detect any suspicious login attempts to your
+
Entgra IoT Server 3.6.0 uses your IP address to detect any suspicious login attempts to your
account.
-
Entgra IoT Server 3.5.0 uses attributes like your first name, last name, etc., to provide a rich
+
Entgra IoT Server 3.6.0 uses attributes like your first name, last name, etc., to provide a rich
and personalized user experience.
-
Entgra IoT Server 3.5.0 uses your security questions and answers only to allow account recovery.
+
Entgra IoT Server 3.6.0 uses your security questions and answers only to allow account recovery.
Tracking Technologies
-
Entgra IoT Server 3.5.0 collects your information by:
+
Entgra IoT Server 3.6.0 collects your information by:
Collecting information from the user profile page where you enter your personal data.
Tracking your IP address with HTTP request, HTTP headers, and TCP/IP.
@@ -95,11 +95,11 @@
Use of personal information
-
Entgra IoT Server 3.5.0 will only use your personal information for the purposes for which it was
+
Entgra IoT Server 3.6.0 will only use your personal information for the purposes for which it was
collected (or for a use identified as consistent with that purpose).
-
Entgra IoT Server 3.5.0 uses your personal information only for the following purposes.
+
Entgra IoT Server 3.6.0 uses your personal information only for the following purposes.
-
To provide you with a personalized user experience. Entgra IoT Server 3.5.0 uses your name and
+
To provide you with a personalized user experience. Entgra IoT Server 3.6.0 uses your name and
uploaded profile pictures for this purpose.
To protect your account from unauthorized access or potential hacking attempts. Entgra IoT Server
@@ -117,7 +117,7 @@
Server 3.5.0 will not keep any personal information after statistical calculations. Therefore,
the statistical report has no means of identifying an individual person.
-
Entgra IoT Server 3.5.0 may use:
+
Entgra IoT Server 3.6.0 may use:
IP Address to derive geographic information
@@ -126,28 +126,28 @@
Disclosure of personal information
-
Entgra IoT Server 3.5.0 only discloses personal information to the relevant applications (also known as
- “Service Providers”) that are registered with Entgra IoT Server 3.5.0. These applications are
+
Entgra IoT Server 3.6.0 only discloses personal information to the relevant applications (also known as
+ “Service Providers”) that are registered with Entgra IoT Server 3.6.0. These applications are
registered by the identity administrator of your entity or organization. Personal information is
disclosed only for the purposes for which it was collected (or for a use identified as consistent
with that purpose) as controlled by such Service Providers, unless you have consented otherwise or
where it is required by law.
Legal process
-
Please note that the organisation, entity or individual running Entgra IoT Server 3.5.0 may be
+
Please note that the organisation, entity or individual running Entgra IoT Server 3.6.0 may be
compelled to disclose your personal information with or without your consent when it is required by
law following due and lawful process.
Storage of personal information
Where your personal information is stored
-
Entgra IoT Server 3.5.0 stores your personal information in secured databases. Entgra IoT Server 3.5.0
+
Entgra IoT Server 3.6.0 stores your personal information in secured databases. Entgra IoT Server 3.6.0
exercises proper industry accepted security measures to protect the database where your personal
- information is held.Entgra IoT Server 3.5.0 as a product does not transfer or share your data with any
+ information is held.Entgra IoT Server 3.6.0 as a product does not transfer or share your data with any
third parties or locations.
-
Entgra IoT Server 3.5.0 may use encryption to keep your personal data with an added level of
+
Entgra IoT Server 3.6.0 may use encryption to keep your personal data with an added level of
security.
How long your personal information is retained
-
Entgra IoT Server 3.5.0 retains your personal data as long as you are an active user of our system. You
+
Entgra IoT Server 3.6.0 retains your personal data as long as you are an active user of our system. You
can update your personal data at any time using the given self-care user portals.
-
Entgra IoT Server 3.5.0 may keep hashed secrets to provide you with an added level of security. This
+
Entgra IoT Server 3.6.0 may keep hashed secrets to provide you with an added level of security. This
includes:
Current password
@@ -157,15 +157,15 @@
You can request the administrator to delete your account. The administrator is the administrator of
the tenant you are registered under, or the super-administrator if you do not use the tenant
feature.
-
Additionally, you can request to anonymize all traces of your activities that Entgra IoT Server 3.5.0
+
Additionally, you can request to anonymize all traces of your activities that Entgra IoT Server 3.6.0
may have retained in logs, databases or analytical storage.
More information
Changes to this policy
-
Upgraded versions of Entgra IoT Server 3.5.0 may contain changes to this policy. Revisions to this
+
Upgraded versions of Entgra IoT Server 3.6.0 may contain changes to this policy. Revisions to this
policy will be packaged within such upgrades and would only apply to users who choose to use upgraded
versions.
Your choices
-
If you are already have an user account within Entgra IoT Server 3.5.0 ; you have the right to
+
If you are already have an user account within Entgra IoT Server 3.6.0 ; you have the right to
deactivate your account if you find that this privacy policy is unacceptable to you.
If you do not have an account and you do not agree with our privacy policy, you can chose not to
create one.
Entgra, its employees, partners, and affiliates do not have access to and do not require, store,
- process or control any of the data, including personal data contained in Entgra IoT Server 3.5.0. All
+ process or control any of the data, including personal data contained in Entgra IoT Server 3.6.0. All
data, including personal data is controlled and processed by the entity or individual running Entgra
IoT Server 3.5.0. Entgra, its employees partners and affiliates are not a data processor or a data
controller within the meaning of any data privacy regulations. Entgra does not provide any warranties
or undertake any responsibility or liability in connection with the lawfulness or the manner and
- purposes for which Entgra IoT Server 3.5.0 is used by such entities or persons.
+ purposes for which Entgra IoT Server 3.6.0 is used by such entities or persons.
This privacy policy is for the informational purposes of the entity or persons running Entgra IoT
- Server 3.5.0 and sets out the processes and functionality contained within Entgra IoT Server 3.5.0
+ Server 3.5.0 and sets out the processes and functionality contained within Entgra IoT Server 3.6.0
regarding personal data protection. It is the responsibility of entities and persons running Entgra IoT
Server 3.5.0 to create and administer its own rules and processes governing users’ personal data,
Please note that the creation of such rules and processes may change the use, storage and disclosure
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/uuf-template-app/app/units/uuf.unit.footer/footer.hbs b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/uuf-template-app/app/units/uuf.unit.footer/footer.hbs
index 69cb55d789..bc4554d559 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/uuf-template-app/app/units/uuf.unit.footer/footer.hbs
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/uuf-template-app/app/units/uuf.unit.footer/footer.hbs
@@ -17,8 +17,8 @@
}}
{{#zone "footer"}}
{{/zone}}
\ No newline at end of file
From 192984e3c0036303bad8daedc042da6dbea84dc8 Mon Sep 17 00:00:00 2001
From: Ace
Date: Thu, 27 Jun 2019 17:03:00 +0530
Subject: [PATCH 03/18] Adding new API to search devices based on device
properties
---
.../service/api/DeviceManagementService.java | 80 +++++++++++++++++++
.../impl/DeviceManagementServiceImpl.java | 26 ++++++
.../device/mgt/common/search/PropertyMap.java | 43 ++++++++++
.../carbon/device/mgt/core/dao/DeviceDAO.java | 10 +++
.../core/dao/impl/AbstractDeviceDAOImpl.java | 63 +++++++++++++++
.../DeviceManagementProviderService.java | 10 +++
.../DeviceManagementProviderServiceImpl.java | 40 ++++++++++
.../device/type/template/dao/PluginDAO.java | 1 +
.../dao/PropertyBasedPluginDAOImpl.java | 1 -
9 files changed, 273 insertions(+), 1 deletion(-)
create mode 100644 components/device-mgt/org.wso2.carbon.device.mgt.common/src/main/java/org/wso2/carbon/device/mgt/common/search/PropertyMap.java
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/service/api/DeviceManagementService.java b/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/service/api/DeviceManagementService.java
index 96991ed2ce..4cf332c0b8 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/service/api/DeviceManagementService.java
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/service/api/DeviceManagementService.java
@@ -58,6 +58,7 @@ import org.wso2.carbon.device.mgt.common.operation.mgt.Activity;
import org.wso2.carbon.device.mgt.common.operation.mgt.Operation;
import org.wso2.carbon.device.mgt.common.policy.mgt.Policy;
import org.wso2.carbon.device.mgt.common.policy.mgt.monitor.NonComplianceData;
+import org.wso2.carbon.device.mgt.common.search.PropertyMap;
import org.wso2.carbon.device.mgt.common.search.SearchContext;
import org.wso2.carbon.device.mgt.jaxrs.beans.DeviceList;
import org.wso2.carbon.device.mgt.jaxrs.beans.ErrorResponse;
@@ -79,6 +80,7 @@ import javax.ws.rs.QueryParam;
import javax.ws.rs.core.MediaType;
import javax.ws.rs.core.Response;
import java.util.List;
+import java.util.Map;
/**
* Device related REST-API. This can be used to manipulated device related details.
@@ -1074,6 +1076,84 @@ public interface DeviceManagementService {
required = true)
SearchContext searchContext);
+ @POST
+ @Path("/query-devices")
+ @ApiOperation(
+ produces = MediaType.APPLICATION_JSON,
+ consumes = MediaType.APPLICATION_JSON,
+ httpMethod = "POST",
+ value = "Property based Search for Devices",
+ notes = "Search for devices based on properties",
+ tags = "Device Management",
+ extensions = {
+ @Extension(properties = {
+ @ExtensionProperty(name = Constants.SCOPE, value = "perm:devices:search")
+ })
+ }
+ )
+ @ApiResponses(
+ value = {
+ @ApiResponse(
+ code = 200,
+ message = "OK. \n Successfully retrieved the device information.",
+ response = DeviceList.class,
+ responseHeaders = {
+ @ResponseHeader(
+ name = "Content-Type",
+ description = "The content type of the body"),
+ @ResponseHeader(
+ name = "ETag",
+ description = "Entity Tag of the response resource.\n" +
+ "Used by caches, or in conditional requests."),
+ @ResponseHeader(
+ name = "Last-Modified",
+ description = "Date and time the resource was last modified. \n" +
+ "Used by caches, or in conditional requests.")}),
+ @ApiResponse(
+ code = 304,
+ message = "Not Modified. \n " +
+ "Empty body because the client already has the latest version of the requested resource.\n"),
+ @ApiResponse(
+ code = 400,
+ message = "Bad Request. \n Invalid request or validation error.",
+ response = ErrorResponse.class),
+ @ApiResponse(
+ code = 404,
+ message = "Not Acceptable.\n The existing device did not match the values specified in the device search.",
+ response = ErrorResponse.class),
+ @ApiResponse(
+ code = 406,
+ message = "Not Acceptable.\n The requested media type is not supported"),
+ @ApiResponse(
+ code = 415,
+ message = "Unsupported media type. \n The format of the requested entity was not supported."),
+ @ApiResponse(
+ code = 500,
+ message = "Internal Server Error. \n " +
+ "Server error occurred while getting the device details.",
+ response = ErrorResponse.class)
+ })
+ Response queryDevicesByProperties(
+ @ApiParam(
+ name = "offset",
+ value = "The starting pagination index for the complete list of qualified items.",
+ required = false,
+ defaultValue = "0")
+ @QueryParam("offset")
+ int offset,
+ @ApiParam(
+ name = "limit",
+ value = "Provide how many activity details you require from the starting pagination index/offset.",
+ required = false,
+ defaultValue = "5")
+ @QueryParam("limit")
+ int limit,
+ @ApiParam(
+ name = "device property map",
+ value = "properties by which devices need filtered",
+ required = true)
+ PropertyMap map);
+
@GET
@Path("/{type}/{id}/applications")
@ApiOperation(
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/service/impl/DeviceManagementServiceImpl.java b/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/service/impl/DeviceManagementServiceImpl.java
index 9175580ce9..2e7aeb9e53 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/service/impl/DeviceManagementServiceImpl.java
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/service/impl/DeviceManagementServiceImpl.java
@@ -63,6 +63,7 @@ import org.wso2.carbon.device.mgt.common.operation.mgt.OperationManagementExcept
import org.wso2.carbon.device.mgt.common.policy.mgt.Policy;
import org.wso2.carbon.device.mgt.common.policy.mgt.monitor.NonComplianceData;
import org.wso2.carbon.device.mgt.common.policy.mgt.monitor.PolicyComplianceException;
+import org.wso2.carbon.device.mgt.common.search.PropertyMap;
import org.wso2.carbon.device.mgt.common.search.SearchContext;
import org.wso2.carbon.device.mgt.core.app.mgt.ApplicationManagementProviderService;
import org.wso2.carbon.device.mgt.core.device.details.mgt.DeviceDetailsMgtException;
@@ -104,6 +105,7 @@ import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Date;
import java.util.List;
+import java.util.Map;
@Path("/devices")
@Produces(MediaType.APPLICATION_JSON)
@@ -652,6 +654,30 @@ public class DeviceManagementServiceImpl implements DeviceManagementService {
return Response.status(Response.Status.OK).entity(deviceList).build();
}
+ @POST
+ @Path("/query-devices")
+ @Override
+ public Response queryDevicesByProperties(@QueryParam("offset") int offset,
+ @QueryParam("limit") int limit, PropertyMap map) {
+ List devices;
+ DeviceList deviceList = new DeviceList();
+ try {
+ DeviceManagementProviderService dms = DeviceMgtAPIUtils.getDeviceManagementService();
+ devices = dms.getDevicesBasedOnProperties(map.getProperties());
+ if(devices == null || devices.isEmpty()){
+ return Response.status(Response.Status.OK).entity("No device found matching query criteria.").build();
+ }
+ } catch (DeviceManagementException e) {
+ String msg = "Error occurred while searching for devices that matches the provided device properties";
+ log.error(msg, e);
+ return Response.serverError().entity(
+ new ErrorResponse.ErrorResponseBuilder().setMessage(msg).build()).build();
+ }
+ deviceList.setList(devices);
+ deviceList.setCount(devices.size());
+ return Response.status(Response.Status.OK).entity(deviceList).build();
+ }
+
@GET
@Path("/{type}/{id}/applications")
@Override
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.common/src/main/java/org/wso2/carbon/device/mgt/common/search/PropertyMap.java b/components/device-mgt/org.wso2.carbon.device.mgt.common/src/main/java/org/wso2/carbon/device/mgt/common/search/PropertyMap.java
new file mode 100644
index 0000000000..68df7c7bdc
--- /dev/null
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.common/src/main/java/org/wso2/carbon/device/mgt/common/search/PropertyMap.java
@@ -0,0 +1,43 @@
+/*
+ * Copyright (c) 2016, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.
+ *
+ * WSO2 Inc. licenses this file to you under the Apache License,
+ * Version 2.0 (the "License"); you may not use this file except
+ * in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+
+package org.wso2.carbon.device.mgt.common.search;
+
+import io.swagger.annotations.ApiModel;
+import io.swagger.annotations.ApiModelProperty;
+
+import java.util.Map;
+
+
+@ApiModel(value = "PropertyMap", description = "Search properties based on which devices need to be found.")
+public class PropertyMap {
+
+ @ApiModelProperty(name = "properties", value = "Contains the properties for search.",
+ required = true)
+ private Map properties;
+
+ public Map getProperties() {
+ return properties;
+ }
+
+ public void setProperties(Map properties) {
+ this.properties = properties;
+ }
+}
+
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/DeviceDAO.java b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/DeviceDAO.java
index b089477f06..1a8888ae1b 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/DeviceDAO.java
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/DeviceDAO.java
@@ -47,6 +47,7 @@ import org.wso2.carbon.device.mgt.core.geo.geoHash.GeoCoordinate;
import java.util.Date;
import java.util.HashMap;
import java.util.List;
+import java.util.Map;
/**
* This class represents the key operations associated with persisting device related information.
@@ -180,6 +181,15 @@ public interface DeviceDAO {
Device getDevice(DeviceIdentifier deviceIdentifier, Date ifModifiedSince, int tenantId) throws
DeviceManagementDAOException;
+ /**
+ * Retrieves a list of devices based on a given criteria of properties
+ * @param deviceProps properties by which devices need to be filtered
+ * @param tenantId tenant id
+ * @return list of devices
+ * @throws DeviceManagementDAOException
+ */
+ List getDeviceBasedOnDeviceProperties(Map deviceProps, int tenantId) throws DeviceManagementDAOException;
+
/**
* This method is used to retrieve a device of a given device-identifier and tenant-id which modified
* later than the ifModifiedSince param.
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/impl/AbstractDeviceDAOImpl.java b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/impl/AbstractDeviceDAOImpl.java
index aa07aba8b4..f241691ff6 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/impl/AbstractDeviceDAOImpl.java
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/impl/AbstractDeviceDAOImpl.java
@@ -39,6 +39,7 @@ package org.wso2.carbon.device.mgt.core.dao.impl;
import org.apache.commons.logging.LogFactory;
import org.wso2.carbon.device.mgt.common.Device;
import org.wso2.carbon.device.mgt.common.DeviceIdentifier;
+import org.wso2.carbon.device.mgt.common.DeviceManagementConstants;
import org.wso2.carbon.device.mgt.common.EnrolmentInfo;
import org.wso2.carbon.device.mgt.common.EnrolmentInfo.Status;
import org.wso2.carbon.device.mgt.common.PaginationRequest;
@@ -56,15 +57,22 @@ import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Timestamp;
import java.util.ArrayList;
+import java.util.Collection;
import java.util.Date;
import java.util.HashMap;
import java.util.List;
+import java.util.Map;
import java.util.StringJoiner;
public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
private static final org.apache.commons.logging.Log log = LogFactory.getLog(AbstractDeviceDAOImpl.class);
+ private static final String PROPERTY_KEY_COLUMN_NAME = "PROPERTY_NAME";
+ private static final String PROPERTY_VALUE_COLUMN_NAME = "PROPERTY_VALUE";
+ private static final String PROPERTY_DEVICE_TYPE_NAME = "DEVICE_TYPE_NAME";
+ private static final String PROPERTY_DEVICE_IDENTIFICATION = "DEVICE_IDENTIFICATION";
+
@Override
public int addDevice(int typeId, Device device, int tenantId) throws DeviceManagementDAOException {
Connection conn;
@@ -282,6 +290,61 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
return device;
}
+ public List getDeviceBasedOnDeviceProperties(Map deviceProps, int tenantId)
+ throws DeviceManagementDAOException {
+ Connection conn = null;
+ PreparedStatement stmt = null;
+ ResultSet resultSet = null;
+ List devices = null;
+ try {
+ List> outputLists = new ArrayList<>();
+ List deviceList = null;
+ conn = this.getConnection();
+ for (Map.Entry entry : deviceProps.entrySet()) {
+
+ stmt = conn.prepareStatement("SELECT DEVICE_IDENTIFICATION FROM DM_DEVICE_PROPERTIES " +
+ "WHERE (PROPERTY_NAME , PROPERTY_VALUE) IN " +
+ "((? , ?)) AND TENANT_ID = ?");
+ stmt.setString(1, entry.getKey());
+ stmt.setString(2, entry.getValue());
+ stmt.setInt(3, tenantId);
+ resultSet = stmt.executeQuery();
+
+ deviceList = new ArrayList<>();
+ while (resultSet.next()) {
+ deviceList.add(resultSet.getString(PROPERTY_DEVICE_IDENTIFICATION));
+ }
+ outputLists.add(deviceList);
+ }
+ List deviceIds = findIntersection(outputLists);
+ for(String deviceId : deviceIds){
+ devices.add(getDevice(deviceId, tenantId));
+ }
+ } catch (SQLException e) {
+ String msg = "Error occurred while fetching devices against criteria : '" + deviceProps;
+ log.error(msg, e);
+ throw new DeviceManagementDAOException(msg, e);
+ } finally {
+ DeviceManagementDAOUtil.cleanupResources(stmt, resultSet);
+ }
+ return devices;
+ }
+
+ private List findIntersection(List> collections) {
+ boolean first = true;
+ List intersectedResult = new ArrayList<>();
+ for (Collection collection : collections) {
+ if (first) {
+ intersectedResult.addAll(collection);
+ first = false;
+ } else {
+ intersectedResult.retainAll(collection);
+ }
+ }
+ return intersectedResult;
+ }
+
+
@Override
public Device getDevice(String deviceIdentifier, Date since, int tenantId)
throws DeviceManagementDAOException {
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/service/DeviceManagementProviderService.java b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/service/DeviceManagementProviderService.java
index 43ac2c8567..b32ed7ed12 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/service/DeviceManagementProviderService.java
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/service/DeviceManagementProviderService.java
@@ -65,6 +65,7 @@ import org.wso2.carbon.device.mgt.core.geo.geoHash.GeoCoordinate;
import java.util.Date;
import java.util.HashMap;
import java.util.List;
+import java.util.Map;
/**
* Proxy class for all Device Management related operations that take the corresponding plugin type in
@@ -254,6 +255,15 @@ public interface DeviceManagementProviderService {
*/
Device getDevice(DeviceIdentifier deviceId, Date since, boolean requireDeviceInfo) throws DeviceManagementException;
+ /**
+ * Retrieves a list of devices based on a given criteria of properties
+ *
+ * @param deviceProps properties by which devices need to be drawn
+ * @return list of devices
+ * @throws DeviceManagementException
+ */
+ List getDevicesBasedOnProperties(Map deviceProps) throws DeviceManagementException;
+
/**
* Returns the device of specified id.
*
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/service/DeviceManagementProviderServiceImpl.java b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/service/DeviceManagementProviderServiceImpl.java
index 621cc966e3..b662585cc6 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/service/DeviceManagementProviderServiceImpl.java
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/service/DeviceManagementProviderServiceImpl.java
@@ -1198,6 +1198,46 @@ public class DeviceManagementProviderServiceImpl implements DeviceManagementProv
return device;
}
+
+ @Override
+ public List getDevicesBasedOnProperties(Map deviceProps) throws DeviceManagementException {
+ if (deviceProps == null || deviceProps.isEmpty()) {
+ String msg = "Devices retrieval criteria cannot be null or empty.";
+ log.error(msg);
+ throw new DeviceManagementException(msg);
+ }
+ if (log.isDebugEnabled()) {
+ log.debug("Attempting to get devices based on criteria : " + deviceProps);
+ }
+ List devices;
+ try {
+ int tenantId = PrivilegedCarbonContext.getThreadLocalCarbonContext().getTenantId();
+ DeviceManagementDAOFactory.openConnection();
+ devices = deviceDAO.getDeviceBasedOnDeviceProperties(deviceProps, tenantId);
+ if (devices == null) {
+ if (log.isDebugEnabled()) {
+ log.debug("No device is found against criteria : " + deviceProps + " and tenantId "+ tenantId);
+ }
+ return null;
+ }
+ } catch (DeviceManagementDAOException e) {
+ String msg = "Error occurred while obtaining devices based on criteria : " + deviceProps;
+ log.error(msg, e);
+ throw new DeviceManagementException(msg, e);
+ } catch (SQLException e) {
+ String msg = "Error occurred while opening a connection to the data source";
+ log.error(msg, e);
+ throw new DeviceManagementException(msg, e);
+ } catch (Exception e) {
+ String msg = "Error occurred while obtaining devices based on criteria : " + deviceProps;
+ log.error(msg, e);
+ throw new DeviceManagementException(msg, e);
+ } finally {
+ DeviceManagementDAOFactory.closeConnection();
+ }
+ return devices;
+ }
+
@Override
public Device getDevice(String deviceId, Date since, boolean requireDeviceInfo) throws DeviceManagementException {
if (deviceId == null || since == null) {
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/dao/PluginDAO.java b/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/dao/PluginDAO.java
index 47606fe6a6..51f1759fe0 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/dao/PluginDAO.java
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/dao/PluginDAO.java
@@ -20,6 +20,7 @@ package org.wso2.carbon.device.mgt.extensions.device.type.template.dao;
import org.wso2.carbon.device.mgt.common.Device;
import org.wso2.carbon.device.mgt.extensions.device.type.template.exception.DeviceTypeMgtPluginException;
+
import java.util.List;
public interface PluginDAO {
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/dao/PropertyBasedPluginDAOImpl.java b/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/dao/PropertyBasedPluginDAOImpl.java
index ac90fb1052..d1731d0999 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/dao/PropertyBasedPluginDAOImpl.java
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.extensions/src/main/java/org/wso2/carbon/device/mgt/extensions/device/type/template/dao/PropertyBasedPluginDAOImpl.java
@@ -31,7 +31,6 @@ import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.ArrayList;
-import java.util.Arrays;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
From 42b9753944d4149196c732d73f2c31edf5b52859 Mon Sep 17 00:00:00 2001
From: Ace
Date: Fri, 28 Jun 2019 10:13:51 +0530
Subject: [PATCH 04/18] fixing bug with unitiated list
---
.../carbon/device/mgt/core/dao/impl/AbstractDeviceDAOImpl.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/impl/AbstractDeviceDAOImpl.java b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/impl/AbstractDeviceDAOImpl.java
index f241691ff6..f6b42189eb 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/impl/AbstractDeviceDAOImpl.java
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/impl/AbstractDeviceDAOImpl.java
@@ -295,7 +295,7 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
Connection conn = null;
PreparedStatement stmt = null;
ResultSet resultSet = null;
- List devices = null;
+ List devices = new ArrayList<>();
try {
List> outputLists = new ArrayList<>();
List deviceList = null;
From ca07db3fca15bbc35d545e07d5fcc6832c75fb80 Mon Sep 17 00:00:00 2001
From: Ace
Date: Fri, 28 Jun 2019 11:25:01 +0530
Subject: [PATCH 05/18] Adding code to retrieve properties instead of the
entire device
---
.../carbon/device/mgt/core/dao/DeviceDAO.java | 13 +++++-
.../core/dao/impl/AbstractDeviceDAOImpl.java | 45 ++++++++++++++++++-
2 files changed, 55 insertions(+), 3 deletions(-)
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/DeviceDAO.java b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/DeviceDAO.java
index 1a8888ae1b..5ea2a87b5b 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/DeviceDAO.java
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/DeviceDAO.java
@@ -185,11 +185,22 @@ public interface DeviceDAO {
* Retrieves a list of devices based on a given criteria of properties
* @param deviceProps properties by which devices need to be filtered
* @param tenantId tenant id
- * @return list of devices
+ * @return list of devices with properties
* @throws DeviceManagementDAOException
*/
List getDeviceBasedOnDeviceProperties(Map deviceProps, int tenantId) throws DeviceManagementDAOException;
+
+ /**
+ * Retrieves properties of given device identifier
+ *
+ * @param deviceId identifier of device that need to be retrieved
+ * @param tenantId tenant ID
+ * @return list of devices with properties
+ * @throws DeviceManagementDAOException
+ */
+ Device getDeviceProps(String deviceId, int tenantId) throws DeviceManagementDAOException;
+
/**
* This method is used to retrieve a device of a given device-identifier and tenant-id which modified
* later than the ifModifiedSince param.
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/impl/AbstractDeviceDAOImpl.java b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/impl/AbstractDeviceDAOImpl.java
index f6b42189eb..8e9442f8d5 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/impl/AbstractDeviceDAOImpl.java
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/impl/AbstractDeviceDAOImpl.java
@@ -39,7 +39,6 @@ package org.wso2.carbon.device.mgt.core.dao.impl;
import org.apache.commons.logging.LogFactory;
import org.wso2.carbon.device.mgt.common.Device;
import org.wso2.carbon.device.mgt.common.DeviceIdentifier;
-import org.wso2.carbon.device.mgt.common.DeviceManagementConstants;
import org.wso2.carbon.device.mgt.common.EnrolmentInfo;
import org.wso2.carbon.device.mgt.common.EnrolmentInfo.Status;
import org.wso2.carbon.device.mgt.common.PaginationRequest;
@@ -290,6 +289,7 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
return device;
}
+ @Override
public List getDeviceBasedOnDeviceProperties(Map deviceProps, int tenantId)
throws DeviceManagementDAOException {
Connection conn = null;
@@ -318,7 +318,7 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
}
List deviceIds = findIntersection(outputLists);
for(String deviceId : deviceIds){
- devices.add(getDevice(deviceId, tenantId));
+ devices.add(getDeviceProps(deviceId, tenantId));
}
} catch (SQLException e) {
String msg = "Error occurred while fetching devices against criteria : '" + deviceProps;
@@ -330,6 +330,47 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
return devices;
}
+ @Override
+ public Device getDeviceProps(String deviceId, int tenantId) throws DeviceManagementDAOException {
+ Connection conn = null;
+ PreparedStatement stmt = null;
+ Device device = null;
+ ResultSet resultSet = null;
+ String deviceType = null;
+ try {
+ conn = this.getConnection();
+ stmt = conn.prepareStatement(
+ "SELECT * FROM DM_DEVICE_PROPERTIES WHERE DEVICE_IDENTIFICATION = ? AND TENANT_ID = ?");
+ stmt.setString(1, deviceId);
+ stmt.setInt(2, tenantId);
+ resultSet = stmt.executeQuery();
+ List properties = new ArrayList<>();
+ while (resultSet.next()) {
+ Device.Property property = new Device.Property();
+ property.setName(resultSet.getString(PROPERTY_KEY_COLUMN_NAME));
+ property.setValue(resultSet.getString(PROPERTY_VALUE_COLUMN_NAME));
+ properties.add(property);
+ //We are repeatedly assigning device type here. Yes. This was done intentionally, as there would be
+ //No other efficient/simple/inexpensive way of retrieving device type of a particular device from the database
+ //Note that device-identification will be unique across device types
+ deviceType = resultSet.getString(PROPERTY_DEVICE_TYPE_NAME);
+ }
+ device = new Device();
+ device.setDeviceIdentifier(deviceId);
+ device.setType(deviceType);
+ device.setProperties(properties);
+
+ } catch (SQLException e) {
+ String msg = "Error occurred while fetching properties for device : '" + deviceId;
+ log.error(msg, e);
+ throw new DeviceManagementDAOException(msg, e);
+ } finally {
+ DeviceManagementDAOUtil.cleanupResources(stmt, resultSet);
+ }
+
+ return device;
+ }
+
private List findIntersection(List> collections) {
boolean first = true;
List intersectedResult = new ArrayList<>();
From 1ad6519600590c5f4f3680b59e9af1bcac91f8d2 Mon Sep 17 00:00:00 2001
From: Ace
Date: Thu, 4 Jul 2019 11:06:21 +0530
Subject: [PATCH 06/18] changing references to older release in html pages
---
.../cdmf.page.cookie-policy/cookie-policy.hbs | 6 +++---
.../cdmf.page.privacy-policy/privacy-policy.hbs | 14 +++++++-------
.../app/units/cdmf.unit.footer/footer.hbs | 4 ++--
3 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.cookie-policy/cookie-policy.hbs b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.cookie-policy/cookie-policy.hbs
index cc48c8bad1..645ef3fb45 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.cookie-policy/cookie-policy.hbs
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.cookie-policy/cookie-policy.hbs
@@ -90,7 +90,7 @@
Entgra IoT Server 3.6.0 as a product does not use cookies for analytical purposes.
Third party cookies
Using Entgra IoT Server 3.6.0 may cause third-party cookie to be set in your browser. Entgra IoT Server
- 3.5.0 has no control over how any of them operate. The third-party cookies that maybe set
+ 3.6.0 has no control over how any of them operate. The third-party cookies that maybe set
include:
Any social login sites. For example, third-party cookies may be set when Entgra IoT Server 3.6.0
@@ -103,8 +103,8 @@
no knowledge or use on these cookies.
What type of cookies does Entgra IoT Server 3.6.0 use?
Entgra IoT Server 3.6.0 uses persistent cookies and session cookies. A persistent cookie helps Entgra IS
- 3.5.0 to recognize you as an existing user so that it is easier to return to Entgra or interact with
- Entgra IS 3.5.0 without signing in again. After you sign in, a persistent cookie stays in your browser
+ 3.6.0 to recognize you as an existing user so that it is easier to return to Entgra or interact with
+ Entgra IS 3.6.0 without signing in again. After you sign in, a persistent cookie stays in your browser
and will be read by Entgra IoT Server 3.6.0 when you return to Entgra IoT Server 3.6.0.
A session cookie is a cookie that is erased when the user closes the Web browser. The session cookie
is stored in temporarily and is not retained after the browser is closed. Session cookies do not
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.privacy-policy/privacy-policy.hbs b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.privacy-policy/privacy-policy.hbs
index f69a06cd4a..98c5c1a7bd 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.privacy-policy/privacy-policy.hbs
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/pages/cdmf.page.privacy-policy/privacy-policy.hbs
@@ -40,7 +40,7 @@
collection, and information about the retention of your personal information.
Please note that this policy is for reference only, and is applicable for the software as a product.
Entgra and its developers have no access to the information held within Entgra IoT Server
- 3.5.0.Please see the Disclaimer section for more information. Entities, organisations or individuals
+ 3.6.0.Please see the Disclaimer section for more information. Entities, organisations or individuals
controlling the use and administration of Entgra IoT Server 3.6.0 should create their own privacy
policies setting out the manner in which data is controlled or processed by the respective entity,
organisation or individual.
@@ -103,7 +103,7 @@
uploaded profile pictures for this purpose.
To protect your account from unauthorized access or potential hacking attempts. Entgra IoT Server
- 3.5.0 uses HTTP or TCP/IP Headers for this purpose.
+ 3.6.0 uses HTTP or TCP/IP Headers for this purpose.
This includes:
@@ -114,7 +114,7 @@
Derive statistical data for analytical purposes on system performance improvements. Entgra IoT
- Server 3.5.0 will not keep any personal information after statistical calculations. Therefore,
+ Server 3.6.0 will not keep any personal information after statistical calculations. Therefore,
the statistical report has no means of identifying an individual person.
Entgra IoT Server 3.6.0 may use:
@@ -176,17 +176,17 @@
Entgra, its employees, partners, and affiliates do not have access to and do not require, store,
process or control any of the data, including personal data contained in Entgra IoT Server 3.6.0. All
data, including personal data is controlled and processed by the entity or individual running Entgra
- IoT Server 3.5.0. Entgra, its employees partners and affiliates are not a data processor or a data
+ IoT Server 3.6.0. Entgra, its employees partners and affiliates are not a data processor or a data
controller within the meaning of any data privacy regulations. Entgra does not provide any warranties
or undertake any responsibility or liability in connection with the lawfulness or the manner and
purposes for which Entgra IoT Server 3.6.0 is used by such entities or persons.
This privacy policy is for the informational purposes of the entity or persons running Entgra IoT
- Server 3.5.0 and sets out the processes and functionality contained within Entgra IoT Server 3.6.0
+ Server 3.6.0 and sets out the processes and functionality contained within Entgra IoT Server 3.6.0
regarding personal data protection. It is the responsibility of entities and persons running Entgra IoT
- Server 3.5.0 to create and administer its own rules and processes governing users’ personal data,
+ Server 3.6.0 to create and administer its own rules and processes governing users’ personal data,
Please note that the creation of such rules and processes may change the use, storage and disclosure
policies contained herein. Therefore users should consult the entity or persons running Entgra IoT
- Server 3.5.0 for its own privacy policy for details governing users’ personal data.
+ Server 3.6.0 for its own privacy policy for details governing users’ personal data.
diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.footer/footer.hbs b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.footer/footer.hbs
index 5d639f1191..341753d2c4 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.footer/footer.hbs
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.ui/src/main/resources/jaggeryapps/devicemgt/app/units/cdmf.unit.footer/footer.hbs
@@ -17,8 +17,8 @@
}}
{{#zone "footer"}}
- Start installing the application for one or more users by entering the corresponding user name. Select install to automatically start downloading the application for the respective user/users.
+
+ Start installing the application for one or more users by entering the corresponding user name.
+ Select install to automatically start downloading the application for the respective user/users.
+
-
+
);
}
}
-export default DeviceInstall;
\ No newline at end of file
+export default DeviceInstall;
diff --git a/features/application-mgt/org.wso2.carbon.device.application.mgt.server.feature/src/main/resources/conf/application-mgt.xml b/features/application-mgt/org.wso2.carbon.device.application.mgt.server.feature/src/main/resources/conf/application-mgt.xml
index c5d034e6ac..f844cb9195 100644
--- a/features/application-mgt/org.wso2.carbon.device.application.mgt.server.feature/src/main/resources/conf/application-mgt.xml
+++ b/features/application-mgt/org.wso2.carbon.device.application.mgt.server.feature/src/main/resources/conf/application-mgt.xml
@@ -183,4 +183,8 @@
110
+
+
+ https
+
From 198bfc11f6996d35e9ea842c5c51cda5ce1bb8e6 Mon Sep 17 00:00:00 2001
From: lasanthaDLPDS
Date: Fri, 19 Jul 2019 14:04:22 +0530
Subject: [PATCH 17/18] Fix app installing issue in APPM
---
.../device/application/mgt/core/dao/SubscriptionDAO.java | 3 ++-
.../dao/impl/subscription/GenericSubscriptionDAOImpl.java | 8 +++++---
.../mgt/core/impl/SubscriptionManagerImpl.java | 2 +-
.../src/components/apps/release/install/DeviceInstall.js | 1 -
4 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/components/application-mgt/org.wso2.carbon.device.application.mgt.core/src/main/java/org/wso2/carbon/device/application/mgt/core/dao/SubscriptionDAO.java b/components/application-mgt/org.wso2.carbon.device.application.mgt.core/src/main/java/org/wso2/carbon/device/application/mgt/core/dao/SubscriptionDAO.java
index c41dda76d7..469ee44030 100644
--- a/components/application-mgt/org.wso2.carbon.device.application.mgt.core/src/main/java/org/wso2/carbon/device/application/mgt/core/dao/SubscriptionDAO.java
+++ b/components/application-mgt/org.wso2.carbon.device.application.mgt.core/src/main/java/org/wso2/carbon/device/application/mgt/core/dao/SubscriptionDAO.java
@@ -77,7 +77,8 @@ public interface SubscriptionDAO {
void updateSubscriptions(int tenantId, String updateBy, List paramList,
int releaseId, String subType, String action) throws ApplicationManagementDAOException;
- List getSubscribedDeviceIds(List deviceIds, int tenantId) throws ApplicationManagementDAOException;
+ List getSubscribedDeviceIds(List deviceIds, int applicationReleaseId, int tenantId)
+ throws ApplicationManagementDAOException;
List getDeviceSubIdsForOperation (int operationId, int tenantId) throws ApplicationManagementDAOException;
diff --git a/components/application-mgt/org.wso2.carbon.device.application.mgt.core/src/main/java/org/wso2/carbon/device/application/mgt/core/dao/impl/subscription/GenericSubscriptionDAOImpl.java b/components/application-mgt/org.wso2.carbon.device.application.mgt.core/src/main/java/org/wso2/carbon/device/application/mgt/core/dao/impl/subscription/GenericSubscriptionDAOImpl.java
index 9eabccb38c..cc6938c934 100644
--- a/components/application-mgt/org.wso2.carbon.device.application.mgt.core/src/main/java/org/wso2/carbon/device/application/mgt/core/dao/impl/subscription/GenericSubscriptionDAOImpl.java
+++ b/components/application-mgt/org.wso2.carbon.device.application.mgt.core/src/main/java/org/wso2/carbon/device/application/mgt/core/dao/impl/subscription/GenericSubscriptionDAOImpl.java
@@ -533,7 +533,8 @@ public class GenericSubscriptionDAOImpl extends AbstractDAOImpl implements Subsc
}
@Override
- public List getSubscribedDeviceIds(List deviceIds, int tenantId)
+ public List getSubscribedDeviceIds(List deviceIds, int applicationReleaseId,
+ int tenantId)
throws ApplicationManagementDAOException {
if (log.isDebugEnabled()) {
log.debug("Request received to DAO Layer to get already subscribed dvice Ids for given list of device Ids.");
@@ -545,14 +546,15 @@ public class GenericSubscriptionDAOImpl extends AbstractDAOImpl implements Subsc
StringJoiner joiner = new StringJoiner(",",
"SELECT DS.DM_DEVICE_ID "
+ "FROM AP_DEVICE_SUBSCRIPTION DS "
- + "WHERE DS.DM_DEVICE_ID IN (", ") AND TENANT_ID = ?");
+ + "WHERE DS.DM_DEVICE_ID IN (", ") AND AP_APP_RELEASE_ID = ? AND TENANT_ID = ?");
deviceIds.stream().map(ignored -> "?").forEach(joiner::add);
String query = joiner.toString();
try (PreparedStatement ps = conn.prepareStatement(query)) {
for (Integer deviceId : deviceIds) {
ps.setObject(index++, deviceId);
}
- ps.setInt(index, tenantId);
+ ps.setInt(index++, tenantId);
+ ps.setInt(index, applicationReleaseId);
try (ResultSet rs = ps.executeQuery()) {
while (rs.next()) {
subscribedDevices.add(rs.getInt("DM_DEVICE_ID"));
diff --git a/components/application-mgt/org.wso2.carbon.device.application.mgt.core/src/main/java/org/wso2/carbon/device/application/mgt/core/impl/SubscriptionManagerImpl.java b/components/application-mgt/org.wso2.carbon.device.application.mgt.core/src/main/java/org/wso2/carbon/device/application/mgt/core/impl/SubscriptionManagerImpl.java
index 5cbe5b8696..c49167f90b 100644
--- a/components/application-mgt/org.wso2.carbon.device.application.mgt.core/src/main/java/org/wso2/carbon/device/application/mgt/core/impl/SubscriptionManagerImpl.java
+++ b/components/application-mgt/org.wso2.carbon.device.application.mgt.core/src/main/java/org/wso2/carbon/device/application/mgt/core/impl/SubscriptionManagerImpl.java
@@ -366,7 +366,7 @@ public class SubscriptionManagerImpl implements SubscriptionManager {
List operationAddedDeviceIds = getOperationAddedDeviceIds(activity,
subscribingDeviceIdHolder.getSubscribableDevices());
List alreadySubscribedDevices = subscriptionDAO
- .getSubscribedDeviceIds(operationAddedDeviceIds, tenantId);
+ .getSubscribedDeviceIds(operationAddedDeviceIds, applicationReleaseId, tenantId);
if (SubAction.INSTALL.toString().equalsIgnoreCase(action)) {
if (!alreadySubscribedDevices.isEmpty()) {
List deviceResubscribingIds = subscriptionDAO
diff --git a/components/application-mgt/org.wso2.carbon.device.application.mgt.store.ui/react-app/src/components/apps/release/install/DeviceInstall.js b/components/application-mgt/org.wso2.carbon.device.application.mgt.store.ui/react-app/src/components/apps/release/install/DeviceInstall.js
index 7946dd833a..57bbf1c532 100644
--- a/components/application-mgt/org.wso2.carbon.device.application.mgt.store.ui/react-app/src/components/apps/release/install/DeviceInstall.js
+++ b/components/application-mgt/org.wso2.carbon.device.application.mgt.store.ui/react-app/src/components/apps/release/install/DeviceInstall.js
@@ -190,7 +190,6 @@ class DeviceInstall extends React.Component {
this.props.onInstall("devices", payload);
};
-
render() {
const {data,pagination,loading,selectedRows} = this.state;
return (
From 4c79f3f1a8c576471c9e714cec992b87c10fe65f Mon Sep 17 00:00:00 2001
From: lasanthaDLPDS
Date: Mon, 22 Jul 2019 01:17:58 +0530
Subject: [PATCH 18/18] Improve APPM MDM configs
---
.../mgt/common/config/MDMConfig.java | 40 ++++++++++++++
.../app/Test Android App | Bin 0 -> 6259412 bytes
.../banner/My First Banner | Bin 0 -> 179761 bytes
.../icon/My First Icon | Bin 0 -> 41236 bytes
.../screenshot1/shot1 | Bin 0 -> 41236 bytes
.../screenshot2/shot3 | Bin 0 -> 41236 bytes
.../screenshot3/shot2 | Bin 0 -> 41236 bytes
.../mgt/core/config/Configuration.java | 30 ++++-------
.../mgt/core/impl/ApplicationManagerImpl.java | 11 ++--
.../core/impl/SubscriptionManagerImpl.java | 12 ++---
.../application/mgt/core/util/APIUtil.java | 41 ++++++++++----
.../application/mgt/core/util/Constants.java | 6 ++-
.../application/mgt/core/util/DAOUtil.java | 19 -------
.../dao/ApplicationManagementDAOTest.java | 5 +-
.../src/test/resources/application-mgt.xml | 50 ++++++++++++------
.../repository/conf/application-mgt.xml | 40 ++++++++------
.../main/resources/conf/application-mgt.xml | 4 +-
17 files changed, 152 insertions(+), 106 deletions(-)
create mode 100644 components/application-mgt/org.wso2.carbon.device.application.mgt.common/src/main/java/org/wso2/carbon/device/application/mgt/common/config/MDMConfig.java
create mode 100644 components/application-mgt/org.wso2.carbon.device.application.mgt.core/repository/resources/apps/d46b34e7ba08f0d45056e77b9c70f528/app/Test Android App
create mode 100644 components/application-mgt/org.wso2.carbon.device.application.mgt.core/repository/resources/apps/d46b34e7ba08f0d45056e77b9c70f528/banner/My First Banner
create mode 100644 components/application-mgt/org.wso2.carbon.device.application.mgt.core/repository/resources/apps/d46b34e7ba08f0d45056e77b9c70f528/icon/My First Icon
create mode 100644 components/application-mgt/org.wso2.carbon.device.application.mgt.core/repository/resources/apps/d46b34e7ba08f0d45056e77b9c70f528/screenshot1/shot1
create mode 100644 components/application-mgt/org.wso2.carbon.device.application.mgt.core/repository/resources/apps/d46b34e7ba08f0d45056e77b9c70f528/screenshot2/shot3
create mode 100644 components/application-mgt/org.wso2.carbon.device.application.mgt.core/repository/resources/apps/d46b34e7ba08f0d45056e77b9c70f528/screenshot3/shot2
diff --git a/components/application-mgt/org.wso2.carbon.device.application.mgt.common/src/main/java/org/wso2/carbon/device/application/mgt/common/config/MDMConfig.java b/components/application-mgt/org.wso2.carbon.device.application.mgt.common/src/main/java/org/wso2/carbon/device/application/mgt/common/config/MDMConfig.java
new file mode 100644
index 0000000000..1f478f8481
--- /dev/null
+++ b/components/application-mgt/org.wso2.carbon.device.application.mgt.common/src/main/java/org/wso2/carbon/device/application/mgt/common/config/MDMConfig.java
@@ -0,0 +1,40 @@
+/* Copyright (c) 2019, Entgra (Pvt) Ltd. (http://www.entgra.io) All Rights Reserved.
+ *
+ * Entgra (Pvt) Ltd. licenses this file to you under the Apache License,
+ * Version 2.0 (the "License"); you may not use this file except
+ * in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.wso2.carbon.device.application.mgt.common.config;
+
+import javax.xml.bind.annotation.XmlElement;
+
+public class MDMConfig {
+
+ private String artifactDownloadProtocol;
+ private String artifactDownloadEndpoint;
+
+ @XmlElement(name = "ArtifactDownloadProtocol", required=true)
+ public String getArtifactDownloadProtocol() { return artifactDownloadProtocol; }
+
+ public void setArtifactDownloadProtocol(String artifactDownloadProtocol) {
+ this.artifactDownloadProtocol = artifactDownloadProtocol;
+ }
+
+ @XmlElement(name = "ArtifactDownloadEndpoint", required=true)
+ public String getArtifactDownloadEndpoint() { return artifactDownloadEndpoint; }
+
+ public void setArtifactDownloadEndpoint(String artifactDownloadEndpoint) {
+ this.artifactDownloadEndpoint = artifactDownloadEndpoint;
+ }
+}
diff --git a/components/application-mgt/org.wso2.carbon.device.application.mgt.core/repository/resources/apps/d46b34e7ba08f0d45056e77b9c70f528/app/Test Android App b/components/application-mgt/org.wso2.carbon.device.application.mgt.core/repository/resources/apps/d46b34e7ba08f0d45056e77b9c70f528/app/Test Android App
new file mode 100644
index 0000000000000000000000000000000000000000..10dfe26209d963f65244450a8037b9931b23de09
GIT binary patch
literal 6259412
zcmX7v2QXa!*T$3Ry|Y+-^=`G*d+$ULMBUXQYIH)hWwo`+vU*P>(UOpe=q#&?AQHVL
z5>XtXrr3|*ZSh4(vz_ajRTGam4YA7lC_I~_phgm8A`roM2n3Yde>USsa#mGjl4sDlz
z0WkrS)jp2+L{_jmQ*#vjL%;=Jp_U6wi0Tbfsl3O@xAywj2T^Swt2M2Y-e)nsse
z;#>Z!LzH?ZEaU<2aJ=*hTAzA9R6-JC&Hacet&&w&b{UYR3*__FQZznhP^a0{vz09=
zx=5W$$1E*In-iv&z9xvvb~Mewjzmu67?tZuIe8CbS5%gkya#=0WUL`S8l5zMrKJ+j
zM}!?Uc^Go6wB4u|?sqJm?=Zpe{HSnIvRf%i)KpSME*BfHA#a(!JbQBScvik%Dc^BO
zJMd@H3yANwI^H1I&${9vwL6_<`iJG^QB#FwXtp;_Fe&W5AF;^{?hFN&Z0N*Od35|T
zi?0?@@HJLSl_|Y_uqJ;eO84NQhw(#7n^c1^VHA6_C(|e8LE|qcJl3D?60M?hx8`dk
z1&W7k7TOcqpf{C#k)uZHq_5
zUbW_IIUT9$w-f1F@4E$z~#2xYYdsn*T-}lTDgj&0r(09H4m7nrnRNM9qG+8uYQ-rN+
zK){uuAf))wI9*t~g|E@wn@qN9gwdibrZiZezqm@G!DTX0fOBVo*Th`_ZU($n-OX{IU
z15*`fLEH)-+#yRVwnrGs;yXpY6I>io3%VnaTk$5$VH@fyfxi3-WrdckBad
z3oZGZ&YKK}6lU}S@qE(WK00i`Wo{qrh!jQjAvP@R{xMhIs*_I2oISOU8Ec86KN#c@aymrqH>rtum~zmt1W-B
z>odYTESrDP>_zk`UDN!p71C;XIxCpq4dYxIg8eu`k#CrN487`oab@g2W?NB++h(mm
zYSb9;vb@hPGU;#^qFU;;pbbrpi4{6Fo8o6#64iEjGgraoyupG;AVnSVhO$YGx)G$%
z5-#u#|Hr6N(~YTz>M#*4$v03W3wWC^5f+VsTv@O`u`XH&6GFw|)>Wj>qn@*CJv_E4
zePxDV_|!Fer+O;1yjot;Vbsau2n9MRGruTsW`;{yMve&cO9nj`WL-t0u11YEJ?1X&-X;LW4n&3rIy4c4}8yTh21VtY{yZd-*e5^q@D+^U(6IlRD{ZShL~vnu~OUq$hK&x9vc
zHrtorE&6S7SR*?$n^SF#g@>Z~<-NQ|c2_#~*R}M5O-3R#zS=QwW^&e1o}`%$1Bz#%
zNukc`w7@OBopyQ{WF!js~slR(-u)c)}xN?mOnt
zdUvaAhTy?jl%C+KX^r|iU(F}!V|gc4wh&K1u$L|k#b*a)s3t=%lQecUkWx>mJYtXk
zDmmu9KO!M1-=U!dQ&UjR)6r0Nz_rRMdmZ4d*l#O4Ts#*#TW_=z9U#0Uz83|+)6vMV
zN*zm{&fV!~P$dFQc!MT#Q!mFSU&+F?-*>}6
zrrc4&U45i$RK5Hs@CcvrFsBD5|Ii9QyrUwWWDFuaQb4mw82gav2*L
zDqizS>x=3t_|2p*gn8c(z!JcP?a0sIbw)bmii`+-#Ub7xkkT4$l5AB`80Mz%ZKp=^IZMo1Eej>^M~Y=D_gX5krtIT9K51UqrLYq)xe7~Vtwo1B{ln~q2O02dI-EGaj$X4
zIO`;Iw^ECHY&NyEc^%~YmYAeO2CeQaCL^gV2H3;*Ti
zHE&glneXAv6zTWwyFj+c+N^TL=4(klv+IGV945H4f1+R1{@8RnwkbI~g)1{TP6kVb
zlm=CweqgKRBZ7(O!GKdp8-`%cTx{5tBkMn^{{t9o8M_oG6%2A
zf?u7Bv;#0x5=h*-*)?~OaKww1i?7C62Ur%xGQC*$2{OcgDgopP|LSb3)s
zFjvce@X?B>Z_9WFUX%YF3G_Hxo8PsYO2^h2e)2o_QlW`m0UIKBB703W81A>kKThM>JT~2WyPaBNbhz6Esp+vdY3+b2$LC9MW%QLg%CP%m=s%RMcxN*fe($<=E3}$
zb-sN;h3)wQYC^*@;aXDH^}PC`#*Sh(1-yPXMXB<2g5URbq)BB;D9nJ~<~Trm7L;3q
z+Y)=-H5KZ5lAUv9xV2uc4cay=PLyz`J2HI28NX|JY?FR$SFfVbWa{ZOllT0zT2mKf
z49YK_1hckbJ_L9Plfm#&&qFd}y4PrU(s^Y}5*QvUL)H;;=&YnGUB|C;7}`^}8#SOQ
zpc0~hs>zn7+(+_-A-scINa;dE$9T-PfFs!^&7h+a&<3MH{l)zz3+-t&&g%>>$c2+I
zo~NRc4!sQA`9aNC1A}9ma;xRpqAH*Ry@e4X+~IVBK6*R`vYA=n9mc72MT;pkhT3aG
z>6%wlut`Vc**-pKxCNyP-UJsRRa^(2q%0zTiGj(flSC>1dtLG94AwrA%h$ZC_#pkI=IC$DiU!tSAg%72
zvjEBp))*7(as?S5q3@U@O2rB(TIN41hCc7&8RI0X^A{kHwNpzu(mw&%4s
z`JBTTYj$vsbZo?Axt6QgOmQH}LkiHRar{O>UzU*Xn{+r+Wpc`#HzZeGf5MKfO5TK3
z3F{X3g}e$$9#`YX`LIoZ;vwQuK&j-IPAo^c(UvL?5%r+2&??mu=6fU5iovP7gWU&j
zX)l^|s4iuYAHZvJmgyn-T=^+Uc2yLgLHK}$wwz2gK$5-~qv#URmt2<36>W9{dJuta
z<6bCDf>jc|(@fft1YEVDYf5;-g-txf3dQR*ohifGo`0eycuWI*B*9$GF|j`pS=f>v
zsbyZ35k)Y)j`$Rn97x!O
zT>NOXENL%Lju=X-Yj!6p>NI`wXEMt!p|X%?Ic;$&A*cCYt9of9q?-RPXix+wYrX^z
z*tf+&?)VrF+PMmlCvm%6$D4SV=tq9
zYu@*RZJ80+xY7$kz{U(lMyM^FESC3=f4DCB9Cjl1OWt)>yP%8mAZL8MxKdaH+h6v6
zA0fGdzujAstM5;^Fv}g4>ScSwv4w5um$)6ZqArWF-yyxQz@O<2v0IvLDW8aZ{=2P6
zs=+^vImSAaJq>CFO_M@jaxe3ptudI(W_9ZTu
z2_==!BoVze`fVQMCh~0&q^|t494wnebl(xrq4+aZS`Wz%PB*uR4$16qO(HsR0I4ds
zBwNNJnZW7XO3E^T<`a6*y{2_D!wM&7S1WD{8@%0Pb@pjZ%eKBP>#rJL{MA~oLm<<+
zl(JQBn_UBR4mNIEEksW?Yn%Fz;K?xVIADJkf;m}Pr_T!bMwN_{h>R~%y5*~B{(?rp3oV&U&Krt6$U-|a
zBO@Cdbm6^=viG7E;a{h53Ht+92GBgLgqK3;(uDhDP?=#jBxw&1`~xG?hsRdMa&|Se
z=KETjsnF~uf;anrde