From 4dac92b2602559659c692bfdc1da1393d23cca4c Mon Sep 17 00:00:00 2001
From: Amalka Subasinghe <amalka.subasinghe>
Date: Mon, 27 Mar 2023 15:05:57 +0530
Subject: [PATCH] fixed adding operation and operation response paths with emqx
 integration

---
 .../jaxrs/service/impl/DeviceManagementServiceImpl.java  | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/service/impl/DeviceManagementServiceImpl.java b/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/service/impl/DeviceManagementServiceImpl.java
index e37472bb69..b21eb4bcf8 100644
--- a/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/service/impl/DeviceManagementServiceImpl.java
+++ b/components/device-mgt/org.wso2.carbon.device.mgt.api/src/main/java/org/wso2/carbon/device/mgt/jaxrs/service/impl/DeviceManagementServiceImpl.java
@@ -872,6 +872,7 @@ public class DeviceManagementServiceImpl implements DeviceManagementService {
         DeviceManagementProviderService deviceManagementProviderService =
                 DeviceMgtAPIUtils.getDeviceManagementService();
         int validityTime = 3600;
+        // add scopes for event topics
         List<String> mqttEventTopicStructure = new ArrayList<>();
         try {
             DeviceType deviceType = deviceManagementProviderService.getDeviceType(type);
@@ -912,10 +913,16 @@ public class DeviceManagementServiceImpl implements DeviceManagementService {
                     topic = topic.replace("${deviceId}", id);
                 }
                 topic = topic.replace("/",":");
-                scopes.append(" perm:topic:sub:".concat(topic));
+//                scopes.append(" perm:topic:sub:".concat(topic));
                 scopes.append(" perm:topic:pub:".concat(topic));
             }
 
+            // add scopes for retrieve operation topic /tenantDomain/deviceType/deviceId/operation/#
+            scopes.append(" perm:topic:sub:" + tenantDomain + ":" + type + ":" + id + ":operation");
+
+            // add scopes for update operation /tenantDomain/deviceType/deviceId/update/operation
+            scopes.append(" perm:topic:pub:" + tenantDomain + ":" + type + ":" + id + ":update:operation");
+
             TokenRequest tokenRequest = new TokenRequest(dcrResponse.getClientId(), dcrResponse.getClientSecret(),
                     null, scopes.toString(), "client_credentials", null,
                     null, null, null,  validityTime);