Fix issues in PR https://github.com/wso2/product-iots/pull/151

8 years ago · 1b42f08a01
parent 35a47f81b0
commit 1b42f08a01
1 changed files with 1 additions and 1 deletions
--- a/modules/samples/firealarm/component/api/src/main/java/org/homeautomation/firealarm/api/DeviceTypeServiceImpl.java
+++ b/modules/samples/firealarm/component/api/src/main/java/org/homeautomation/firealarm/api/DeviceTypeServiceImpl.java
@ -129,7 +129,7 @@ public class DeviceTypeServiceImpl implements DeviceTypeService {
            }
            String sensorState = state.toUpperCase();
            if (!DeviceTypeConstants.STATE_ON.equals(sensorState)
-                    && !sensorState.equals(DeviceTypeConstants.STATE_OFF)) {
+                    && !DeviceTypeConstants.STATE_OFF.equals(sensorState)) {
                log.error("The requested state change should be either - 'ON' or 'OFF'");
                return Response.status(Response.Status.BAD_REQUEST).build();
            }