From c46c4f1be9b6f58bc8a56d1e8d1a7844a8a7b026 Mon Sep 17 00:00:00 2001 From: geethkokila Date: Mon, 19 Oct 2015 20:34:02 +0530 Subject: [PATCH] Fixing the policy update issues --- .../mgt/core/mgt/impl/PolicyManagerImpl.java | 72 ++++++++++++++++--- .../policy/mgt/core/PolicyDAOTestCase.java | 5 ++ 2 files changed, 67 insertions(+), 10 deletions(-) diff --git a/components/policy-mgt/org.wso2.carbon.policy.mgt.core/src/main/java/org/wso2/carbon/policy/mgt/core/mgt/impl/PolicyManagerImpl.java b/components/policy-mgt/org.wso2.carbon.policy.mgt.core/src/main/java/org/wso2/carbon/policy/mgt/core/mgt/impl/PolicyManagerImpl.java index 263817802b..e563d8c631 100644 --- a/components/policy-mgt/org.wso2.carbon.policy.mgt.core/src/main/java/org/wso2/carbon/policy/mgt/core/mgt/impl/PolicyManagerImpl.java +++ b/components/policy-mgt/org.wso2.carbon.policy.mgt.core/src/main/java/org/wso2/carbon/policy/mgt/core/mgt/impl/PolicyManagerImpl.java @@ -106,7 +106,7 @@ public class PolicyManagerImpl implements PolicyManager { policyDAO.addPolicyCriteriaProperties(policy.getPolicyCriterias()); } - if(policy.isActive()){ + if (policy.isActive()) { policyDAO.activatePolicy(policy.getId()); } PolicyManagementDAOFactory.commitTransaction(); @@ -135,18 +135,52 @@ public class PolicyManagerImpl implements PolicyManager { try { // Previous policy needs to be obtained before begining the transaction - Policy previousPolicy = getPolicy(policy.getId()); + Policy previousPolicy = this.getPolicy(policy.getId()); PolicyManagementDAOFactory.beginTransaction(); // This will keep track of the policies updated. policyDAO.recordUpdatedPolicy(policy); + + List existingFeaturesList = new ArrayList<>(); + List newFeaturesList = new ArrayList<>(); + List temp = new ArrayList<>(); + + List updatedFeatureList = policy.getProfile().getProfileFeaturesList(); + + List existingProfileFeaturesList = previousPolicy.getProfile().getProfileFeaturesList(); + + // Checks for the existing features + for (ProfileFeature feature : updatedFeatureList) { + for (ProfileFeature fe : existingProfileFeaturesList) { + if (feature.getFeatureCode().equalsIgnoreCase(fe.getFeatureCode())) { + existingFeaturesList.add(feature); + temp.add(feature.getFeatureCode()); + } + } + } + + // Checks for the new features + for (ProfileFeature feature : updatedFeatureList) { + if (!temp.contains(feature.getFeatureCode())) { + newFeaturesList.add(feature); + } + } + + int profileId = previousPolicy.getProfile().getProfileId(); + policy.getProfile().setProfileId(profileId); + policy.setProfileId(profileId); + Timestamp currentTimestamp = new Timestamp(Calendar.getInstance().getTime().getTime()); + policy.getProfile().setUpdatedDate(currentTimestamp); + policyDAO.updatePolicy(policy); profileDAO.updateProfile(policy.getProfile()); - featureDAO.updateProfileFeatures(policy.getProfile().getProfileFeaturesList(), policy.getProfile() - .getProfileId()); - policyDAO.deleteAllPolicyRelatedConfigs(policy.getId()); + featureDAO.updateProfileFeatures(existingFeaturesList, profileId); + if (!newFeaturesList.isEmpty()) { + featureDAO.addProfileFeatures(newFeaturesList, profileId); + } + policyDAO.deleteAllPolicyRelatedConfigs(policy.getId()); if (policy.getUsers() != null) { @@ -478,20 +512,24 @@ public class PolicyManagerImpl implements PolicyManager { roleNames = policyDAO.getPolicyAppliedRoles(policyId); userNames = policyDAO.getPolicyAppliedUsers(policyId); - Profile profile = profileDAO.getProfile(policy.getProfileId()); - policy.setProfile(profile); + //Profile profile = profileDAO.getProfile(policy.getProfileId()); + + policy.setRoles(roleNames); policy.setUsers(userNames); } catch (PolicyManagerDAOException e) { throw new PolicyManagementException("Error occurred while getting the policy related to policy ID (" + policyId + ")", e); - } catch (ProfileManagerDAOException e) { - throw new PolicyManagementException("Error occurred while getting the profile related to policy ID (" + - policyId + ")", e); +// } catch (ProfileManagerDAOException e) { +// throw new PolicyManagementException("Error occurred while getting the profile related to policy ID (" + +// policyId + ")", e); } catch (SQLException e) { throw new PolicyManagementException("Error occurred while opening a connection to the data source", e); +// } catch (ProfileManagementException e) { +// throw new PolicyManagementException("Error occurred while getting the profile related to policy ID (" + +// policyId + ")", e); } finally { PolicyManagementDAOFactory.closeConnection(); } @@ -499,6 +537,20 @@ public class PolicyManagerImpl implements PolicyManager { // This is done because connection close in below method too. deviceList = this.getPolicyAppliedDevicesIds(policyId); policy.setDevices(deviceList); + + try { + // PolicyManagementDAOFactory.openConnection(); + Profile profile = profileManager.getProfile(policy.getProfileId()); + policy.setProfile(profile); + } catch (ProfileManagementException e) { + throw new PolicyManagementException("Error occurred while getting the profile related to policy ID (" + + policyId + ")", e); +// } catch (SQLException e) { +// throw new PolicyManagementException("Error occurred while opening a connection to the data source", e); +// } finally { +// PolicyManagementDAOFactory.closeConnection(); + } + return policy; } diff --git a/components/policy-mgt/org.wso2.carbon.policy.mgt.core/src/test/java/org/wso2/carbon/policy/mgt/core/PolicyDAOTestCase.java b/components/policy-mgt/org.wso2.carbon.policy.mgt.core/src/test/java/org/wso2/carbon/policy/mgt/core/PolicyDAOTestCase.java index b17fda051c..931d0b4253 100644 --- a/components/policy-mgt/org.wso2.carbon.policy.mgt.core/src/test/java/org/wso2/carbon/policy/mgt/core/PolicyDAOTestCase.java +++ b/components/policy-mgt/org.wso2.carbon.policy.mgt.core/src/test/java/org/wso2/carbon/policy/mgt/core/PolicyDAOTestCase.java @@ -314,6 +314,11 @@ public class PolicyDAOTestCase extends BasePolicyManagementDAOTest { users.add("Udara"); users.add("Dileesha"); policy.setUsers(users); + + Profile profile2 = ProfileCreator.getProfile3(FeatureCreator.getFeatureList4()); + + Profile pf = new Profile(); + pap.updatePolicy(policy); pap.activatePolicy(policy.getId()); }