Fix for incorrect statistics issue in App Store for User and Role. #542
Open
ruwin
wants to merge 3 commits from ruwin/device-mgt-core:statistics-new into master
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'ruwin/device-mgt-core:statistics-new'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Purpose
Description
This pull request addresses a bug fix to the incorrect device statistics shown in the app store for user and role subscription types and as well as for the webapps.
The following changes have been made:
} catch (DeviceManagementDAOException e) {String msg = String.format("Error encountered while accessing device management data for user: %s", user);log.error(msg, e);} catch (Exception e) {don't use generic exceptions
log.error(msg, e);throw new ApplicationManagementException(msg, e);} catch (DeviceManagementDAOException e) {throw new RuntimeException(e);dont throw runtime exception. there is a relevant exceptions can be thrown. check the above code in this class.
}}}remove new lines
} catch (ApplicationManagementDAOException e) {String msg = "Error encountered while accessing application management data.";log.error(msg, e);throw new DeviceManagementException(msg, e);is this thrown exception correct? can refer the above code in this class(icould be wrong, so please check)
}} catch (DeviceManagementDAOException e) {String msg = String.format("Error encountered while accessing device management data for user: %s", user);log.error(msg, e);need to throw an exception here