community
/
device-mgt-core
12
0
Fork 47
Code Issues Pull Requests 26 Packages Projects Releases Wiki Activity
Labels Milestones

WIP: Fix for incorrect statistics issue in App Store for User and Role. #523

Draft
ruwin wants to merge 3 commits from ruwin/device-mgt-core:statistics into master
Conversation 0 Commits 3 Files Changed 4
ruwin commented 2 months ago

Purpose

Description

This pull request addresses a bug fix to the incorrect device statistics shown in the app store for user and role subscription types.

The following changes have been made:

  • Filtered and removed device ids irrelevant to the application supported os type which are getting for the calculation of statistics.
## Purpose * Fixed https://roadmap.entgra.net/issues/11657 ## Description This pull request addresses a bug fix to the incorrect device statistics shown in the app store for user and role subscription types. The following changes have been made: * Filtered and removed device ids irrelevant to the application supported os type which are getting for the calculation of statistics.
ruwin added 1 commit 2 months ago
27b033c3f0 Fix for incorrect statistics issue in User and Role
rajitha requested changes 1 month ago
components/application-mgt/io.entgra.device.mgt.core.application.mgt.core/src/main/java/io/entgra/device/mgt/core/application/mgt/core/util/subscription/mgt/impl/RoleBasedSubscriptionManagementHelperServiceImpl.java Outdated
}
for (String user : usersWithRole) {
try {
List<DeviceDetailsDTO> idsOwnByRole = HelperUtil.getDeviceManagementProviderService()
rajitha commented 1 month ago
Collaborator

Do not use internal DTOs from the device.mgt.core here. Expose the returning beans via a common bean like Device bean from the getDevicesByTenantId method.

Do not use internal DTOs from the device.mgt.core here. Expose the returning beans via a common bean like Device bean from the getDevicesByTenantId method.
ruwin marked this conversation as resolved
ruwin force-pushed statistics from 27b033c3f0 to c9bc8bd254 2 weeks ago
ruwin force-pushed statistics from c9bc8bd254 to 014889b237 2 weeks ago
ruwin changed title from Fix for incorrect statistics issue in App Store for User and Role. to WIP: Fix for incorrect statistics issue in App Store for User and Role. 2 weeks ago

Reviewers

rajitha requested changes 1 month ago
This pull request is marked as a work in progress.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
rajitha
Labels
Apply labels
Clear labels
pending upstream
PR depends on pending upstream dependency
No Label pending upstream
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: community/device-mgt-core#523
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'ruwin/device-mgt-core:statistics'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes