community
/
device-mgt-core
12
0
Fork 47
Code Issues Pull Requests 27 Packages Projects Releases Wiki Activity
Labels Milestones

Implement multi value (status) filtering for getting activity details #381

Merged
tcdlpds merged 3 commits from Gimhan-minion/device-mgt-core:act-fil into master 8 months ago
Conversation 0 Commits 3 Files Changed 5
Gimhan-minion commented 8 months ago
There is no content yet.
Gimhan-minion force-pushed act-fil from bf383f6ba0 to 99ddde26a6 8 months ago
charithag added 1 commit 8 months ago
charithag reviewed 8 months ago
components/device-mgt/io.entgra.device.mgt.core.device.mgt.core/src/main/java/io/entgra/device/mgt/core/device/mgt/core/operation/mgt/dao/impl/GenericOperationDAOImpl.java
sql.append("AND STATUS = ? ");
if (activityPaginationRequest.getStatuses() != null && !activityPaginationRequest.getStatuses().isEmpty()) {
sql.append("AND STATUS IN (");
for (int i = 0; i < activityPaginationRequest.getStatuses().size() - 1; i++) {
charithag commented 8 months ago
Owner

Incorrect logic. If stauses count is 1, activityPaginationRequest.getStatuses().size() - 1 = 0, the boundary condition get false and no statues will add to where in clause. Further this will omit last status all the time if statuses count is grater than 1.

Incorrect logic. If stauses count is 1, activityPaginationRequest.getStatuses().size() - 1 = 0, the boundary condition get false and no statues will add to where in clause. Further this will omit last status all the time if statuses count is grater than 1.
Gimhan-minion marked this conversation as resolved
charithag requested changes 8 months ago
charithag left a comment
Owner

Check review comment and fix it in all applicable places

Check review comment and fix it in all applicable places
charithag added 1 commit 8 months ago
Gimhan-minion requested review from charithag 8 months ago
charithag approved these changes 8 months ago
tcdlpds merged commit 64189a400d into master 8 months ago
charithag deleted branch act-fil 8 months ago

Reviewers

charithag approved these changes 8 months ago
The pull request has been merged as 64189a400d.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
charithag
Labels
Apply labels
Clear labels
pending upstream
PR depends on pending upstream dependency
No Label pending upstream
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: community/device-mgt-core#381
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'Gimhan-minion/device-mgt-core:act-fil'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes