Add scope publishing to sub tenants #308

Merged
tcdlpds merged 3 commits from navodzoysa/device-mgt-core:scope-retrieval into master 10 months ago
Collaborator

Purpose

Fixes scope permission issues in sub tenants. https://roadmap.entgra.net/issues/10374

## Purpose Fixes scope permission issues in sub tenants. https://roadmap.entgra.net/issues/10374
navodzoysa force-pushed scope-retrieval from 206f4c4b9d to 668d44d621 10 months ago
navodzoysa force-pushed scope-retrieval from 668d44d621 to 8271cee9b0 10 months ago
navodzoysa force-pushed scope-retrieval from 8271cee9b0 to 4370048d0f 10 months ago
navodzoysa force-pushed scope-retrieval from 4370048d0f to 26531f5d68 10 months ago
navodzoysa force-pushed scope-retrieval from 26531f5d68 to 792bd1800e 10 months ago
navodzoysa force-pushed scope-retrieval from 792bd1800e to 935d9029dd 10 months ago
tcdlpds requested changes 10 months ago
}
}
private String generateInitialUserPassword() {
Owner

What is the usage of this method?

What is the usage of this method?
navodzoysa marked this conversation as resolved
log.error(msg);
throw new BadRequestException(msg);
} else {
String msg = "Response : " + response.code() + response.body();
Owner

log the msg here.

log the msg here.
navodzoysa marked this conversation as resolved
apiPublisherDataHolder.setPermScopeMapping(permScopeMap);
}
private void removeScopePublishUserIfExist() throws UserStoreException {
Owner

Add Java Doc comment

Add Java Doc comment
navodzoysa marked this conversation as resolved
this.traccarManagementService = traccarManagementService;
}
public APIApplicationServices getApiApplicationServices() {
Owner

Add Java Doc comments

Add Java Doc comments
navodzoysa marked this conversation as resolved
}
}
private void publishScopesToTenant(String tenantDomain) throws TenantManagementException {
Owner

Add Java Doc comment

Add Java Doc comment
navodzoysa marked this conversation as resolved
}
}
private Scope createScopeObject (Scope tenantScope) {
Owner

Add Java Doc comment

Add Java Doc comment
navodzoysa marked this conversation as resolved
navodzoysa force-pushed scope-retrieval from 22cdba9275 to 7708a48344 10 months ago
navodzoysa force-pushed scope-retrieval from ad991009a6 to 3d9a76c962 10 months ago
tcdlpds reviewed 10 months ago
apiApplicationKey, accessTokenInfo);
updatePermScopeMetaData(superTenantPermScopeMapping, metadataManagementService);
}
// Delete the temporary scope publish user after scopes are added or deleted to sub tenant space
Owner

Do we need this part? Isn't it handling in finally bloick?

Do we need this part? Isn't it handling in finally bloick?
navodzoysa marked this conversation as resolved
navodzoysa force-pushed scope-retrieval from 3d9a76c962 to 1fde569f4a 10 months ago
tcdlpds merged commit e017425539 into master 10 months ago

Reviewers

tcdlpds requested changes 10 months ago
The pull request has been merged as e017425539.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: community/device-mgt-core#308
Loading…
There is no content yet.