Resoled changes #154

Merged
tcdlpds merged 3 commits from nishan/device-mgt-core:visible-roles into master 1 year ago
nishan commented 1 year ago
Fixes: [https://roadmap.entgra.net/issues/9775](https://roadmap.entgra.net/issues/9775)
tcdlpds requested changes 1 year ago
log.error(msg, e);
throw new ApplicationManagementException(msg, e);
} catch (MetadataManagementException e) {
log.error("Error occurred while retrieving metadata list", e);
Owner

You need to log the error message and throw it.

You need to log the error message and throw it.
nishan marked this conversation as resolved
throw new ApplicationManagementException(msg, e);
} catch (MetadataManagementException e) {
log.error("Error occurred while retrieving metadata list", e);
throw new RuntimeException(e);
Owner

What's the reason for throwing RuntimeException here?

What's the reason for throwing RuntimeException here?
nishan marked this conversation as resolved
nishan force-pushed visible-roles from 73732e7ffd to 229c8dcb34 1 year ago
tcdlpds requested changes 1 year ago
} catch (MetadataManagementException e) {
String msg = "Error occurred while retrieving metadata list";
log.error(msg, e);
throw new MetadataManagementException(msg, e);
Owner

Throw ApplicationManagement Exception

Throw ApplicationManagement Exception
nishan marked this conversation as resolved
nishan added 1 commit 1 year ago
tcdlpds approved these changes 1 year ago
tcdlpds merged commit 3616245ae6 into master 1 year ago

Reviewers

tcdlpds approved these changes 1 year ago
The pull request has been merged as 3616245ae6.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: community/device-mgt-core#154
Loading…
There is no content yet.