Addressing review comments

merge-requests/713/head
Ace 4 years ago
parent 5531bc0140
commit ceab2566ac

@ -788,7 +788,9 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
}
}
} catch (SQLException e) {
throw new DeviceManagementDAOException("Error occurred while listing devices for type '" + type + "'", e);
String msg = "Error occurred while listing devices for type '" + type + "'";
log.error(msg, e);
throw new DeviceManagementDAOException(msg, e);
} finally {
DeviceManagementDAOUtil.cleanupResources(stmt, rs);
}
@ -846,15 +848,17 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
}
}
} catch (Exception e) {
log.error("Error encountered while populating allocated active devices for server with index : " + serverIndex +
" active-server-count " + activeServerCount + " device-type " + type + " tenant-id " + tenantId);
throw new DeviceManagementDAOException("Error occurred while populating active devices '" + type + "'", e);
String msg = "Error encountered while populating allocated active devices for server with index : " + serverIndex +
" active-server-count " + activeServerCount + " device-type " + type + " tenant-id " + tenantId;
log.error(msg, e);
throw new DeviceManagementDAOException(msg, e);
}
}
} catch (SQLException e) {
log.error("Error encountered while retrieving allocated devices for server with index : " + serverIndex +
" active-server-count " + activeServerCount + " device-type " + type + " tenant-id " + tenantId);
throw new DeviceManagementDAOException("Error occurred while listing devices for type '" + type + "'", e);
String msg = "Error encountered while retrieving allocated devices for server with index : " + serverIndex +
" active-server-count " + activeServerCount + " device-type " + type + " tenant-id " + tenantId;
log.error(msg, e);
throw new DeviceManagementDAOException(msg, e);
}
return devices;
}

@ -283,6 +283,7 @@ public class HeartBeatManagementServiceImpl implements HeartBeatManagementServic
}
} catch (HeartBeatDAOException e) {
String msg = "Error occurred while recording heart beat.";
log.error(msg);
throw new HeartBeatManagementException(msg, e);
} catch (TransactionManagementException e) {
HeartBeatBeaconDAOFactory.rollbackTransaction();

@ -30,7 +30,7 @@
<artifactId>heartbeat-management</artifactId>
<packaging>pom</packaging>
<name>Entgra - Task Allocation Framework</name>
<url>http://wso2.org</url>
<url>http://entgra.io</url>
<modules>
<module>io.entgra.server.bootup.heartbeat.beacon</module>

Loading…
Cancel
Save