Merge branch 'master' into 'master'

Fix only reading one result when multiple results are present

See merge request entgra/carbon-device-mgt!436

components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/impl/AbstractDeviceDAOImpl.java

@@ -1837,7 +1837,7 @@ public abstract class AbstractDeviceDAOImpl implements DeviceDAO {
                 try (ResultSet rs = ps.executeQuery()) {
                     List<Device> devices = new ArrayList<>();
                     DeviceInfo deviceInfo = new DeviceInfo();
-                    if (rs.next()) {
+                    while (rs.next()) {
                         Device device = DeviceManagementDAOUtil.loadDevice(rs);
                         deviceInfo.setOsVersion(rs.getString(Constants.OS_VERSION));
                         deviceInfo.setOsBuildDate(rs.getString(Constants.OS_BUILD_DATE));

components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/dao/impl/device/OracleDeviceDAOImpl.java

@@ -876,7 +876,7 @@ public class OracleDeviceDAOImpl extends AbstractDeviceDAOImpl {
                 try (ResultSet rs = ps.executeQuery()) {
                     List<Device> devices = new ArrayList<>();
                     DeviceInfo deviceInfo = new DeviceInfo();
-                    if (rs.next()) {
+                    while (rs.next()) {
                         Device device = DeviceManagementDAOUtil.loadDevice(rs);
                         deviceInfo.setOsVersion(rs.getString(Constants.OS_VERSION));
                         deviceInfo.setOsBuildDate(rs.getString(Constants.OS_BUILD_DATE));

components/device-mgt/org.wso2.carbon.device.mgt.core/src/main/java/org/wso2/carbon/device/mgt/core/report/mgt/ReportManagementServiceImpl.java

@@ -160,7 +160,6 @@ public class ReportManagementServiceImpl implements ReportManagementService {
     public PaginationResult getDevicesExpiredByOSVersion(PaginationRequest request)
             throws ReportManagementException, DeviceTypeNotFoundException {
         if (request == null ||
-            StringUtils.isBlank(request.getDeviceType()) ||
             StringUtils.isBlank(request.getDeviceType()) ||
             !request.getProperties().containsKey(Constants.OS_BUILD_DATE) ||
             (Long) request.getProperty(Constants.OS_BUILD_DATE) == 0) {